cli/pkg/cmd
Tyler McGoffin e1423cdbbf Refine error handling of ReadBranchConfig
cmd.Output() will return an error when the git command ran successfully
but had no output. To handle this, we can check Stderr, as we expect it to
be populated for any ExitErrors or otherwise when there is a command
failure.

This allows for propagation of this error handling up the call chain, so
we are now returning errors if the call to git fails instead of just
handing off an empty BranchConfig and suppressing the errors.

Additionally, I've removed some more naked returns that I found in
pkg/cmd/pr/create.go createRun
2025-01-09 11:45:15 -08:00
..
actions Additional formatting changes 2023-12-01 09:08:51 -05:00
alias Move config interfaces into gh package (#9060) 2024-05-10 10:39:36 +02:00
api Update documentation for gh api PATCH 2024-07-22 19:36:20 +01:00
attestation add test for different SAN and SourceRepositoryURI values 2024-12-18 07:24:44 -07:00
auth Update pkg/cmd/auth/login/login.go 2025-01-06 17:21:02 +01:00
browse docs: update description of command 2024-12-06 20:43:54 +03:00
cache Apply suggestions from code review 2024-11-21 13:55:35 -07:00
codespace fix: list branches in square brackets in gh codespace 2024-12-10 15:19:30 -05:00
completion Bump github.com/spf13/cobra from v1.4.0 to v1.5.0 (#6196) 2022-09-06 09:43:40 +04:00
config Add prefer_editor_prompt config 2024-07-09 21:01:50 +09:00
extension Upgrade generated workflows 2025-01-05 23:18:28 -05:00
factory Document SmartBaseRepoFunc 2024-12-23 19:07:17 +01:00
gist Merge pull request #9728 from heaths/issue9704 2024-10-15 16:26:13 -07:00
gpg-key Move config interfaces into gh package (#9060) 2024-05-10 10:39:36 +02:00
issue Merge changes from #10004 2024-12-08 20:34:21 -08:00
label Fix tests 2024-08-16 10:11:52 -07:00
org Move config interfaces into gh package (#9060) 2024-05-10 10:39:36 +02:00
pr Refine error handling of ReadBranchConfig 2025-01-09 11:45:15 -08:00
project Move config interfaces into gh package (#9060) 2024-05-10 10:39:36 +02:00
release Refactor error handling for missing "workflow" scope in createRelease 2024-11-23 16:59:49 -07:00
repo Merge branch 'trunk' into trunk 2025-01-04 10:24:07 +05:30
root Update gh auth commands to point to GitHub Docs 2024-12-12 11:03:57 -05:00
ruleset Use go-gh/auth package for IsEnterprise, IsTenancy, and NormalizeHostname 2024-10-15 11:56:43 -07:00
run add pending status for workflow runs 2024-12-26 19:10:06 +03:00
search Resolve PR feedback 2024-10-14 15:08:23 -07:00
secret Fix host handling in variable and secret delete 2024-08-02 15:11:22 -04:00
ssh-key Move config interfaces into gh package (#9060) 2024-05-10 10:39:36 +02:00
status Move config interfaces into gh package (#9060) 2024-05-10 10:39:36 +02:00
variable Merge branch 'trunk' into tab-indents 2024-08-06 13:08:48 -04:00
version Fix --version flag printing to stdout 2022-05-24 16:21:13 +02:00
workflow Fix tests 2024-08-16 10:11:52 -07:00