cli/pkg/cmd/pr/shared
Kynan Ware e6d9019bc9 fix(pr create): use login-based assignee mutation on github.com
When ActorAssignees is true (github.com), pass assignee logins directly
to the ReplaceActorsForAssignable mutation instead of resolving logins
to node IDs. This eliminates the need to bulk fetch all assignable
users/actors and fixes a bug where providing assignees via CLI flag
and then interactively adding metadata would fail with 'not found'
because the cached MetadataResult had no assignee data.

Changes:
- Set state.ActorAssignees = true in pr create (was missing)
- AddMetadataToIssueParams: pass assigneeLogins when ActorAssignees
  is true, skip fetch and ID resolution entirely
- CreatePullRequest/IssueCreate: call ReplaceActorsForAssignableByLogin
  after creation to assign via logins
- Consolidate replaceActorsForAssignable mutation into api/ package
  (ReplaceActorsForAssignableByLogin + ReplaceActorsForAssignableByID)
- Remove duplicate replaceActorAssigneesForEditable from editable_http.go
- Add TODO replaceActorsByLoginCleanup markers on edit paths

Fixes cli/cli#13000

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-03-23 15:21:20 -06:00
..
commentable.go Add --delete-last option to pr comment and issue comment (#10596) 2025-05-01 14:12:55 +01:00
comments.go Deprecate ColorScheme.Gray for ColorScheme.Muted 2025-04-06 10:18:48 -04:00
completion.go Include org teams for PR reviewers 2025-07-29 18:19:22 -04:00
completion_test.go Refactor tab completion test 2025-07-30 09:25:33 -04:00
display.go Deprecate ColorScheme.Gray for ColorScheme.Muted 2025-04-06 10:18:48 -04:00
display_test.go Adding no checks message when PR has no checks 2022-10-05 22:10:38 -03:00
editable.go fix(pr create): use login-based assignee mutation on github.com 2026-03-23 15:21:20 -06:00
editable_http.go fix(pr create): use login-based assignee mutation on github.com 2026-03-23 15:21:20 -06:00
find_refs_resolution.go chore: fix function name 2025-06-19 12:36:52 +08:00
find_refs_resolution_test.go Fix pr create when push.default tracking and no merge ref (#10863) 2025-04-24 16:41:14 +00:00
finder.go Add missing TODO comments for featuredetection if-statements 2026-02-16 14:24:32 -07:00
finder_test.go fix(pr/shared): improve ParseFullReference error message 2026-01-21 23:30:43 +00:00
git_cached_config_client.go Rework ref usage when finding and creating PRs 2025-04-15 13:38:10 -06:00
lister.go Fix checkout when URL arg is from fork and cwd is upstream 2025-02-27 16:56:11 +01:00
params.go fix(pr create): use login-based assignee mutation on github.com 2026-03-23 15:21:20 -06:00
params_test.go Add CCR and reviewer MultiSelectWithSearch 2026-01-27 23:11:51 -07:00
preserve.go Rename the module to "github.com/cli/cli/v2" 2021-08-25 12:41:30 +02:00
preserve_test.go Replace ioutil with io and os (#5498) 2022-04-26 13:07:44 +02:00
reaction_groups.go Rename the module to "github.com/cli/cli/v2" 2021-08-25 12:41:30 +02:00
state.go gh pr create: CCR and multiselectwithsearch 2026-02-04 14:56:05 -07:00
survey.go Add TODO requestReviewsByLoginCleanup on static reviewer MultiSelect 2026-03-05 10:57:45 -07:00
survey_test.go gh pr create: CCR and multiselectwithsearch 2026-02-04 14:56:05 -07:00
templates.go fix: ignore nilerr on intentionally swallowed error 2025-11-03 20:05:27 +00:00
templates_test.go Add issue create --editor 2024-07-09 21:01:50 +09:00