As explained in https://git-scm.com/docs/git-config#Documentation/git-config.txt-branchltnamegtremote if you have `remote.pushDefault` set in your global gitconfig (like I do), then _that_ setting will take precedence over `branch.<name>.remote` 😞 However, `branch.<name>.pushRemote` will take precedence over your `remote.pushDefault` setting, such that `gh pr checkout 123 && make changes && git push` will just work, even if you have `remote.pushDefault` set 💪
259 lines
7.9 KiB
Go
259 lines
7.9 KiB
Go
package checkout
|
|
|
|
import (
|
|
"fmt"
|
|
"net/http"
|
|
"os"
|
|
"os/exec"
|
|
"strings"
|
|
|
|
"github.com/cli/cli/v2/api"
|
|
"github.com/cli/cli/v2/context"
|
|
"github.com/cli/cli/v2/git"
|
|
"github.com/cli/cli/v2/internal/config"
|
|
"github.com/cli/cli/v2/internal/ghrepo"
|
|
"github.com/cli/cli/v2/internal/run"
|
|
"github.com/cli/cli/v2/pkg/cmd/pr/shared"
|
|
"github.com/cli/cli/v2/pkg/cmdutil"
|
|
"github.com/cli/cli/v2/pkg/iostreams"
|
|
"github.com/cli/safeexec"
|
|
"github.com/spf13/cobra"
|
|
)
|
|
|
|
type CheckoutOptions struct {
|
|
HttpClient func() (*http.Client, error)
|
|
Config func() (config.Config, error)
|
|
IO *iostreams.IOStreams
|
|
Remotes func() (context.Remotes, error)
|
|
Branch func() (string, error)
|
|
|
|
Finder shared.PRFinder
|
|
|
|
SelectorArg string
|
|
RecurseSubmodules bool
|
|
Force bool
|
|
Detach bool
|
|
BranchName string
|
|
}
|
|
|
|
func NewCmdCheckout(f *cmdutil.Factory, runF func(*CheckoutOptions) error) *cobra.Command {
|
|
opts := &CheckoutOptions{
|
|
IO: f.IOStreams,
|
|
HttpClient: f.HttpClient,
|
|
Config: f.Config,
|
|
Remotes: f.Remotes,
|
|
Branch: f.Branch,
|
|
}
|
|
|
|
cmd := &cobra.Command{
|
|
Use: "checkout {<number> | <url> | <branch>}",
|
|
Short: "Check out a pull request in git",
|
|
Args: cmdutil.ExactArgs(1, "argument required"),
|
|
RunE: func(cmd *cobra.Command, args []string) error {
|
|
opts.Finder = shared.NewFinder(f)
|
|
|
|
if len(args) > 0 {
|
|
opts.SelectorArg = args[0]
|
|
}
|
|
|
|
if runF != nil {
|
|
return runF(opts)
|
|
}
|
|
return checkoutRun(opts)
|
|
},
|
|
}
|
|
|
|
cmd.Flags().BoolVarP(&opts.RecurseSubmodules, "recurse-submodules", "", false, "Update all submodules after checkout")
|
|
cmd.Flags().BoolVarP(&opts.Force, "force", "f", false, "Reset the existing local branch to the latest state of the pull request")
|
|
cmd.Flags().BoolVarP(&opts.Detach, "detach", "", false, "Checkout PR with a detached HEAD")
|
|
cmd.Flags().StringVarP(&opts.BranchName, "branch", "b", "", "Local branch name to use (default: the name of the head branch)")
|
|
|
|
return cmd
|
|
}
|
|
|
|
func checkoutRun(opts *CheckoutOptions) error {
|
|
findOptions := shared.FindOptions{
|
|
Selector: opts.SelectorArg,
|
|
Fields: []string{"number", "headRefName", "headRepository", "headRepositoryOwner", "isCrossRepository", "maintainerCanModify"},
|
|
}
|
|
pr, baseRepo, err := opts.Finder.Find(findOptions)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
cfg, err := opts.Config()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
protocol, _ := cfg.Get(baseRepo.RepoHost(), "git_protocol")
|
|
|
|
remotes, err := opts.Remotes()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
baseRemote, _ := remotes.FindByRepo(baseRepo.RepoOwner(), baseRepo.RepoName())
|
|
baseURLOrName := ghrepo.FormatRemoteURL(baseRepo, protocol)
|
|
if baseRemote != nil {
|
|
baseURLOrName = baseRemote.Name
|
|
}
|
|
|
|
headRemote := baseRemote
|
|
if pr.HeadRepository == nil {
|
|
headRemote = nil
|
|
} else if pr.IsCrossRepository {
|
|
headRemote, _ = remotes.FindByRepo(pr.HeadRepositoryOwner.Login, pr.HeadRepository.Name)
|
|
}
|
|
|
|
if strings.HasPrefix(pr.HeadRefName, "-") {
|
|
return fmt.Errorf("invalid branch name: %q", pr.HeadRefName)
|
|
}
|
|
|
|
var cmdQueue [][]string
|
|
|
|
if headRemote != nil {
|
|
cmdQueue = append(cmdQueue, cmdsForExistingRemote(headRemote, pr, opts)...)
|
|
} else {
|
|
httpClient, err := opts.HttpClient()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
apiClient := api.NewClientFromHTTP(httpClient)
|
|
|
|
defaultBranch, err := api.RepoDefaultBranch(apiClient, baseRepo)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
cmdQueue = append(cmdQueue, cmdsForMissingRemote(pr, baseURLOrName, baseRepo.RepoHost(), defaultBranch, protocol, opts)...)
|
|
}
|
|
|
|
if opts.RecurseSubmodules {
|
|
cmdQueue = append(cmdQueue, []string{"git", "submodule", "sync", "--recursive"})
|
|
cmdQueue = append(cmdQueue, []string{"git", "submodule", "update", "--init", "--recursive"})
|
|
}
|
|
|
|
err = executeCmds(cmdQueue)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func cmdsForExistingRemote(remote *context.Remote, pr *api.PullRequest, opts *CheckoutOptions) [][]string {
|
|
var cmds [][]string
|
|
remoteBranch := fmt.Sprintf("%s/%s", remote.Name, pr.HeadRefName)
|
|
|
|
refSpec := fmt.Sprintf("+refs/heads/%s", pr.HeadRefName)
|
|
if !opts.Detach {
|
|
refSpec += fmt.Sprintf(":refs/remotes/%s", remoteBranch)
|
|
}
|
|
|
|
cmds = append(cmds, []string{"git", "fetch", remote.Name, refSpec})
|
|
|
|
localBranch := pr.HeadRefName
|
|
if opts.BranchName != "" {
|
|
localBranch = opts.BranchName
|
|
}
|
|
|
|
switch {
|
|
case opts.Detach:
|
|
cmds = append(cmds, []string{"git", "checkout", "--detach", "FETCH_HEAD"})
|
|
case localBranchExists(localBranch):
|
|
cmds = append(cmds, []string{"git", "checkout", localBranch})
|
|
if opts.Force {
|
|
cmds = append(cmds, []string{"git", "reset", "--hard", fmt.Sprintf("refs/remotes/%s", remoteBranch)})
|
|
} else {
|
|
// TODO: check if non-fast-forward and suggest to use `--force`
|
|
cmds = append(cmds, []string{"git", "merge", "--ff-only", fmt.Sprintf("refs/remotes/%s", remoteBranch)})
|
|
}
|
|
default:
|
|
cmds = append(cmds, []string{"git", "checkout", "-b", localBranch, "--track", remoteBranch})
|
|
}
|
|
|
|
return cmds
|
|
}
|
|
|
|
func cmdsForMissingRemote(pr *api.PullRequest, baseURLOrName, repoHost, defaultBranch, protocol string, opts *CheckoutOptions) [][]string {
|
|
var cmds [][]string
|
|
ref := fmt.Sprintf("refs/pull/%d/head", pr.Number)
|
|
|
|
if opts.Detach {
|
|
cmds = append(cmds, []string{"git", "fetch", baseURLOrName, ref})
|
|
cmds = append(cmds, []string{"git", "checkout", "--detach", "FETCH_HEAD"})
|
|
return cmds
|
|
}
|
|
|
|
localBranch := pr.HeadRefName
|
|
if opts.BranchName != "" {
|
|
localBranch = opts.BranchName
|
|
} else if pr.HeadRefName == defaultBranch {
|
|
// avoid naming the new branch the same as the default branch
|
|
localBranch = fmt.Sprintf("%s/%s", pr.HeadRepositoryOwner.Login, localBranch)
|
|
}
|
|
|
|
currentBranch, _ := opts.Branch()
|
|
if localBranch == currentBranch {
|
|
// PR head matches currently checked out branch
|
|
cmds = append(cmds, []string{"git", "fetch", baseURLOrName, ref})
|
|
if opts.Force {
|
|
cmds = append(cmds, []string{"git", "reset", "--hard", "FETCH_HEAD"})
|
|
} else {
|
|
// TODO: check if non-fast-forward and suggest to use `--force`
|
|
cmds = append(cmds, []string{"git", "merge", "--ff-only", "FETCH_HEAD"})
|
|
}
|
|
} else {
|
|
if opts.Force {
|
|
cmds = append(cmds, []string{"git", "fetch", baseURLOrName, fmt.Sprintf("%s:%s", ref, localBranch), "--force"})
|
|
} else {
|
|
// TODO: check if non-fast-forward and suggest to use `--force`
|
|
cmds = append(cmds, []string{"git", "fetch", baseURLOrName, fmt.Sprintf("%s:%s", ref, localBranch)})
|
|
}
|
|
|
|
cmds = append(cmds, []string{"git", "checkout", localBranch})
|
|
}
|
|
|
|
remote := baseURLOrName
|
|
mergeRef := ref
|
|
if pr.MaintainerCanModify && pr.HeadRepository != nil {
|
|
headRepo := ghrepo.NewWithHost(pr.HeadRepositoryOwner.Login, pr.HeadRepository.Name, repoHost)
|
|
remote = ghrepo.FormatRemoteURL(headRepo, protocol)
|
|
mergeRef = fmt.Sprintf("refs/heads/%s", pr.HeadRefName)
|
|
}
|
|
if missingMergeConfigForBranch(localBranch) {
|
|
// .remote is needed for `git pull` to work
|
|
// .pushRemote is needed for `git push` to work, if user has set `remote.pushDefault`.
|
|
// see https://git-scm.com/docs/git-config#Documentation/git-config.txt-branchltnamegtremote
|
|
cmds = append(cmds, []string{"git", "config", fmt.Sprintf("branch.%s.remote", localBranch), remote})
|
|
cmds = append(cmds, []string{"git", "config", fmt.Sprintf("branch.%s.pushRemote", localBranch), remote})
|
|
cmds = append(cmds, []string{"git", "config", fmt.Sprintf("branch.%s.merge", localBranch), mergeRef})
|
|
}
|
|
|
|
return cmds
|
|
}
|
|
|
|
func missingMergeConfigForBranch(b string) bool {
|
|
mc, err := git.Config(fmt.Sprintf("branch.%s.merge", b))
|
|
return err != nil || mc == ""
|
|
}
|
|
|
|
func localBranchExists(b string) bool {
|
|
_, err := git.ShowRefs("refs/heads/" + b)
|
|
return err == nil
|
|
}
|
|
|
|
func executeCmds(cmdQueue [][]string) error {
|
|
for _, args := range cmdQueue {
|
|
// TODO: reuse the result of this lookup across loop iteration
|
|
exe, err := safeexec.LookPath(args[0])
|
|
if err != nil {
|
|
return err
|
|
}
|
|
cmd := exec.Command(exe, args[1:]...)
|
|
cmd.Stdout = os.Stdout
|
|
cmd.Stderr = os.Stderr
|
|
if err := run.PrepareCmd(cmd).Run(); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
return nil
|
|
}
|