Commit graph

6 commits

Author SHA1 Message Date
jaime merino
9e098fbb6e - Fixed Approver Expansion: Repaired the broken expandGroupFromUser function in approvers.go. It now correctly utilizes the Forgejo SDK to search for teams within an organization and expand them into individual users, while respecting the option to exclude the workflow initiator.
- Removed GitHub Dependencies: Excised the unused newGithubClient and its associated dependencies (google/go-github and oauth2) from main.go and go.mod.

   - Project Infrastructure Updates:
       - Updated Dockerfile to use golang:1.25 for consistency with go.mod.
       - Modified action.yaml to run from the local Dockerfile, ensuring that the Forgejo-specific logic is utilized.
   - Validation: Verified all changes through a successful build and by running the full test suite, all of which passed.
2026-04-22 15:28:23 +02:00
Thomas Stringer
05a49ff052
Fix bug with period in org team name (#60)
Currently if you have an org team name with a period in it, the team will not be found with a 404 response. This is because the GitHub API requires that the periods are replaced with hyphens. This PR fixes this behavior and closes #55.

Signed-off-by: Thomas Stringer <thomas@trstringer.com>
2022-11-11 17:59:51 -05:00
Timothy Ng
753e13e935
Option to exclude workflow initiator (GITHUB_ACTOR) as an approver (#59)
* Add constant for GITHUB_ACTOR env var

* autoformat

* Ignore workflow initiator

* Fix incorrect if-else

* refactor: camelcase userName

* fix typo

* Add allow-workflow-initiator-as-approver input

* Add shouldIncludeWorkflowInitiator

* Add usage & description for allow-workflow-initiator-as-approver

* Clearer input description

* refactor: rename inputs/vars to 'exclude'

* update error msg with correct input name

* docs: move note on optional/default to description
2022-11-10 12:25:31 -05:00
Troy Witthoeft
2e9a86d9a2
Update approvers.go (#44)
Handling usernames with whitespace issue = https://github.com/trstringer/manual-approval/issues/43
2022-08-21 13:10:25 -04:00
Thomas Stringer
8cbc88a78c
Troubleshoot and log failed group expansion (#34)
Currently group expansion is failing. I suspect this is due to workflow
permissions, as this succeeds locally. This additional logging should
show unexpected errors that aren't just a non-group expansion.
2022-07-14 22:29:36 -04:00
Thomas Stringer
78b4c148f1
Add ability to specify a team as an approver (#32)
Prior to this change, the approvers could only be explicit users. With
this change, you can now specify an org team and this will be expanded
out with a user list for approvers.

Closes #14.
2022-07-14 22:11:38 -04:00