Simplify suggested assignable actors
Simplifies SuggestedAssignableActors by no longer including the viewer in the returned actors list when the query is blank. Removes related logic and variables for viewer handling.
This commit is contained in:
parent
38f9d7891b
commit
346bd8c002
1 changed files with 1 additions and 14 deletions
|
|
@ -780,29 +780,16 @@ func SuggestedAssignableActors(client *Client, repo ghrepo.Interface, assignable
|
|||
nodes = result.Node.Issue.SuggestedActors.Nodes
|
||||
}
|
||||
|
||||
actors := make([]AssignableActor, 0, len(nodes)+1) // +1 in case we add viewer
|
||||
viewer := result.Viewer
|
||||
viewerLogin := viewer.Login
|
||||
viewerIncluded := false
|
||||
actors := make([]AssignableActor, 0, len(nodes))
|
||||
|
||||
for _, n := range nodes {
|
||||
if n.TypeName == "User" && n.User.Login != "" {
|
||||
actors = append(actors, AssignableUser{id: n.User.ID, login: n.User.Login, name: n.User.Name})
|
||||
if query == "" && viewerLogin != "" && n.User.Login == viewerLogin {
|
||||
viewerIncluded = true
|
||||
}
|
||||
} else if n.TypeName == "Bot" && n.Bot.Login != "" {
|
||||
actors = append(actors, AssignableBot{id: n.Bot.ID, login: n.Bot.Login})
|
||||
if query == "" && viewerLogin != "" && n.Bot.Login == viewerLogin {
|
||||
viewerIncluded = true
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// When query is blank, append viewer if not already present.
|
||||
if query == "" && viewerLogin != "" && !viewerIncluded {
|
||||
actors = append(actors, AssignableUser{id: viewer.ID, login: viewer.Login, name: viewer.Name})
|
||||
}
|
||||
return actors, nil
|
||||
}
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue