provide additional logging and fallback
Signed-off-by: Meredith Lancaster <malancas@github.com>
This commit is contained in:
parent
ab4912ff48
commit
9051da39fc
1 changed files with 4 additions and 1 deletions
|
|
@ -26,11 +26,13 @@ const (
|
||||||
// Allow injecting backoff interval in tests.
|
// Allow injecting backoff interval in tests.
|
||||||
var getAttestationRetryInterval = time.Millisecond * 200
|
var getAttestationRetryInterval = time.Millisecond * 200
|
||||||
|
|
||||||
|
// githubApiClient makes REST calls to the GitHub API
|
||||||
type githubApiClient interface {
|
type githubApiClient interface {
|
||||||
REST(hostname, method, p string, body io.Reader, data interface{}) error
|
REST(hostname, method, p string, body io.Reader, data interface{}) error
|
||||||
RESTWithNext(hostname, method, p string, body io.Reader, data interface{}) (string, error)
|
RESTWithNext(hostname, method, p string, body io.Reader, data interface{}) (string, error)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// httpClient makes HTTP calls to all non-GitHub API endpoints
|
||||||
type httpClient interface {
|
type httpClient interface {
|
||||||
Get(url string) (*http.Response, error)
|
Get(url string) (*http.Response, error)
|
||||||
}
|
}
|
||||||
|
|
@ -180,7 +182,8 @@ func (c *LiveClient) fetchBundlesByURL(attestations []*Attestation) ([]*Attestat
|
||||||
|
|
||||||
func (c *LiveClient) fetchBundleByURL(a *Attestation) (*bundle.Bundle, error) {
|
func (c *LiveClient) fetchBundleByURL(a *Attestation) (*bundle.Bundle, error) {
|
||||||
if a.BundleURL == "" {
|
if a.BundleURL == "" {
|
||||||
return nil, fmt.Errorf("bundle URL is empty")
|
c.logger.VerbosePrintf("Bundle URL is empty. Falling back to bundle field\n\n")
|
||||||
|
return a.Bundle, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
c.logger.VerbosePrintf("Fetching attestation bundle\n\n")
|
c.logger.VerbosePrintf("Fetching attestation bundle\n\n")
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue