STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

respond to review

Browse source
This commit is contained in:
Alan Donovan 2021-08-27 15:26:34 -04:00
parent 38ff786a7d
commit da34d12abb
3 changed files with 3 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
api/api.go
View file

@ -1,4 +1,4 @@
// TODO(adonovan): rename to package codespaces, and codespaces.Client?
// TODO(adonovan): rename to package codespaces, and codespaces.Client.
package api
import (

3
cmd/ghcs/main.go
View file

@ -1,8 +1,5 @@
package main
// TODO(adonovan): write 'help' commands, in manner of the 'go' tool.
// Document GITHUB_TOKEN.
import (
"errors"
"fmt"

4
cmd/ghcs/ports.go
View file

@ -83,8 +83,8 @@ func ports(opts *portsOptions) error {
devContainerResult := <-devContainerCh
if devContainerResult.err != nil {
_, _ = log.Errorf("Failed to get port names: %v\n", devContainerResult.err.Error())
// TODO(adonovan): should this cause non-zero exit?
// Warn about failure to read the devcontainer file. Not a ghcs command error.
log.Errorf("Failed to get port names: %v\n", devContainerResult.err.Error())
}
table := output.NewTable(os.Stdout, opts.asJSON)