Commit graph

5685 commits

Author SHA1 Message Date
Babak K. Shandiz
0251a8dd6d
Explain why step logs are preferred
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-04-11 09:56:17 +01:00
Kynan Ware
dec71dd9e1
Merge pull request #10710 from cli/kw/first-pass-accessible-prompter
Introduce accessible prompter for screen readers (preview)
2025-04-10 17:28:26 -06:00
Babak K. Shandiz
791e1af828
Add missing gc.AssertExpectations calls
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-04-10 14:09:49 +01:00
Babak K. Shandiz
f0d4acd501
Add tests for IsPinned method
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-04-10 14:00:24 +01:00
leudz
072534c388 Fix multi pages search for gh search 2025-04-10 07:57:43 +02:00
Kynan Ware
19633d3855
Merge pull request #10516 from iamazeem/8430-show-hostname-in-repo-creation-prompts
[gh repo create] Show host name in repo creation prompts
2025-04-09 14:30:56 -06:00
Kynan Ware
a34c9ea799 doc(prompter env): accessible prompter includes braille reader
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-04-09 08:20:07 -06:00
Kynan Ware
861563269a Merge branch 'trunk' into kw/first-pass-accessible-prompter 2025-04-09 08:07:56 -06:00
Meredith Lancaster
139e82c68c Revert "temporarily skip non-failing tests"
This reverts commit de8778797f.
2025-04-09 07:23:17 -06:00
Meredith Lancaster
7b20ee5549
Merge pull request #10749 from malancas/update-to-sigstore-go-v0.7.1
Update github.com/sigstore/sigstore-go to 0.7.1 and fix breaking function change
2025-04-09 11:58:20 +02:00
Meredith Lancaster
de8778797f temporarily skip non-failing tests
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-08 19:09:52 -06:00
Meredith Lancaster
29080dc70a reorganize func
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-08 16:40:52 -06:00
Meredith Lancaster
d63e2830e0 clean up unneeded sigstore verifier fields
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-08 16:35:17 -06:00
Meredith Lancaster
a535cfdbfc flip verifier choice logic
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-08 16:28:56 -06:00
Meredith Lancaster
2559a83945 Merge branch 'refactor-sigstore-verifier-logic' of github.com:malancas/cli into refactor-sigstore-verifier-logic 2025-04-08 16:23:46 -06:00
Meredith Lancaster
366485155e initiate custom verifiers when the sgistore verifier is created
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-08 16:23:37 -06:00
Meredith Lancaster
a3bfb158e4
Merge branch 'trunk' into refactor-sigstore-verifier-logic 2025-04-08 16:00:40 -06:00
Meredith Lancaster
323ea74733 add public good and github verifiers as fields for repeated use instead of creating a new one for every attestation
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-08 15:40:55 -06:00
Meredith Lancaster
35ec7f251c replace sigstore-go test bundle func
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-08 15:20:51 -06:00
Kynan Ware
abd573ac66 feat(preview): add preview prompter command 2025-04-08 15:14:28 -06:00
Andy Feller
47225bcf56
Merge pull request #10737 from cli/andyfeller/muted-text-part2-github-cli-833
Ensure muted text is thematic and customizable
2025-04-08 16:59:36 -04:00
Meredith Lancaster
261cea2075 update error message
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-08 14:41:18 -06:00
Andy Feller
93e51c583b
Update pkg/cmd/run/shared/presentation.go 2025-04-08 16:40:39 -04:00
Andy Feller
644dbe6275
Apply suggestions from code review
Co-authored-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2025-04-08 15:56:23 -04:00
Andy Feller
5c12f5633e Test for explicit config disable of label colors 2025-04-08 15:27:36 -04:00
Andy Feller
c5206109ca Use truthy value for GH_COLOR_LABELS 2025-04-08 15:24:18 -04:00
Kynan Ware
fa03157beb doc(help): label GH_ACCESSIBLE_PROMPTER as preview 2025-04-08 13:04:04 -06:00
Kynan Ware
19387b8418 fix(prompter): rename GH_ACCESSIBLE_PROMPTER 2025-04-08 12:52:39 -06:00
Barak Amar
747f015f48 test pr number 0 2025-04-07 22:38:28 +03:00
Kynan Ware
5996f882fc doc(envs): speech synthesis prompter 2025-04-07 10:40:29 -06:00
Babak K. Shandiz
021537418e
Verify fallback to job run logs when step logs are missing
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-04-07 13:54:30 +01:00
Babak K. Shandiz
02e8419124
Verify job run logs attached in attachRunLog test
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-04-07 13:54:29 +01:00
Babak K. Shandiz
df8c9a317d
Update run_log.zip fixture
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-04-07 13:54:29 +01:00
Babak K. Shandiz
5e78832a7e
Fallback to print entire job run log if step logs are missing
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-04-07 13:54:29 +01:00
Babak K. Shandiz
f7efdde5ef
Add Log to Job data structure
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-04-07 13:54:28 +01:00
Babak K. Shandiz
4dee1c3c98
Add jobLogFilenameRegexp function
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-04-07 13:54:28 +01:00
Babak K. Shandiz
2582948d5f
Extract job name sanitization as a separate function
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-04-07 13:54:20 +01:00
Andy Feller
918cafc222 Deprecate ColorScheme.Gray for ColorScheme.Muted
This commit converts all of the places using ColorScheme.Gray and ColorScheme.Grayf to Muted and Mutedf.

There is a little extra tidying up with local variable names or converting code to use Mutedf format.
2025-04-06 10:18:48 -04:00
Andy Feller
e067eacd81 Refactor ColorScheme initializer
This commit completely removes the iostreams.NewColorScheme() initializer function in favor of exporting the type fields for greater clarity in its use.

The result being code specifying only the fields that matter to test cases.
2025-04-04 11:57:37 -04:00
Andy Feller
addbc6ac5c Add label color env var to help topic, unused fix
This commit adds the new environment variable to the `gh environment` help topic.

Additionally, there is a small fix for Go linter for an unused variable raised as a problem.
2025-04-04 11:02:44 -04:00
Andy Feller
e9a12853cb Merge branch 'trunk' into andyfeler/colorize-label-optin 2025-04-04 09:47:41 -04:00
Barak Amar
06d22d96c0 handle find pr number 0 2025-04-04 11:14:02 +03:00
Meredith Lancaster
579fae19c9
Merge branch 'trunk' into move-predicate-type-filtering 2025-04-03 11:20:21 -06:00
Meredith Lancaster
69507282d2 restore deleted file
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-03 11:07:06 -06:00
Meredith Lancaster
164a56cb66 move filterAttestations function
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-03 11:02:45 -06:00
Andy Feller
3eca268a7f Introduce color_labels support, update commands
This commit implements the actual changes around configuration setting / environment variable logic for displaying labels using their RGB hex color code in terminals with truecolor support.

One of the subtler changes in this commit is renaming generic ColorScheme.HexToRGB logic to render truecolor to ColorScheme.Label as this feature was being used exclusively for labels.  This is due to confusion about introducing the new `color_labels` config on top of generic coloring logic.
2025-04-02 18:24:20 -04:00
Andy Feller
b52c131d4c
Merge pull request #10709 from cli/andyfeller/table-datetime-contrast-github-cli-832
Ensure table datetime columns have thematic, customizable muted text
2025-04-02 17:20:15 -04:00
Meredith Lancaster
56d924d25b getAttestations unit tests
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-01 12:58:37 -06:00
Meredith Lancaster
13dafefcb5 add missing nil struct checks and udpate error messages
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-01 11:23:25 -06:00
Meredith Lancaster
cdfb1b7279 Merge branch 'move-predicate-type-filtering' of github.com:malancas/cli into move-predicate-type-filtering 2025-04-01 11:16:05 -06:00