STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
11279 commits 87 branches 0 tags 160 MiB
Commit graph

5685 commits

Author SHA1 Message Date
Meredith Lancaster
05d9156a99 add check for nil api client 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-04-01 11:16:00 -06:00
Meredith Lancaster
a04be55092
Merge branch 'trunk' into move-predicate-type-filtering 2025-04-01 10:48:13 -06:00
Andy Feller
b3c8c70cba Remove deprecated note on gray color functions 
Without fixing all ColorScheme.Gray and ColorScheme.Grayf usage in this pull request, golangci-lint throws errors for using deprecated functions.

As that code should be replaced within github/cli#833, I'm removing the deprecation indicator for now to get this PR passing.
 2025-03-31 17:00:40 -04:00
Andy Feller
3c38cedaf3 Implement tests for muted logic, standardize reset 
This commit covers testing around the new ColorScheme.Muted logic based on various situations to gain confidence we get the accessible colors expected when enabled.

Additionally, this commit includes a small change to the existing 8-bit color logic to standardize on the same reset sequence for testing purposes.  Essentially, `ESC[m` and `ESC[0m` are equivalent but this inconsistency with our other libraries makes setting up tests a little extra confusing and difficult.
 2025-03-31 15:33:52 -04:00
Phill MV
0dd9f47159
Merge pull request #10685 from cli/phillmv/document-gh-at-verify-output 
Improve `gh at verify --help`, document json output
 2025-03-31 15:26:25 -04:00
Andy Feller
d2cd14b4cd Remove out of scope changes, update list commands 
After discussing this with the team, the `gh config` changes to display `accessible_colors` have been removed from this branch being outside of acceptance criteria.  This will be moved to a separate issue along with any other work needed to finalize the public preview such as `gh help` entries for `GH_ACCESSIBLE_COLORS` environment variable.

List commands that use ColorScheme.Gray have been updated to use ColorScheme.Muted.
 2025-03-31 11:58:30 -04:00
Andy Feller
346fab212b Accessible color config boilerplate, colors update 
This commit is focused on incorporating cli/go-gh accessible colors configuration setting into GitHub CLI experience along with new color function to supersede ColorScheme.Gray and ColorScheme.Grayf.

Originally, I was considering having all use of ColorScheme.Gray and ColorScheme.Grayf fallback to the new muted logic if accessible colors were enabled, however I decided not being that it exceeds the acceptance criteria.  This means that every command using ColorScheme.Gray needs to be updated to use ColorScheme.Muted
 2025-03-31 11:19:51 -04:00
Phill MV
0427f26884
Update pkg/cmd/attestation/verify/verify.go 
Co-authored-by: Meredith Lancaster <malancas@users.noreply.github.com>
 2025-03-31 11:05:23 -04:00
Kynan Ware
e30244686c
Merge pull request #10680 from cli/kw/update-go-gh-and-document-sprig-funcs 
Update go-gh and document available sprig funcs
 2025-03-28 12:22:14 -06:00
Kynan Ware
aac43870d4 test(release view): fix indentation 2025-03-28 12:11:57 -06:00
Kynan Ware
c6b4da8f20 doc(formatting): add line breaks for readability 2025-03-28 12:00:06 -06:00
Andy Feller
77ae842eb0
Merge pull request #10649 from cli/andyfeller/table-headers-contrast-github-cli-831 
Ensure table headers are thematically contrasting
 2025-03-28 13:30:49 -04:00
Andy Feller
eabd02793e Renaming tabl eheader variables for maintainability 2025-03-28 13:19:27 -04:00
Kynan Ware
89def92f04 doc(formatting): update sprig func descriptions 2025-03-28 09:58:48 -06:00
Kynan Ware
c1fbc2f05b test(many): fix whitespace in tests expectations 
Due to https://github.com/charmbracelet/glamour/pull/334, the margin
used for markdown rendering has changed by a couple spaces. This
corrects the relevant tests to accomodate that change.
 2025-03-27 14:21:13 -06:00
Kynan Ware
0750750f7c
Merge pull request #10660 from cli/kw/fix-run-list-with-org-required-workflows 
`run list`: do not fail on ruleset imposed workflows
 2025-03-27 13:36:29 -06:00
Phill MV
f099a54243 updated test 2025-03-27 09:57:00 -04:00
Phill MV
9c9b158d12 added minor caveat 2025-03-27 09:55:14 -04:00
Phill MV
33ab0b8f3b Tweaked language a bit, improved error message. 2025-03-27 09:47:11 -04:00
Phill MV
321e5687a6 Rewrote the gh at verify --help text to a) clarify and b) document the verificationResult object. 2025-03-26 17:40:35 -04:00
Kynan Ware
229216e830 doc(run shared): clarify 404 handling 2025-03-26 15:29:20 -06:00
Kynan Ware
49588555c3
Merge branch 'trunk' into kw/update-go-gh-and-document-sprig-funcs 2025-03-26 12:38:10 -06:00
Andy Feller
86ad62a62d Fixes #10590 
Implement missing safeguard causing `gh alias delete` tests to wipe out tester's GitHub CLI configuration.
 2025-03-26 13:42:39 -04:00
Kynan Ware
ffd42ea256 docs: add Sprig library functions to help topics 2025-03-26 10:21:41 -06:00
Andy Feller
79f1b07fb1 Implement and fix tests for table headers 2025-03-25 15:29:05 -04:00
Meredith Lancaster
166e211e2b clean up test fixtures 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-03-25 08:28:33 -06:00
Meredith Lancaster
e3fbe9008f reduce test duplication 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-03-25 08:25:00 -06:00
Meredith Lancaster
d1c4bf7dd9 comment 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-03-25 08:24:52 -06:00
Meredith Lancaster
baeaf66011 restructure api client methods 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-03-24 19:13:27 -06:00
Meredith Lancaster
0d0654738b simplify client methods 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-03-24 18:58:35 -06:00
Meredith Lancaster
a856a796f0 remove duplicate predicate filtering code 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-03-24 18:34:54 -06:00
Meredith Lancaster
a9cc7b481e create single fetch by digest client method 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-03-24 18:28:27 -06:00
Meredith Lancaster
5a895b9d72 dedpulicate if else logic 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-03-24 18:12:41 -06:00
Meredith Lancaster
95a61974bf pass params object to api client methods 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-03-24 18:01:57 -06:00
Meredith Lancaster
ad20ef35d9 move local and oci registry attestation filtering 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-03-24 17:35:52 -06:00
Meredith Lancaster
cbe80fd169 Merge branch 'trunk' into move-predicate-type-filtering 2025-03-24 17:29:24 -06:00
Meredith Lancaster
faef81f4bc reorganize getAttestations func to check for remote gh api fetching first 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-03-24 17:28:50 -06:00
Meredith Lancaster
a78c06970a pass predicate type to get attestation api methods 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-03-24 17:28:00 -06:00
Kynan Ware
c6f574ccb1
test(run list): update rulesets test name 
Co-authored-by: Andy Feller <andyfeller@github.com>
 2025-03-24 14:14:50 -06:00
Kynan Ware
30960d59bc
doc(run list): add enterprise ruleset notes 
Co-authored-by: Andy Feller <andyfeller@github.com>
 2025-03-24 14:04:16 -06:00
Kynan Ware
a35ae3b8bb refactor(tests): update test name for org workflows 2025-03-24 12:54:47 -06:00
Kynan Ware
d3ad4f410b docs(run list): doc runs without workflow names 2025-03-24 12:45:03 -06:00
Kynan Ware
5817f6fce9 fix(run list): do not fail on org workflows 2025-03-24 12:34:50 -06:00
Andy Feller
736ce69f66 Underline table headers if colors enabled but no theme 
This enhances the table header stylizing logic to ensure they are underlined if color is enabled but no theme is desired.
 2025-03-21 12:27:09 -04:00
Andy Feller
6355e54e3c Ensure table headers are thematically contrasting 
This commit refactors the color format around table headers to ensure the GitHub CLI uses thematically appropriate colors based on dark background, light background, or no color at all.

In order to do so, `ColorScheme` needs information from the terminal about the background appearance (dark, light, none) to determine appropriate muted color.
 2025-03-21 11:51:03 -04:00
Andy Feller
45ffa3c668
Merge pull request #10625 from cli/andyfeller/10580-edit-last-regression 
Editing last comment on issue or pull request only creates comment if --create-if-none flag is set
 2025-03-19 08:24:42 -04:00
Andy Feller
bbb8213e9c Refactor commentable logic 2025-03-19 07:56:53 -04:00
Andy Feller
bec527d49e Clean up pr/issue comment test names 2025-03-18 16:14:14 -04:00
Andy Feller
a47651df43 Bring issue/PR comment tests up to par, correct 
This commit brings the `gh issue comment` and `gh pr comment` tests in line with one another while also addressing some corner cases that weren't previously tested.
 2025-03-18 15:56:25 -04:00
William Martin
f4382d1345 Revert "Merge pull request #10384 from iamazeem/9798-gh-api-encode-package-name" 
This reverts commit ed2c322a73, reversing
changes made to f019cf7cea.
 2025-03-18 13:13:06 +01:00