Azeem Sajid
d6be4981be
Address PR review comments
2025-01-31 12:28:00 +05:00
Meredith Lancaster
fc2f18c896
consolidate tests around getBundle func when possible
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-30 11:12:58 -07:00
Meredith Lancaster
795263524d
change permanent backoff error condition
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-30 11:11:41 -07:00
Azeem Sajid
77ce9c7da2
Merge branch 'trunk' into 10301-gh-project-iteration-id
2025-01-30 22:24:53 +05:00
Meredith Lancaster
e9f7761423
dont retry when parsing fails
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-30 09:56:06 -07:00
Meredith Lancaster
dcb182b453
Merge branch 'trunk' into attestation-bundle-fetch-improvements
2025-01-30 09:53:27 -07:00
Meredith Lancaster
70ae9f39ef
update tests to account for logic flip
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-30 09:26:41 -07:00
Meredith Lancaster
ddb8855198
flip bundle fetching logic
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-30 09:12:48 -07:00
Meredith Lancaster
1c326c74f0
add checks to cert extensions func
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-30 08:14:13 -07:00
Meredith Lancaster
e10010c4cf
fix option ordering
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-30 08:03:36 -07:00
Meredith Lancaster
c6b5928ddc
fix issues causing tests to fail
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-30 07:58:42 -07:00
Meredith Lancaster
313faf9cd0
add signer and source ref, commit options
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-30 07:43:13 -07:00
Azeem Sajid
029a5a577b
Update test
2025-01-30 19:23:07 +05:00
Azeem Sajid
978d3fce87
[gh issue/pr list] Improve help text
2025-01-30 13:05:18 +05:00
Azeem Sajid
3bc7b7e7e2
[gh extensions install] Improve help text and error message
2025-01-30 11:40:42 +05:00
Azeem Sajid
9e14550f11
[gh api] Fix mutual exclusion messages of --slurp flag
2025-01-30 10:21:18 +05:00
Michael Hoffman
d609c40404
Merge branch 'trunk' into view-autolinks
2025-01-29 16:43:23 -05:00
Michael Hoffman
b23cf6e8d7
Update formatting for autolink output
2025-01-29 16:24:47 -05:00
Tyler McGoffin
de9971d718
Merge pull request #9208 from Frederick888/find-pr-by-rev-parse-push
...
Find PRs using `@{push}`
2025-01-29 12:11:32 -08:00
Tyler McGoffin
e0f624ba24
Rename PRRefs to PullRequestRefs and PR comment cleanup
2025-01-29 11:56:31 -08:00
Michael Hoffman
e4d720ba22
Remove redundant error check
2025-01-29 11:12:28 -05:00
Michael Hoffman
9725a32f3e
Merge branch 'trunk' into view-autolinks
2025-01-29 10:52:00 -05:00
Andy Feller
fe21e10ae8
Keeping autolink IDs the same in all test cases
2025-01-29 10:16:02 -05:00
Andy Feller
af538b277d
Expand test case
...
- add autolink view case for numeric
- simplifying local variable usage
2025-01-29 10:10:42 -05:00
Michael Hoffman
21a5267be4
Remove unused test field
2025-01-29 09:35:05 -05:00
Michael Hoffman
8b7d6d1b3f
Remove unused test field
2025-01-29 09:34:29 -05:00
Azeem Sajid
4b755bec04
Merge branch 'trunk' into 10301-gh-project-iteration-id
2025-01-29 18:35:01 +05:00
Azeem Sajid
8bab4b4753
[gh project item-list] Add iterationId field in ProjectV2ItemFieldIterationValue
2025-01-29 18:30:43 +05:00
Azeem Sajid
7cca07b699
Merge branch 'trunk' into 9781-gh-workflow-run-default-branch-validation
2025-01-29 16:43:41 +05:00
Azeem Sajid
c7dd9edd57
[gh workflow run] Improve error handling for --ref flag
2025-01-29 16:39:56 +05:00
Azeem Sajid
b8d32e5d33
Merge branch 'trunk' into 9897-gh-cache-delete-exit-code
2025-01-29 14:56:18 +05:00
Azeem Sajid
82ee9a2c75
[gh cache delete --all] Add --succeed-on-no-caches flag to return exit code 0
2025-01-29 14:53:09 +05:00
Azeem Sajid
ab2455c848
Merge branch 'trunk' into stop-progress-indicator-on-failure-for-run-list
2025-01-29 08:23:07 +05:00
Azeem Sajid
de7c40789e
Use defer instead
2025-01-29 08:22:32 +05:00
Tyler McGoffin
75a23e73eb
Merge pull request #10309 from cli/update-sigstore-go-v0.7.0
...
Upgrade sigstore-go to v0.7.0: fixes #10114 formatting issue
2025-01-28 15:00:43 -08:00
Michael Hoffman
8f55dbcf61
Error case test for viewRun
2025-01-28 14:07:48 -05:00
Michael Hoffman
32ee4db484
Autolink view HTTP tests
2025-01-28 13:33:50 -05:00
Michael Hoffman
58d84a4088
Shorten description
2025-01-28 12:03:03 -05:00
Michael Hoffman
11ce0c661c
Updates following renaming domain to shared
2025-01-28 11:43:57 -05:00
Michael Hoffman
f941608091
Partial testing for view
2025-01-28 11:43:57 -05:00
Michael Hoffman
e8475d9fb8
Initial, working implementation
2025-01-28 11:43:57 -05:00
Azeem Sajid
359b4a1d63
Stop progress indicator on failure (gh run list --workflow)
2025-01-28 17:18:30 +05:00
Tyler McGoffin
e31bfd0092
Cleaned up some naming and comments
2025-01-27 16:40:47 -08:00
Andy Feller
7c31d1a76b
Minor refactoring autolink create help and logic
...
- simplified and wrapped `gh repo autolink create` and `gh repo autolink` long help usage docs
- simplified success message, brought into alignment with other commands
2025-01-27 17:47:55 -05:00
Michael Hoffman
965782a444
Merge branch 'trunk' into create-autolinks
2025-01-25 16:03:19 -05:00
Tyler McGoffin
4382bdf072
Fix pr create tests
...
Due to the refactor of BranchConfig, the tests for `pr create` no longer
require a handful of stubbed git commands.
Additionally, I noticed some overlap between `pr create`'s existing logic
with the new finder code. I suspect that the finder's new ParsePRRefs
helper could be leveraged here as well, which would allow us to respect
non-centralized workflows pr create in the same way we are respecting them
in `gh pr view` and `gh pr status`
2025-01-24 14:01:44 -08:00
Cody Soyland
6a629ed871
Fix breaking changes from sigstore-go v0.7.0 upgrade
...
Signed-off-by: Cody Soyland <codysoyland@github.com>
2025-01-24 16:35:31 -05:00
Meredith Lancaster
728aa3d83f
set new options in enforcement criteria
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-24 13:20:01 -07:00
Meredith Lancaster
11dc8d48f5
reorder fields
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-24 13:19:47 -07:00
Tyler McGoffin
d684834ad9
Refactor pr status to use the ParsePRRefs helper on the Finder
...
There was a lot of copy-pasta code between the finder and pr status. After
some investigation it was clear that the prSelectorForCurrentBranch code
was really just a duplicate of the finder's code without actually making
the API call for the PR. Since the ParsePRRefs helper had already
extracted much of the logic for determining a PR's head ref branch, I was
able to reuse it in gh pr status with a small refactor.
2025-01-24 11:51:49 -08:00
