Commit graph

128 commits

Author SHA1 Message Date
Shubhankar Kanchan Gupta
bb6851c88b
Add "open" qualifier when listing open issues/PRs (#1457) 2020-07-31 18:22:08 +02:00
vilmibm
bffcbce716 restore nontty + web but suppress informational prints 2020-07-20 13:04:17 -05:00
vilmibm
b7765591b7 remove package level terminal check state 2020-07-17 15:02:05 -05:00
Mislav Marohnić
0528145159 Allow filter values with spaces in issue/pr list --web 2020-07-16 15:21:50 +02:00
Mislav Marohnić
8626befd3f Merge remote-tracking branch 'origin' into webInList 2020-07-16 14:51:34 +02:00
Mislav Marohnić
c8cf54c10c
Merge pull request #1258 from cli/ghe-remotes
Parse and respect non-github.com git remotes
2020-07-15 13:07:30 +02:00
vilmibm
754dcb744c catch up to trunk 2020-07-14 12:36:54 -05:00
vilmibm
97107661fe review feedback 2020-07-14 12:30:53 -05:00
vilmibm
36ade42ba3 scriptability improvements: issue commands
This commit is part of work to make gh more scriptable. It includes both
some general purpose helpers towards this goal as well as improvements
to the issue commands. Other commands will follow.

- Adds `utils/terminal.go` for finding out about gh's execution environment
- introduces `stubTerminal` for either faking being attached to a tty or not during tests
- updates issue commands to behave better when not attached to a tty:
  - issue list doesn't print fuzzy dates
  - issue list doesn't print header
  - issue list prints state explicitly
  - issue create no longer hangs
  - issue create fails with clear error unless both -t and -b are specified
  - issue view prints raw issue body
  - issue view prints metadata in a consistent, linewise format
2020-07-14 12:30:53 -05:00
AliabbasMerchant
4304b9e3eb filterOptions struct for pr & issue list 2020-07-14 10:26:32 +05:30
AliabbasMerchant
73552ae75c Merge 'trunk' in webInList 2020-07-14 08:53:39 +05:30
Mislav Marohnić
87a9dc8d4b Merge remote-tracking branch 'origin' into ghe-remotes 2020-07-13 13:39:14 +02:00
Mislav Marohnić
13b9c98b2b Match named queries in test stubs 2020-07-10 20:04:54 +02:00
Sibi
2491e98c41 Title of the PR will be shown while closing, merging and re-opening & test cases updated 2020-07-08 12:22:38 +05:30
Mislav Marohnić
a68cefadd9 Merge remote-tracking branch 'origin' into ghe-remotes 2020-07-02 20:37:33 +02:00
Mislav Marohnić
446a4111f7 Respect hostnames when resolving git remotes and URL args to repos 2020-07-02 20:36:10 +02:00
Mislav Marohnić
ed781103c7
Merge pull request #644 from eddumelendez/add_filters_issues
Add filters issues
2020-07-02 12:24:30 +02:00
Mislav Marohnić
1ca3d171e6 Tweak HTTP 422 handling when deleting branches 2020-06-30 19:21:39 +02:00
AliabbasMerchant
77a610f071 Tests for --web flag in issue and pr list 2020-06-28 23:17:57 +05:30
Eddú Meléndez
cffd56f717 Rename to mention 2020-06-15 16:08:10 -05:00
Eddú Meléndez
8a96299735 Fix lint 2020-06-13 21:07:12 -05:00
Eddú Meléndez
9aebb66a3c Add milestone filter 2020-06-13 20:53:41 -05:00
Eddú Meléndez
2943703d4a Add mentioned flag 2020-06-13 20:53:03 -05:00
Ben Wells
a89f45b1ed Validate pr and issue limit flag 2020-06-10 21:42:38 +01:00
Nate Smith
bc70c52676
Merge pull request #992 from AliabbasMerchant/issue-query-params
Query Params in Web mode of Issue/PR creation
2020-06-04 14:32:38 -05:00
AliabbasMerchant
f95b8916f3 Use url package for setting query params 2020-05-26 07:45:14 +05:30
AliabbasMerchant
5fc722fbb8 Query Params in Web mode of Issue/PR creation 2020-05-23 14:40:49 +05:30
Mislav Marohnić
767521c055 Stop providing AuthLogin from context
The login name of the authenticated user will be readily available only
if authentication info comes from the config file. With other upcoming
authentication modes (for example, the GITHUB_TOKEN environment
variable), the token is the only piece of information we got, so we
would need to additionally query for the login name.

Since `issue status` and `pr status` are the only commands that need the
name of the authenticated user right now, have those commands explicitly
query for the login name. This results in an additional API query, but
simplifies Context implementation and future authentication approaches.
2020-05-20 17:09:13 +02:00
Mislav Marohnić
b75c4a812d Guard against leaked parameters in issue/pr create tests 2020-05-12 16:54:54 +02:00
Mislav Marohnić
3abc2be0f7 Switch issue create to optimized resolver and update tests 2020-05-12 16:17:06 +02:00
Mislav Marohnić
c682d90466 Add tests for issue/pr create with metadata 2020-05-08 20:32:46 +02:00
Corey Johnson
4ef73a723d Update all calls to RunCommand 2020-05-05 09:20:01 -07:00
Corey Johnson
a9f34069f1 Add "issues disabled" test 2020-04-29 13:58:47 -07:00
Corey Johnson
7df1b992db Add "already open" test 2020-04-29 13:57:53 -07:00
Corey Johnson
49e5ef757f Fix test 2020-04-29 12:29:32 -07:00
Corey Johnson
b0eba939e6 Add test 2020-04-29 12:21:44 -07:00
Corey Johnson
28b35aa333
Merge pull request #843 from cli/when-god-closes-an-issue-he-opens-a-pull-request
Add `gh issue close <urlOrNumber>`
2020-04-29 11:54:48 -07:00
Corey Johnson
c78c30b32f Add already closed test 2020-04-29 11:33:16 -07:00
Corey Johnson
83ec49582b get rid of fixture 2020-04-29 11:31:40 -07:00
Corey Johnson
1b37681a6f Fix test 2020-04-28 12:57:24 -07:00
Corey Johnson
69b58b95a3 Fix linter errors 2020-04-28 12:25:25 -07:00
Corey Johnson
99940fa062 Update test 2020-04-28 12:15:37 -07:00
Corey Johnson
bf94a31619 not on issues disabled
Co-Authored-By: Nate Smith <vilmibm@neongrid.space>
2020-04-28 10:05:56 -07:00
Corey Johnson
7ba6615919 Close test now works
Co-Authored-By: Nate Smith <vilmibm@neongrid.space>
2020-04-28 09:51:28 -07:00
Corey Johnson
e5fc3e9bbd Update issue_test.go
Add test for closing issue

Co-Authored-By: Nate Smith <vilmibm@neongrid.space>
2020-04-28 09:11:19 -07:00
rista404
a2a6036c65
Add tests 2020-04-25 23:12:51 +02:00
vilmibm
a325db3051 new config infrastructure
- adds config get and config set commands
- supports arbitrary k/v strings set at top and host level
- supports writing an updated config, preserving comments
- supports mostly lazy evaluation of yaml
2020-04-17 15:17:44 -05:00
Toshiya Doi
9169c8d0eb Update unit tests for issue metadata 2020-04-08 14:48:08 +09:00
Toshiya Doi
5a17962188 Add a new line to test a dynamic string of metadata 2020-04-04 12:53:22 +09:00
Toshiya Doi
8c697a0d99 Test issue metadata in CLI preview 2020-04-04 11:28:52 +09:00