Commit graph

7378 commits

Author SHA1 Message Date
Meredith Lancaster
02158e896b
Fix attestation cmd offline unit test failure (#8933)
* pass policy to Verify method

Signed-off-by: Meredith Lancaster <malancas@github.com>

* remove policy argument from SigstoreVerifier constructor

Signed-off-by: Meredith Lancaster <malancas@github.com>

* add SigstoreVerifier interface and introduce mock SigstoreVerifier struct for unit testing

Signed-off-by: Meredith Lancaster <malancas@github.com>

* gofmt

Signed-off-by: Meredith Lancaster <malancas@github.com>

* rename LiveSigstoreVerifier constructor

Signed-off-by: Meredith Lancaster <malancas@github.com>

* pr feedback, add todos for tests that need to be reimplemented

Signed-off-by: Meredith Lancaster <malancas@github.com>

* remove unused import

Signed-off-by: Meredith Lancaster <malancas@github.com>

* add more missing TODO statements

Signed-off-by: Meredith Lancaster <malancas@github.com>

* update skipped test

Signed-off-by: Meredith Lancaster <malancas@github.com>

---------

Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-04-11 18:09:10 -06:00
Andy Feller
88a7e529ab
Merge pull request #8762 from Ebonsignori/8761/allow-multiple-items-in-nested-array
allow multiple items in nested array
2024-04-09 14:23:19 -04:00
Andy Feller
6a55528882
Merge pull request #8899 from babakks/8679-include-num-selected-repos
Include `numSelectedRepos` in JSON output of `gh secret list`
2024-04-09 13:18:50 -04:00
William Martin
a76230454a
Merge pull request #8945 from cli/wm/you-didnt-see-nothin
Close zip file in run view tests
2024-04-08 17:02:09 +02:00
William Martin
61584b83cb Close zip file in run view tests 2024-04-08 16:50:43 +02:00
William Martin
3ba976a3a4
Merge pull request #8944 from cli/wm/ensure-run-log-cache-creates-cache-dir
Ensure run log cache creates cache dir if it doesn't exist
2024-04-08 16:02:21 +02:00
William Martin
bbeccd69ad Ensure run log cache creates cache dir if it doesn't exist 2024-04-08 15:51:29 +02:00
Evan Bonsignori
b43a287e78
Merge pull request #1 from cli/8761/allow-multiple-items-in-nested-array
Add tests for non-happy field paths
2024-04-05 14:48:11 -07:00
Andy Feller
b722dd4151 Add tests for non-happy field paths
This commit as a suite of test around different combination of `gh api` field scenarios that result in errors.

In the course of creating this test, there were 2 scenarios that did not raise an error as expected involving overriding an existing map value.
2024-04-05 17:21:28 -04:00
William Martin
3be7a02fec
Merge pull request #8932 from cli/wm/fix-api-cache-test
Fix api cache test
2024-04-05 17:10:20 +02:00
William Martin
9738d68bba Fix api cache test 2024-04-05 16:47:29 +02:00
William Martin
3aa3d61108
Merge pull request #8929 from cli/wm/parse-url-no-nakaed-return
Remove naked returns from git ParseURL
2024-04-05 16:33:09 +02:00
William Martin
b0b147e60c Use testify in git url tests 2024-04-05 16:07:04 +02:00
William Martin
b6239238c8
Merge pull request #8931 from cli/wm/run-log-cache-stronger-abstraction
Create stronger run log cache abstraction
2024-04-05 16:00:28 +02:00
William Martin
c2aee1e402 Ensure cache dir is always available in RunLogCache 2024-04-05 15:39:33 +02:00
William Martin
103586a94c Remove RunLogCache interface 2024-04-05 15:33:49 +02:00
William Martin
a3ffc1ca33 Use real Run Log Cache in run view tests 2024-04-05 15:18:18 +02:00
William Martin
e644dc50d6 Capture error on Run Log Cache Exists 2024-04-05 15:16:12 +02:00
Andy Feller
b0a3975948
Merge pull request #8882 from zdrve/zdrve/job-name-prefix
Anchor the log filename to the start
2024-04-05 09:11:50 -04:00
William Martin
a89d50fc63 Rework Run Log Cache so that cache dir is injected 2024-04-05 14:59:24 +02:00
William Martin
f808dcee62 Expose CacheDir on Config 2024-04-05 14:58:12 +02:00
Andy Feller
0a2ede0279
Merge pull request #8837 from t4kamura/fix-cannot-lock-pr-url
Fixed `gh pr lock/unlock` not working when URL is passed
2024-04-05 08:29:35 -04:00
Andy Feller
1540a37fee
Merge branch 'trunk' into fix-cannot-lock-pr-url 2024-04-05 08:13:44 -04:00
William Martin
1b57b0f917 Minorly refactor scheme normalization in git ParseURL 2024-04-05 12:29:27 +02:00
William Martin
2c2a09c73e Test for parsing error in git ParseURL 2024-04-05 12:25:24 +02:00
William Martin
27f3d62d02 Remove naked returns from git ParseURL 2024-04-05 12:23:47 +02:00
Babak K. Shandiz
47efef6d70
Fix parsing IPv6 remote URLs (#8893)
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-04-05 11:54:55 +02:00
Meredith Lancaster
2c53d7c9a8
Add codeowners entry for the GitHub TUF root included in the attestation command set (#8919)
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-04-05 09:41:34 +02:00
Babak K. Shandiz
d034a69164
Add comment to explain showSelectedReposInfo assignment
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-04-04 20:09:28 +01:00
Babak K. Shandiz
4aa7e75cd1
Rename const to avoid CodeQL error
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-04-04 20:06:45 +01:00
Babak K. Shandiz
d8ff343d5c
Add tests to verify numSelectedRepos is populated when necessary
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-04-04 19:49:34 +01:00
Babak K. Shandiz
e42b8b7e6b
Populate numSelectedRepos only if needed
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-04-04 19:48:44 +01:00
William Martin
6cb85d54cc
Merge pull request #8925 from cli/dependabot/go_modules/google.golang.org/grpc-1.61.2
build(deps): bump google.golang.org/grpc from 1.61.1 to 1.61.2
2024-04-04 16:58:09 +02:00
dependabot[bot]
dd0a827ce5
build(deps): bump google.golang.org/grpc from 1.61.1 to 1.61.2
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.61.1 to 1.61.2.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](https://github.com/grpc/grpc-go/compare/v1.61.1...v1.61.2)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-04-04 14:38:42 +00:00
William Martin
ca39101b3e
Merge pull request #8906 from babakks/8675-fix-repo-rename-panic
Fix panic when running `gh repo rename`
2024-04-04 14:59:55 +02:00
Babak K. Shandiz
642b2c57c1
Add tests for FindByRepo
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-04-04 00:19:15 +01:00
William Martin
9744489510
Merge pull request #8920 from cli/wm/bump-glam-glam 2024-04-03 18:45:08 +02:00
William Martin
32882db3e2 Bump go-gh to v2.8.0 and go mod tidy 2024-04-03 17:12:06 +02:00
William Martin
18d37e2940
Merge pull request #8923 from cli/dependabot/go_modules/github.com/sigstore/protobuf-specs-0.3.1
build(deps): bump github.com/sigstore/protobuf-specs from 0.3.0 to 0.3.1
2024-04-03 16:35:06 +02:00
dependabot[bot]
eb24a5b241
build(deps): bump github.com/sigstore/protobuf-specs from 0.3.0 to 0.3.1
Bumps [github.com/sigstore/protobuf-specs](https://github.com/sigstore/protobuf-specs) from 0.3.0 to 0.3.1.
- [Release notes](https://github.com/sigstore/protobuf-specs/releases)
- [Changelog](https://github.com/sigstore/protobuf-specs/blob/main/CHANGELOG.md)
- [Commits](https://github.com/sigstore/protobuf-specs/compare/v0.3.0...v0.3.1)

---
updated-dependencies:
- dependency-name: github.com/sigstore/protobuf-specs
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-04-03 14:20:03 +00:00
Evan Bonsignori
fce871f3f4
Apply suggestions from code review
Co-authored-by: Andy Feller <andyfeller@github.com>
2024-04-02 17:39:20 -07:00
Babak K. Shandiz
72fcd8c87d
Improve error message returned by FindByRepo
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-04-02 21:46:28 +01:00
William Martin
83f200d91f Bump glamour to v0.7.0 and go mod tidy 2024-04-02 20:08:19 +02:00
William Martin
28c5e1b503
Merge pull request #8914 from cli/dependabot/go_modules/github.com/google/go-containerregistry-0.19.1
build(deps): bump github.com/google/go-containerregistry from 0.19.0 to 0.19.1
2024-04-02 17:43:10 +02:00
dependabot[bot]
47f190f2b5
build(deps): bump github.com/google/go-containerregistry
Bumps [github.com/google/go-containerregistry](https://github.com/google/go-containerregistry) from 0.19.0 to 0.19.1.
- [Release notes](https://github.com/google/go-containerregistry/releases)
- [Changelog](https://github.com/google/go-containerregistry/blob/main/.goreleaser.yml)
- [Commits](https://github.com/google/go-containerregistry/compare/v0.19.0...v0.19.1)

---
updated-dependencies:
- dependency-name: github.com/google/go-containerregistry
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-04-02 15:30:53 +00:00
William Martin
5150eb0001
Merge pull request #8913 from cli/dependabot/go_modules/github.com/gorilla/websocket-1.5.1
build(deps): bump github.com/gorilla/websocket from 1.5.0 to 1.5.1
2024-04-02 17:29:55 +02:00
William Martin
7b4d74b66d
Merge pull request #8912 from cli/dependabot/go_modules/google.golang.org/grpc-1.61.1
build(deps): bump google.golang.org/grpc from 1.61.0 to 1.61.1
2024-04-02 17:22:03 +02:00
William Martin
96a75139f8
Merge pull request #8888 from satoqz/trunk
Fix segfault in error handling of `gh repo rename`
2024-04-02 16:28:09 +02:00
dependabot[bot]
f66b2fc6eb
build(deps): bump github.com/gorilla/websocket from 1.5.0 to 1.5.1
Bumps [github.com/gorilla/websocket](https://github.com/gorilla/websocket) from 1.5.0 to 1.5.1.
- [Release notes](https://github.com/gorilla/websocket/releases)
- [Commits](https://github.com/gorilla/websocket/compare/v1.5.0...v1.5.1)

---
updated-dependencies:
- dependency-name: github.com/gorilla/websocket
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-04-02 14:11:31 +00:00
dependabot[bot]
228c31f205
build(deps): bump google.golang.org/grpc from 1.61.0 to 1.61.1
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.61.0 to 1.61.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](https://github.com/grpc/grpc-go/compare/v1.61.0...v1.61.1)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-04-02 14:11:27 +00:00