Caleb Brose
045bb54157
Apply suggestions from code review
...
Co-authored-by: Jose Garcia <josebalius@github.com>
2022-09-20 13:22:38 -05:00
Caleb Brose
049a3676f4
Use filepath instead of path
2022-09-20 15:59:38 +00:00
Caleb Brose
83c67d3b57
Merge remote-tracking branch 'origin/trunk' into cmbrose/no-ssh-api-call
2022-09-20 15:22:27 +00:00
Caleb Brose
3b52df6f99
Don't add private key for -i
2022-09-20 15:21:59 +00:00
Caleb Brose
dba1259d32
Update tests
2022-09-20 01:02:06 +00:00
Mislav Marohnić
6267bd368a
Merge pull request #6275 from cli/ghe-gist-clone
...
Fix gist clone URL for GHE hosts
2022-09-19 18:50:50 +02:00
Mislav Marohnić
acfa85cd00
Merge pull request #6301 from cli/liquid-docs
...
Escape liquid tags in site docs
2022-09-19 18:49:16 +02:00
Nate Smith
24ff8fac40
Merge pull request #6253 from cli/auth-prompts
...
use Prompter in auth commands
2022-09-19 11:02:13 -05:00
Mislav Marohnić
6e9974c2ef
Escape liquid tags in site docs
...
It is good practice to wrap all dynamic content in `{% raw %}..{% endraw %}`
Liquid tags so that no syntax within can mistakenly get interpreted as
Liquid tags. Fixes rendering of `gh auth login` help page.
2022-09-19 15:50:51 +02:00
Mislav Marohnić
b82884af2d
Merge pull request #6279 from 8Gitbrix/revert-6223-revert-6171-add-org-secrets-api
...
Revert "Revert "Added functionality for org-level codespaces secrets""
2022-09-19 15:24:35 +02:00
Sam Coe
de83df12d2
Stub out time.Now for search tests ( #6299 )
2022-09-19 14:54:18 +04:00
Caleb Brose
0c00ca911e
Clean up API interface
2022-09-16 22:25:11 +00:00
Caleb Brose
939c7c71cd
Remove API call for ssh keys
2022-09-16 22:22:13 +00:00
Ashwin Jeyaseelan
b47ed57694
Revert "Revert "Added functionality for org-level codespaces secrets ( #6171 )" ( #6223 )"
...
This reverts commit eaabd35b76 .
2022-09-15 15:53:28 -07:00
Mislav Marohnić
27294c197f
gist clone: fix clone URL for GHE gists
...
Use `HOSTNAME/gist/ID` instead of `gist.HOSTNAME/ID` as clone URL for
Enterprise since it's not guaranteed that the `gist.` subdomain is
configured for a GHE instance.
2022-09-15 18:25:16 +02:00
Mislav Marohnić
0ecd424901
Merge pull request #6262 from cli/fix-subcommand-stdout
...
Ensure that subprocesses connect to the original `os.Stdout`
2022-09-15 11:07:22 +02:00
Mislav Marohnić
cfb7e66d2b
Merge pull request #6260 from cli/fix-branch-delete
...
Fix deleting remote branches with `#` in their name
2022-09-15 11:06:04 +02:00
Nate Smith
6ab61a085b
Merge pull request #6251 from cli/fix-prompter-default
...
Do not set default for survey prompt if empty string passed
2022-09-14 12:17:04 -05:00
Mislav Marohnić
984cc9f441
Fix tests
2022-09-14 17:05:43 +02:00
Mislav Marohnić
58ef50ae1f
Ensure that subprocesses connect to the original os.Stdout
...
On non-Windows platforms, this avoids wrapping `IOStreams.Out` in a
`fdWriter` and thus causing subprocesses to lose connection to the
terminal that gh is connected to.
2022-09-14 16:47:42 +02:00
Mislav Marohnić
1e295607d7
Fix deleting remote branches with # in their name
2022-09-14 16:19:33 +02:00
Sam Coe
a30de8d72a
Output paid message for codespace create to stderr not stdout ( #6258 )
2022-09-14 11:33:55 +00:00
Sam Coe
e14d14cef2
Add support for issue state reason ( #6245 )
2022-09-14 12:39:15 +04:00
Sam Coe
e7102f9d84
Migrate to go-gh text package ( #6236 )
2022-09-14 09:23:55 +04:00
vilmibm
8f3032af36
use Prompter in auth commands
2022-09-13 13:22:50 -07:00
vilmibm
c2f4bbac6b
Do not set default for survey prompt if empty string passed
2022-09-12 17:43:57 -07:00
dependabot[bot]
e16bf033ed
Bump github.com/AlecAivazis/survey/v2 from 2.3.5 to 2.3.6 ( #6243 )
...
Bumps [github.com/AlecAivazis/survey/v2](https://github.com/AlecAivazis/survey ) from 2.3.5 to 2.3.6.
- [Release notes](https://github.com/AlecAivazis/survey/releases )
- [Commits](https://github.com/AlecAivazis/survey/compare/v2.3.5...v2.3.6 )
---
updated-dependencies:
- dependency-name: github.com/AlecAivazis/survey/v2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-09-12 14:38:28 +00:00
Sam Coe
4bd5c2db9d
Rely on go-gh browser resolution ( #6237 )
2022-09-12 13:23:36 +04:00
ffalor
e5b37ee661
add --required flag to gh pr checks ( #5648 )
2022-09-10 08:00:29 +00:00
dependabot[bot]
537dcb2739
Bump github.com/google/go-cmp from 0.5.8 to 0.5.9 ( #6219 )
...
Bumps [github.com/google/go-cmp](https://github.com/google/go-cmp ) from 0.5.8 to 0.5.9.
- [Release notes](https://github.com/google/go-cmp/releases )
- [Commits](https://github.com/google/go-cmp/compare/v0.5.8...v0.5.9 )
---
updated-dependencies:
- dependency-name: github.com/google/go-cmp
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-09-09 08:29:36 +04:00
Ashwin Jeyaseelan
eaabd35b76
Revert "Added functionality for org-level codespaces secrets ( #6171 )" ( #6223 )
...
This reverts commit bde64b3191 .
2022-09-09 08:18:03 +04:00
Ashwin Jeyaseelan
bde64b3191
Added functionality for org-level codespaces secrets ( #6171 )
2022-09-08 09:40:53 +04:00
Mislav Marohnić
9e71c65b13
Merge pull request #6209 from cli/new-gpg-key
...
Restore Debian installation instructions
2022-09-06 19:46:39 +02:00
Mislav Marohnić
e2e8d697db
Fix closing IOStreams.Out after finishing writing to the pager ( #6210 )
2022-09-06 19:22:31 +02:00
Mislav Marohnić
a6636994bf
Disable flakey ports update visibility tests ( #6203 )
2022-09-06 15:31:36 +00:00
Mislav Marohnić
436d9ef859
Fix "missing method Fd" crash on Windows ( #6200 )
...
This ensures that `IOStreams.Out` always keeps the original `Fd()` value even if it's wrapped as a Colorable stream for Windows in cases when enabling virtual terminal processing has failed.
2022-09-06 17:29:06 +02:00
Mislav Marohnić
23933fd527
Restore Debian installation instructions
2022-09-06 16:43:03 +02:00
Sam Coe
28c6c8a546
Remove pubkey as it is no longer necessary ( #6208 )
2022-09-06 14:31:24 +00:00
Sam Coe
9599952d5c
Update distributions gpg key ( #6207 )
2022-09-06 18:15:02 +04:00
Sam Coe
2b0b4b8f00
Update rpm script ( #6206 )
2022-09-06 17:57:58 +04:00
Sam Coe
0968ac6225
Use secret public key instead of file ( #6204 )
2022-09-06 17:26:09 +04:00
Sam Coe
39df244d2d
Dont hardcode keygrip ( #6202 )
2022-09-06 12:59:51 +00:00
Bindu
9fddb07eab
Add --notes-start-tag flag for generating release notes in gh release create ( #6107 )
2022-09-06 16:06:18 +04:00
Anthony Fok
c219579c63
Bump github.com/spf13/cobra from v1.4.0 to v1.5.0 ( #6196 )
2022-09-06 09:43:40 +04:00
3x!1
b53c2c37e9
Link to the issue for more information. ( #6189 )
2022-09-04 16:10:49 +00:00
Nate Smith
c058c6ddff
Merge pull request #6180 from cli/key-workaround
...
mention broken deb installation
2022-09-02 18:24:01 -06:00
vilmibm
f2fa43a508
mention broken deb installation
2022-09-02 18:15:39 -06:00
Edward Hartwell Goose
5f52a1d964
Improve setup instructions ( #6156 )
2022-09-02 09:43:41 +00:00
Takeshi Sato
e2f344fef4
Add --clobber / --skip-existing to release download ( #6053 )
2022-09-01 12:28:25 +00:00
Mark Woods
e876b22963
Change markdown wrap limit match terminal width ( #6016 )
2022-09-01 07:36:25 +00:00