Commit graph

3976 commits

Author SHA1 Message Date
Mislav Marohnić
0d999ddaa1 Rework local extensions for Windows
Replace the implementation that relied on symlinks with the one that
create regular files that act like symlinks: they contain a reference to
the local directory where to find the extension.
2021-07-28 22:47:54 +02:00
Mislav Marohnić
4b499be96b
Merge pull request #3942 from dscho/complete--repo-flag
Allow auto-completing the `--repo` values
2021-07-28 17:27:56 +02:00
Mislav Marohnić
d6b70beeaa List repos from non-default hostnames in completions for -R 2021-07-28 17:18:56 +02:00
Johannes Schindelin
b43f78bc19 completions: auto-complete --repo values
Looking at the locally-registered remotes, we have a pretty good idea
what `--repo` values are available. Let's complete them.

Helped by Nate Smith and Mislav Marohnić.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
2021-07-28 15:36:30 +02:00
Sam
ef9b781283
Merge pull request #4047 from tniessen/opensuse-typo
Fix typo in openSUSE installation instructions
2021-07-27 08:18:37 -07:00
Sam
92ed42c54a
Merge pull request #4029 from cli/extensions-upgrade-force
Add --force flag for extensions upgrade
2021-07-27 08:07:14 -07:00
Mislav Marohnić
f3a7d0076e
Merge pull request #4028 from cli/bump-cobra
Upgrade Cobra for improved shell completion support
2021-07-27 16:34:20 +02:00
Mislav Marohnić
fdad37e248
Merge pull request #4019 from cli/enterprise-env
Fix error message when using GH_ENTERPRISE_TOKEN but host is ambiguous
2021-07-27 15:29:14 +02:00
Tobias Nießen
515902ade3
Fix typo in openSUSE installation instructions 2021-07-27 02:13:35 +02:00
Mislav Marohnić
82c6fb7d1a Add a note about the dummy GHE hostname 2021-07-26 18:59:53 +02:00
Sam Coe
340a1fdc93
Add --force flag for extensions upgrade 2021-07-21 11:06:22 -07:00
Mislav Marohnić
2801206663 Switch to Cobra's bash completion V2 2021-07-21 16:32:39 +02:00
Mislav Marohnić
6ed2e8f7f8 Add completion support to repo create --gitignore and --license 2021-07-21 16:12:38 +02:00
Mislav Marohnić
4d7625c8a0 Allow shell-completing multiple --json fields separated by commas 2021-07-21 16:12:38 +02:00
Mislav Marohnić
db8204dc56 Allow space to be added after completing issue/pr list --state values
The "nospace" directive instructs the shell completion logic to avoid
adding a space after completing the word. However, this feature was
broken in an older Cobra, and users still saw a space character added.
In most case we want the space because we anticipate that the user might
want to add extra arguments to the command.
2021-07-21 16:12:38 +02:00
Mislav Marohnić
3e8f075a8e Bump Cobra for improved completion support 2021-07-21 15:01:31 +02:00
Sam
fa354a922b
Merge pull request #3905 from cli/extensions-list-notice
Add update checking to extensions list
2021-07-20 13:21:30 -07:00
Sam Coe
e70bdbf7a9
Add update checking to extensions list 2021-07-20 13:13:20 -07:00
Mislav Marohnić
3ff94ae76b
Merge pull request #4025 from cli/revert-3926-update-goreleaser-20210630
Revert "Update GoReleaser"
2021-07-20 22:02:49 +02:00
Mislav Marohnić
6c8abe9df6
Merge branch 'trunk' into revert-3926-update-goreleaser-20210630 2021-07-20 21:43:51 +02:00
Mislav Marohnić
85d0447a6e
Revert "Update GoReleaser to v0.172.1" 2021-07-20 21:39:50 +02:00
Mislav Marohnić
5bbce4a5b9 Fix goreleaser config for linux packages 2021-07-20 20:15:48 +02:00
Mislav Marohnić
ccd4f0fa9a
Merge pull request #3706 from cristiand391/improve-automerge
PR auto-merge improvements
2021-07-20 19:55:43 +02:00
Mislav Marohnić
a83c2924c5 Never prompt to delete branch if --auto was given 2021-07-20 19:49:19 +02:00
Mislav Marohnić
6e026412df Add "UNSTABLE" to immediately mergeable statuses
This status describes a state where the head branch is mergeable and
technically not blocked per base branch requirements, but it does have
non-passing checks.
2021-07-20 19:42:53 +02:00
Mislav Marohnić
6f2dfd7eea Adjust conditions for switching between regular and auto merge
Conditions prohibiting a regular merge: BLOCKED, BEHIND, DIRTY.

Conditions triggering a regular merge even if `--auto` was set: CLEAN,
HAS_HOOKS.

Note that UNKNOWN status does not trigger either of the conditions.
2021-07-20 19:34:32 +02:00
Mislav Marohnić
0ab9c70c3f Merge remote-tracking branch 'origin' into improve-automerge 2021-07-20 18:45:47 +02:00
Mislav Marohnić
1ca49a8bcd
Merge pull request #3980 from cli/bump-survey
Bump Survey library for cursor improvements
2021-07-20 18:34:14 +02:00
Mislav Marohnić
2624ed9d8c Merge remote-tracking branch 'origin' into bump-survey 2021-07-20 18:28:58 +02:00
Mislav Marohnić
4a7b130511
Merge pull request #3981 from cli/bump-gojq
Bump gojq to latest version
2021-07-20 18:27:07 +02:00
Mislav Marohnić
25ef11198f
Merge pull request #4020 from cli/xdg-docs
Clean up GH_CONFIG_DIR docs
2021-07-20 18:02:23 +02:00
Mislav Marohnić
1121ec6669
Merge pull request #4013 from chemotaxis/docs/alias-quotes-windows
Add documentation about double quoting on Windows
2021-07-20 18:01:36 +02:00
Mislav Marohnić
75c7fc1536
Merge pull request #3972 from g14a/fix/private-repo-create
fix private repo creation in case of ignore templates & repo description bugs in case of template repos
2021-07-20 16:39:36 +02:00
Mislav Marohnić
1de756f6f3 💅 address review comments 2021-07-20 16:34:11 +02:00
Mislav Marohnić
c598a1edc2 Fix detecting cases when cfg.Hosts() is empty 2021-07-20 15:50:58 +02:00
Mislav Marohnić
efa4d43cf4 Simplify alias set documentation 2021-07-20 15:32:51 +02:00
Mislav Marohnić
9033258f5f Clean up GH_CONFIG_DIR docs
This removes the false equivalence between GH_CONFIG_DIR and
XDG_CONFIG_HOME. These settings do not have the same effect and should
not be used for the same purposes.

Also remove the documentation about what `XDG_*` settings do. We simply
conform to the XDG Base Directory Specification, but will not document
it. It's likely that users of these environment variables already know
what they do.
2021-07-20 14:24:11 +02:00
Mislav Marohnić
aec0f10041 Fix error message when using GH_ENTERPRISE_TOKEN but host is ambiguous
Before:

    $ GH_ENTERPRISE_TOKEN="..." gh pr create
    could not find hosts config: not found

Now:

    $ GH_ENTERPRISE_TOKEN="..." gh pr create
    set the GH_HOST environment variable to specify which GitHub host to use

Also amends `gh help environment` documentation to suggest the use of
GH_HOST when scripting operations with GitHub Enterprise repositories.
2021-07-20 14:11:07 +02:00
Mislav Marohnić
25b6eecc8d
Merge pull request #4017 from despreston/des/avoid-migrate
Skip auto migrate of config when GH_CONFIG_DIR
2021-07-20 13:33:16 +02:00
Des Preston
1c9b4bf99d Skip auto migrate of config when GH_CONFIG_DIR
If GH_CONFIG_DIR is set, don't auto migrate the config file. This fixes
the situation where the path given via GH_CONFIG_DIR does not exist and
the cli attempts to migrate an existing config to that location.

Fixes #3837
2021-07-19 16:33:51 -04:00
chemotaxis
1e4e536bcb Revise Windows note 2021-07-19 15:50:27 -04:00
chemotaxis
2c52819c1a Remove note about using Git for Windows
As discussed in pull request #4013.
2021-07-19 15:50:12 -04:00
Sam
97a52f74cd
Merge pull request #3933 from cli/extensions-upgrade
Skip trying to upgrade local extensions
2021-07-19 10:55:16 -07:00
Sam Coe
b71735d0d7
Address PR comments 2021-07-19 10:48:09 -07:00
chemotaxis
23ffca45f7 Unify use of single quotes to mark shell arguments and variables
The first paragraph uses single quotes when referring to shell arguments
and variables, but the rest of the docs use double quotes.  This commit
switches to using single quotes throughout the docs.

I prefer to use single quotes inside string literals because Go uses
double quotes to define a string literal.
2021-07-19 00:46:06 -04:00
chemotaxis
5314e7c398 Add note about double quotes on non-Unix-like shells
On non-Unix-like shells like Windows Command Prompt, single quotes are
handled differently.  You need to define aliases using double quotes
instead of single quotes.

I added an inline example to illustrate the quotes.  The example is
formatted as inline code blocks in Markdown.  Unfortunately, because Go
uses backticks for raw string literals, I needed to do some rather ugly
string concatenation in order to get the backticks included in the doc
string.

This also rearranges the notes so that the platform specific notes are
at the end of the documentation.
2021-07-19 00:36:07 -04:00
Mislav Marohnić
496b70ac0e
Merge pull request #3934 from cli/extensions-remove-notice
Add confirmation to extensions remove
2021-07-16 15:18:38 +02:00
Mislav Marohnić
882f6d33cb Merge remote-tracking branch 'origin' into extensions-remove-notice 2021-07-16 15:12:56 +02:00
Mislav Marohnić
d68df4a9d8 Do not output error messages for nontty 2021-07-16 15:10:36 +02:00
Mislav Marohnić
30beb67cb3
Merge pull request #3941 from cli/extension-install-check
Extension install check
2021-07-16 14:58:52 +02:00