STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
1482 commits 87 branches 0 tags 160 MiB
Commit graph

1482 commits

This branch
This branch
All branches
Author SHA1 Message Date
Mislav Marohnić
108f7bd66c Dirty workaround to display helpful error message on mistyped subcommands 
When executing `gh pr re` (note the incomplete command name), Cobra
would just display the help text for `gh pr` on standard output, exit
with status 0, and not print any message that you have mistyped the
"re" subcommand. Each part of this behavior is wrong.

This workaround makes sure that the helpful error message is printed on
stderr:

    $ gh pr re
    unknown command "re" for "gh pr"

    Did you mean this?
            reopen
            ready
            review

However, the exit status is still 0, whereas it should be non-zero.
Since `HelpFunc` does not return an error argument, we cannot trigger an
error status from this workaround.
 2020-05-22 19:02:34 +02:00
Mislav Marohnić
a33c00d389 Merge remote-tracking branch 'origin/master' into cobra1.0 2020-05-22 18:21:35 +02:00
Mislav Marohnić
331deb852b
Merge pull request #975 from cli/pr-reviewers-crash 
Avoid crash in `pr view` with reviewers
 2020-05-22 15:46:37 +02:00
Nate Smith
4e73c83fd1
Merge pull request #978 from cli/fix-linter 
Fix lint errors
 2020-05-20 13:59:07 -05:00
Corey Johnson
e5b78d3342 Fix lint errors 2020-05-20 11:21:05 -07:00
Nate Smith
e9d6e13339
Merge pull request #915 from mtfurlan/docs/manpage 
Generate manpages from cobra
 2020-05-20 09:58:50 -05:00
Mislav Marohnić
fb63efcf05 Avoid crash around "DISMISSED" or "PENDING" reviewer states 2020-05-20 14:59:40 +02:00
Mislav Marohnić
6385c32031 Include license information in release archives 2020-05-20 13:15:44 +02:00
Mislav Marohnić
a9e83dcc36 Tweak release process re: man pages 2020-05-20 13:07:48 +02:00
Mark Furland
af93bab887 remove unnecessary mkdir from makefile 2020-05-19 22:42:44 -04:00
Mark Furland
6387078532 add make manpages hook and fix makefile 2020-05-19 22:40:14 -04:00
Mark Furland
db2fac93ea generate manpages into ./share/man/man1 2020-05-19 18:43:26 -04:00
Mark Furland
dffb55889c install manpages for homebrew 2020-05-19 15:58:27 -04:00
Nate Smith
45dec1b3e0
Merge pull request #962 from cli/pr-diff 
pr diff
 2020-05-19 14:11:36 -05:00
vilmibm
983a1d9c3c better names 2020-05-19 14:08:20 -05:00
Corey Johnson
e0dbf37b5a
Merge pull request #960 from cli/prêt-à-réviser 
Add `gh pr ready`
 2020-05-19 11:29:33 -07:00
Corey Johnson
d209c0be01 Allow pr urls 2020-05-19 11:04:43 -07:00
vilmibm
c98b0924dc properly handle REST errors 2020-05-19 11:58:49 -05:00
Mark Furland
e13fc2465f use consistent var declaration format 2020-05-19 12:21:20 -04:00
Nate Smith
06e43ac881
Merge pull request #964 from dulltz/cosmetic-short 
Cosmetic about short descriptions
 2020-05-19 00:10:24 -05:00
dulltz
821324c2fb cosmetic 
- Align the first letter to uppercase.
- Align with no period at the end.
 2020-05-19 12:03:56 +09:00
Nate Smith
d1bdb31558
Merge pull request #958 from cli/ci-git-id 
fix and tweak for site build
 2020-05-18 17:47:35 -05:00
vilmibm
ccda5ced51 lint 2020-05-18 17:45:47 -05:00
vilmibm
51b4212070 add basic tests 2020-05-18 17:39:54 -05:00
vilmibm
8e6b8d3901 cleanup 2020-05-18 17:23:36 -05:00
vilmibm
c159d41fc2 manually colorize 2020-05-18 17:15:48 -05:00
vilmibm
aaebdfc46f working with gross colorize hack + no pager 2020-05-18 16:49:51 -05:00
Corey Johnson
fde5409a70
Update command/pr_test.go 
Co-authored-by: Billy Griffin <5091167+billygriffin@users.noreply.github.com>
 2020-05-18 14:40:04 -07:00
Corey Johnson
be927b34ae
Update command/pr_test.go 
Co-authored-by: Billy Griffin <5091167+billygriffin@users.noreply.github.com>
 2020-05-18 14:39:52 -07:00
Corey Johnson
6eab3751d0
Update command/pr.go 
Co-authored-by: Billy Griffin <5091167+billygriffin@users.noreply.github.com>
 2020-05-18 14:39:43 -07:00
Corey Johnson
9721f75b2b
Update command/pr.go 
Co-authored-by: Billy Griffin <5091167+billygriffin@users.noreply.github.com>
 2020-05-18 14:39:29 -07:00
vilmibm
b94860bae7 add command file with pr resolution 2020-05-18 15:43:27 -05:00
Corey Johnson
b42f5527fd Remove hot dog 2020-05-18 13:27:23 -07:00
vilmibm
14e8498b90 fix path 2020-05-18 15:14:10 -05:00
Corey Johnson
78bc7260e0 Add closed test 2020-05-18 13:08:57 -07:00
vilmibm
d2bdd53dd2 depend on bin/gh 2020-05-18 15:08:31 -05:00
vilmibm
d800e3f0b6 rely on environment 2020-05-18 15:07:28 -05:00
Corey Johnson
0b0070e725 Add "already marked" test 2020-05-18 13:03:43 -07:00
Corey Johnson
922b6e06e0 Can be marked ready for review 2020-05-18 12:42:16 -07:00
Nate Smith
b904ed6556
Merge pull request #955 from vilmibm/skipfix 
reenable skipping body prompt for pr/issue
 2020-05-18 14:23:24 -05:00
vilmibm
da95cbd1bf use gh if available when cloning site 2020-05-18 14:05:50 -05:00
vilmibm
296062b869 configure author on site commits 2020-05-18 14:01:35 -05:00
Corey Johnson
fad9f24f39 Make reopen work 2020-05-18 11:11:13 -07:00
Corey Johnson
350b4c85c0 Add failing test 2020-05-18 11:11:02 -07:00
vilmibm
228d01a037 reenable skipping body prompt for pr/issue 2020-05-18 10:23:20 -05:00
Mislav Marohnić
4d11732a47
Merge pull request #943 from cli/reauth-bug 
pass apiClient to determineBaseRepo
 2020-05-18 13:16:07 +02:00
Kevin Bluer
d440a95aed
Improved error message when "owner/repo" format not provided (#919) 
Fixes #882
 2020-05-18 11:13:48 +02:00
vilmibm
c8c807b954 pass apiClient to determineBaseRepo 
Our code had an unspoken assumption that only one apiClient is created
during the course of a command. Violating this assumption is fine in
almost all cases, but not when we need to do a re-auth to add a new
oauth scope to a user's token.

There is likely a more elegant solution to the problem but until then
this changes determineBaseRepo to use an existing apiClient.
 2020-05-15 15:29:33 -05:00
Nate Smith
c115d32b74
Merge pull request #923 from cli/install-source 
Change source installation docs to avoid suggesting to change PATH
 2020-05-14 13:36:05 -05:00
Mislav Marohnić
e3676c3a95 Change source installation docs to avoid suggesting to change PATH 2020-05-14 18:32:57 +02:00