Commit graph

5356 commits

Author SHA1 Message Date
Jeff Hubbard
125a7b00a2 Fix tests 2022-03-18 14:44:15 -07:00
Jeff Hubbard
8abf50be1d Change some copy per product's suggestions 2022-03-18 10:10:57 -07:00
Jeff Hubbard
ce3d0791c3
Merge branch 'trunk' into multi-devcontainer 2022-03-16 12:51:03 -07:00
Charlie Andrews
bb4fc52199
Merge pull request #5319 from cwndrws/cwndrws/codespaces/handle-codespaces-with-pending-operations
[Codespaces] Disallow some operations on codespaces that have a pending operation
2022-03-16 11:29:06 -04:00
Mislav Marohnić
f3f14555f8
Merge pull request #5323 from cli/dependabot/go_modules/github.com/stretchr/testify-1.7.1
Bump github.com/stretchr/testify from 1.7.0 to 1.7.1
2022-03-16 15:39:58 +01:00
dependabot[bot]
311b9bd380
Bump github.com/stretchr/testify from 1.7.0 to 1.7.1
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.7.0 to 1.7.1.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](https://github.com/stretchr/testify/compare/v1.7.0...v1.7.1)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-03-16 14:25:15 +00:00
Charlie Andrews
4eedfc05c1 Add docs link comment to Codespaces struct definition 2022-03-16 10:20:13 -04:00
Charlie Andrews
7ca31e02b4 Disallow editing a codespace that has a pending operation
This is already prevented by the API, but this will make the error
message cleaner and easier to understand for the user.

Example of old error message:

```
$ gh cs edit -c cwndrws-redacted -d "some silly name"
error editing codespace: HTTP 422: your codespace has an operation pending: updating to a sku with a different amount of storage; please wait until this operation is complete (https://api.github.com/user/codespaces/cwndrws-redacted)
exit status 1

```

Example of new error message:

```
$ gh cs edit -c cwndrws-redacted -d "some silly name"
error editing codespace: codespace is disabled while it has a pending operation: Changing machine types...
exit status 1
```
2022-03-16 10:13:46 -04:00
Charlie Andrews
64eecef176 Remove unhelpful error wrapper 2022-03-16 09:36:14 -04:00
Charlie Andrews
a2f76fdfe0 Fix copy pasta error to appease the linter 2022-03-16 09:10:54 -04:00
Charlie Andrews
8bf0cb8f13 Refactor the getOrChooseCodespace to always check for pending ops 2022-03-16 08:56:17 -04:00
Charlie Andrews
10e43b5136 Use color variable instead of literal for disabled reason 2022-03-16 08:43:34 -04:00
Charlie Andrews
3ed2e49bd9 Add tests for disallowing all port commands for codespace w/ pending op 2022-03-15 17:27:38 -04:00
Charlie Andrews
f94a1a2bd4 Add test for disallowing opening vs code for codespace with pending op
I also refactored the existing vs code test a bit to work with the new
use of `getOrChooseCodespace`.
2022-03-15 17:27:38 -04:00
Charlie Andrews
6346779f35 Add test for disallowing logs when codespace has a pending op 2022-03-15 17:27:38 -04:00
Charlie Andrews
27a5512b41 Add test for disallowing ssh when codespace has a pending op 2022-03-15 17:27:38 -04:00
Charlie Andrews
5ffe838dce Disallow any port operations when codespace has pending operation
Since all of the port operations require the codespace to be running, we
need to disallow these operations when there's a pending op since we
can't start the codespace in this state.

Since the API already disallows this, this is basically cleaning up the
error messages that the user sees in this state

Old error message:

```
$ gh cs ports forward 80:80
? Choose codespace: redacted
Starting codespace ⣻error connecting to codespace: error starting codespace: HTTP 422: your codespace has an operation pending: updating to a sku with a different amount of storage; please wait until this operation is complete (https://api.github.com/user/codespaces/cwndrws-redacted/start)
```

New error message:

```
$ gh cs ports forward 80:80
? Choose codespace: redacted
codespace is disabled while it has a pending operation: Changing machine types...
exit status 1
```
2022-03-15 17:27:38 -04:00
Charlie Andrews
da99a1b59b Ensure codespace exists and doesn't have a pending op when opening Code
The initial intention for this change was to disallow users to open a
codespace in VS Code if the codespace has a pending operation. This also
adds a side-benefit of presenting the user an error before waiting for
VS Code to open if they provide an invalid codespace to open.
2022-03-15 17:21:28 -04:00
Charlie Andrews
599c7c900f Disallow getting logs from codespaces with pending ops
Since the API already disallows this, this pretty much just cleans up
the error reporting to the user.

Example of old error:

```
$ gh cs logs -c cwndrws-redacted
Starting codespace ⣽connecting to codespace: error starting codespace: HTTP 422: your codespace has an operation pending: updating to a sku with a different amount of storage; please wait until this operation is complete (https://api.github.com/user/codespaces/cwndrws-redacted/start)
exit status 1

```

Example of new error:

```
$ gh cs logs -c cwndrws-redacted
codespace is disabled while it has a pending operation: Changing machine types...
exit status 1
```
2022-03-15 17:21:28 -04:00
Charlie Andrews
afa71c4b2f Disallow ssh'ing to codespace with a pending operation
Since the API already disallows this, this makes the error cleaner and
more explicit when a user is trying to start/ssh into a codespace that
has a pending operation.

Example of the old error message:

```
$ gh cs ssh -c cwndrws-redacted
Starting codespace ⣽error connecting to codespace: error starting codespace: HTTP 422: your codespace has an operation pending: updating to a sku with a different amount of storage; please wait until this operation is complete (https://api.github.com/user/codespaces/cwndrws-redacted/start)
exit status 1

```

Example of the new error message:

```
$ gh cs ssh -c cwndrws-redacted
codespace is disabled while it has a pending operation: Changing machine types...
exit status 1
```
2022-03-15 17:21:28 -04:00
Charlie Andrews
3d28c52104 Mark codespace with pending op as disabled with reason instead of state 2022-03-15 17:21:24 -04:00
Charlie Andrews
3f65e5ae24 Add pending opertion and reason to codespace response struct 2022-03-15 17:19:47 -04:00
Nate Smith
1c260191ee
Merge pull request #5275 from cdb/cdb/rerun-failed-jobs
Support "all failed jobs" and individual job re-run for a github actions workflow run
2022-03-15 12:08:36 -05:00
Mark Phelps
43e4e9514d
Merge pull request #5276 from markphelps/codespaces-accept-perms-wording 2022-03-15 12:55:44 -04:00
Cameron Booth
a20e8b7eec Fix test I missed updating 2022-03-15 09:50:20 -07:00
Josh Gross
f6d2f83938
Support setting Dependabot secrets (#5134)
* Support setting Dependabot secrets

* lint: Remove unnecessary assignment

* Use `StringEnumFlag` helper for Application input

* Add Dependabot to command description

* Move repository name mapping after input validation

* Error when multiple secret entities are set

* Return an error for invalid apps

* Use `assert` instead of `require`
2022-03-15 07:44:51 +02:00
Cameron Booth
e6b09b45de Fix up error and help language 2022-03-14 12:29:49 -07:00
Gowtham Munukutla
83a6cccf2a
Add interactive repository edit functionality (#4895) 2022-03-14 17:49:03 +00:00
Cameron Booth
24ec53365b Return error if both jobID and runID are specified 2022-03-14 10:01:19 -07:00
Cameron Booth
3645975da7 Prefer IsStdoutTTY when that's all we need 2022-03-14 10:00:29 -07:00
Mislav Marohnić
d4ead71d06
Merge pull request #5298 from cli/bump-golangci-lint
Bump golangci-lint version
2022-03-14 15:27:37 +01:00
neilnaveen
07e0e52edd
Fixed permission for workflow (#5279)
https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions

Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-03-14 14:18:21 +01:00
Caleb Brose
ca98aec535
Merge pull request #5297 from cmbrose/cmbrose/cs-cp-profile
Add `--profile` option to `gh cs cp`
2022-03-14 07:10:02 -05:00
Boston Cartwright
bb9bf29835
pr merge switch to base branch if available (#5251)
* after merge, switch to base branch if available

* Add ability to checkout new branch

* Style cleanup

Co-authored-by: Sam Coe <samcoe@users.noreply.github.com>
2022-03-14 14:02:57 +02:00
Jose Garcia
e601a890b2
Merge pull request #5296 from cmbrose/cmbrose/list-vscs-target
Add VSCS Target to `gh cs list`
2022-03-14 07:17:38 -04:00
GitHub Action
de88d9e186 Only export vscsTarget for non-prod 2022-03-11 11:13:38 -06:00
Mislav Marohnić
9278f51aa8 Bump golangci-lint version 2022-03-11 14:58:15 +01:00
GitHub Action
94128d683c Add consts for targets and treat empty as prod 2022-03-10 19:59:24 -06:00
GitHub Action
21a1059f7c Add --profile option to gh cs cp 2022-03-10 19:01:55 -06:00
GitHub Action
5e62a417d8 Add emojis to name 2022-03-10 18:50:12 -06:00
GitHub Action
a3b69e8d87 Add missed file 2022-03-10 17:10:36 -06:00
GitHub Action
d85feafa85 Rename to hasNonProdVSCSTarget 2022-03-10 17:05:13 -06:00
GitHub Action
be5923770b Add vscs-target to gh cs list 2022-03-10 16:42:31 -06:00
Mislav Marohnić
26d33d6e38
Merge pull request #5293 from cli/snakes-on-no-plane
Bump Cobra to eliminate Viper
2022-03-10 19:05:42 +01:00
Mislav Marohnić
cb7315c85d Re-initialize modules cache in CI 2022-03-10 18:29:42 +01:00
Mislav Marohnić
ee1328de49 Bump Cobra to eliminate Viper 2022-03-10 17:28:39 +01:00
Josh Spicer
4d5ce7aa56
Adds internal codespace developer flags (#5287) 2022-03-09 15:59:29 +00:00
Sam Coe
e0045f26b9
Add top level search command and search repos sub command (#5172) 2022-03-09 12:24:27 +00:00
Mislav Marohnić
4a41fec2ed
Merge pull request #5286 from cli/checks-branch
pr checks: fix error message when no checks were found
2022-03-08 18:41:31 +01:00
Mislav Marohnić
a657fa808a pr checks: fix error message when no checks were found
Fixes the error message:

    no checks reported on the '' branch

Now the correct branch name is reported.
2022-03-08 16:44:41 +01:00