Commit graph

4761 commits

Author SHA1 Message Date
Alan Donovan
54a9e74565 Merge branch 'main' into main-style 2021-08-27 18:12:38 -04:00
Jose Garcia
272af2fadf add docs 2021-08-27 18:12:06 -04:00
Alan Donovan
a7a57d8c65 Merge pull request #93 from github/defer-close
api: close HTTP response body stream on all control-flow paths
2021-08-27 18:11:35 -04:00
Alan Donovan
dcf4f041e9 deal with Start errors, non-JSON 2021-08-27 18:01:52 -04:00
Jose Garcia
adc1ee5e2d merge main 2021-08-27 17:43:43 -04:00
Jose Garcia
a5a18026cc fix linter 2021-08-27 17:39:10 -04:00
Jose Garcia
368e8c6110 simplify contract for state polling 2021-08-27 17:34:06 -04:00
Alan Donovan
4545e11ffc Merge branch 'main' into defer-close 2021-08-27 17:33:46 -04:00
Alan Donovan
9f082ca887 Merge branch 'main' into main-style 2021-08-27 17:30:34 -04:00
Jose Garcia
c66cf0da39 Merge pull request #92 from github/jg/remove-dst-port
Remove destination port column and add docs
2021-08-27 17:06:48 -04:00
Jose Garcia
e5f45d4bfa docs and improvement to the showStatus implementation 2021-08-27 16:41:22 -04:00
Jose Garcia
1e8a8370fe initial round of PR feedback 2021-08-27 16:29:02 -04:00
Alan Donovan
e423cb0ef9 display colon and cursor in survey prompts 2021-08-27 16:09:02 -04:00
Alan Donovan
44a22d6965 Merge pull request #97 from github/vscode-error
ghcs code: improve vscode error
2021-08-27 15:56:03 -04:00
Alan Donovan
8b395b5ab5 ghcs code: improve vscode error 2021-08-27 15:53:55 -04:00
Alan Donovan
a5ae72cb26 revert removal of _ = f() to pacify linter 2021-08-27 15:38:41 -04:00
Alan Donovan
d8f1baa519 more SKU renames. 2021-08-27 15:36:45 -04:00
Alan Donovan
da34d12abb respond to review 2021-08-27 15:26:34 -04:00
Alan Donovan
90f3ac6f56 check status codes 2021-08-27 14:23:33 -04:00
Jose Garcia
2cc91c224e add comment for improvements 2021-08-27 12:53:27 -04:00
Jose Garcia
da8655209b make things private 2021-08-27 12:52:30 -04:00
Jose Garcia
cb6552f4ca more efficient impl for processing states 2021-08-27 12:50:32 -04:00
Alan Donovan
38ff786a7d cmd/ghcs: style tweaks 2021-08-27 12:03:20 -04:00
Jose Garcia
8e95493872 period 2021-08-27 15:46:40 +00:00
Jose Garcia
5dc923777b update docs, make ports private to be more consistent 2021-08-27 15:32:18 +00:00
Alan Donovan
0392c50174 api: close HTTP response body on all paths 2021-08-27 11:31:05 -04:00
Jose Garcia
3dcee5cca7 remove dst port column and add docs 2021-08-27 12:41:36 +00:00
Jose Garcia
273782bcbc rename file 2021-08-27 11:49:21 +00:00
Edmundo Gonzalez
49cebb11ca Merge pull request #5 from github/edgonmsft/codespaces-ssh-rpc
Adding sshRPC interface
2021-08-26 16:27:16 -07:00
Edmundo Gonzalez
d5a26e1536 Apply renames on the go-liveshare side. 2021-08-26 23:14:13 +00:00
Edmundo Gonzalez
0eb769d608 Rename File 2021-08-26 23:04:35 +00:00
Edmundo Gonzalez
18ab421b08 Rename to SSHServer 2021-08-26 23:04:05 +00:00
Edmundo Gonzalez
a89c17a564 Adding sshRPC interface 2021-08-26 22:34:56 +00:00
Edmundo Gonzalez
b6094e0006 Changes to point to RPC service. 2021-08-26 21:50:20 +00:00
Mislav Marohnić
99cbfd3dd8
Merge pull request #4213 from cli/defunct-doc-link
Remove defunct link from `gh actions`
2021-08-26 18:16:40 +02:00
Mislav Marohnić
6cbc886c53 Use x/term package for repo garden instead of shelling out to stty
Shelling out to stty seems hard to get right between Linux and macOS.
2021-08-26 16:45:55 +02:00
Mislav Marohnić
5dfeb1f7ce Remove defunct link from gh actions
The online guide that was GitHub CLI-specific no longer exists. Instead,
"GitHub CLI" sections were added to existing individual articles about
managing workflow runs.
2021-08-26 15:48:08 +02:00
Jose Garcia
e4e77a4294 merge upstream 2021-08-26 08:55:38 -04:00
Jose Garcia
151eb2b656 fix linter 2021-08-26 08:35:30 -04:00
Mislav Marohnić
6ec289c408
Merge pull request #4203 from kidonng/patch-1
Use `/usr/bin/env bash` instead of `/bin/bash` in `gh extension create`
2021-08-26 11:36:23 +02:00
Kid
b56f77b2e5
Use /usr/bin/env bash instead of /bin/bash in gh extension create 2021-08-26 00:49:33 +08:00
Gabriel Ramírez
a48f1070c3 Merge pull request #86 from github/auto-ssh-composition
Piping support for ssh and code
2021-08-25 09:11:43 -05:00
Mislav Marohnić
11fbb60ae7 Rename the module to "github.com/cli/cli/v2" 2021-08-25 12:41:30 +02:00
Jose Garcia
2ef6e95982 show status under a flag 2021-08-24 20:15:21 -04:00
Jose Garcia
46ee45bcdd simplify the state iteration 2021-08-24 17:46:24 -04:00
Mislav Marohnić
355d28195e
Merge pull request #4189 from cuonglm/issue-4188
Disable auth for cobra shell request completion hidden commands
2021-08-24 20:48:46 +02:00
Cuong Manh Le
6cf6bb4a44 Disable auth for cobra shell request completion hidden commands
Those hidden command are used by the shell completion scripts, but they
are not disabled auth check. Thus, the shell completion does not work
even the completion setup was done properly.

Fixes #4188
2021-08-25 01:35:49 +07:00
Gabriel Ramirez
30be4c98f9 Send codespace name to Stdout to enable scripting 2021-08-24 13:12:18 -05:00
Mislav Marohnić
a94cadc702
Merge pull request #4184 from cli/changelog-squashed-merges
Improve changelog script so it includes squashed merges
2021-08-24 18:59:30 +02:00
Mislav Marohnić
4e219a9c8f Improve changelog script so it includes squashed merges 2021-08-24 14:29:29 +02:00