Commit graph

4761 commits

Author SHA1 Message Date
Jose Garcia
529e3bf5e3 Merge pull request #42 from github/rm-dotcom-note
Remove note about creating a custom SSH setup for dotcom
2021-07-27 08:03:17 -04:00
Tobias Nießen
515902ade3
Fix typo in openSUSE installation instructions 2021-07-27 02:13:35 +02:00
Mislav Marohnić
967ef48306 Merge pull request #41 from github/auto-version
Provide version number at build time
2021-07-26 19:25:06 +02:00
Mislav Marohnić
82c6fb7d1a Add a note about the dummy GHE hostname 2021-07-26 18:59:53 +02:00
Mislav Marohnić
3931c16bd7 Provide version number at build time 2021-07-26 17:07:42 +02:00
Issy Long
bba5ebec8b Merge pull request #39 from github/ssh-codespace-param
cmd/ghcs/ssh: Add `-c` parameter for specifying a Codespace to SSH to
2021-07-26 15:44:11 +01:00
Jose Garcia
892f73221c Update shared visibility finalized tests 2021-07-26 14:39:52 +00:00
Jose Garcia
98282ba4b5 Update shared visibility tests 2021-07-26 14:31:00 +00:00
Issy Long
c092a29350 cmd/ghcs/ssh: Add -c parameter for specifying a Codespace to SSH to
- This adds a `-c`, `--codespace` parameter to `ghcs ssh` to allow for
  non-interactively specifying a Codespace to SSH into, for instance if
  a user has recently done `ghcs list` and already knows which Codespace
  they want to access. Without a value for the `-c` parameter, the
  interactive prompt appears as usual.
2021-07-26 14:58:48 +01:00
Jose Garcia
91114d35c3 More tests 2021-07-24 03:44:20 +00:00
Jose Garcia
fcfb10cb56 Working test for Client.Join 2021-07-23 20:24:50 +00:00
Jose Garcia
9132a28e9c Checking point after continuing to flesh out mock server 2021-07-23 19:15:54 +00:00
Jose Garcia
b9cd9af7fa Start of tests and comments 2021-07-23 01:17:32 +00:00
CamiloGarciaLaRotta
d688dc76ec Merge pull request #36 from github/config/v0.7.1
config: bump to 0.7.1
2021-07-22 10:35:23 -04:00
CamiloGarciaLaRotta
7e49db3be3 config: bump to 0.7.1
Hoping to prove that Goreleaser & Homebrew run automatically
2021-07-22 10:33:00 -04:00
CamiloGarciaLaRotta
f35186485c Merge pull request #31 from github/feat/promptless-create
feat: introduce repo, branch and machine flags for ghcs create
2021-07-22 10:18:03 -04:00
Camilo Garcia La Rotta
14468baba6 config: bump to v0.7.0 2021-07-22 10:13:20 -04:00
CamiloGarciaLaRotta
ba37311927 Merge pull request #30 from github/feat/richer-delete
feat: delete all & delete per repo
2021-07-22 10:10:58 -04:00
CamiloGarciaLaRotta
89cf916e23 Merge branch 'main' into feat/promptless-create 2021-07-22 10:09:21 -04:00
Camilo Garcia La Rotta
3ef0226e20 fix: output available machine names on --machine error 2021-07-22 10:07:09 -04:00
CamiloGarciaLaRotta
2f467e3ddc Merge branch 'main' into feat/richer-delete 2021-07-22 09:55:20 -04:00
Issy Long
8f73b18911 Merge pull request #33 from github/improve-descriptions
cmd/ghcs/*.go: Better short descriptions of what commands do
2021-07-22 14:19:07 +01:00
Issy Long
69865fa762 cmd/ghcs/main: Better description of ghcs as a whole
Co-authored-by: Camilo Garcia La Rotta <camilogarcialarotta@github.com>
2021-07-22 14:08:20 +01:00
Issy Long
b66d65379f cmd/ghcs/*.go: Better short descriptions of what commands do
- I ran `--help` on `ghcs code` and saw `ghcs code` and that was it,
  which was surprising. I expected a description.
- Here's a fix for all of the commands thus far to give them longer
  descriptions.
- I've only done "short" descriptions in Cobra terms, and removed the
  "long" descriptions as they seemed like they needed to be
  unnecessarily verbose.

Before:

```
❯ ghcs --help
Codespaces

Usage:
  ghcs [command]

Available Commands:
  code        code
  create      Create
  delete      delete
  help        Help about any command
  list        list
  ports       ports
  ssh         ssh

Flags:
  -h, --help      help for ghcs
  -v, --version   version for ghcs

Use "ghcs [command] --help" for more information about a command.

❯ ghcs ssh --help
ssh

Usage:
  ghcs ssh [flags]

Flags:
  -h, --help              help for ssh
      --profile string    SSH Profile
      --server-port int   SSH Server Port
```

After:

```
❯ ./ghcs --help
Codespaces

Usage:
  ghcs [command]

Available Commands:
  code        Open a GitHub Codespace in VSCode.
  create      Create a GitHub Codespace.
  delete      Delete a GitHub Codespace.
  help        Help about any command
  list        List GitHub Codespaces you have on your account.
  ports       Forward ports from a GitHub Codespace.
  ssh         SSH into a GitHub Codespace, for use with running tests/editing in vim, etc.

Flags:
  -h, --help      help for ghcs
  -v, --version   version for ghcs

Use "ghcs [command] --help" for more information about a command.

❯ ./ghcs ssh --help
SSH into a GitHub Codespace, for use with running tests/editing in vim, etc.

Usage:
  ghcs ssh [flags]

Flags:
  -h, --help              help for ssh
      --profile string    SSH Profile
      --server-port int   SSH Server Port
```
2021-07-22 11:07:23 +01:00
Jose Garcia
a99d0f5495 Better naming for rpc client and ssh session 2021-07-22 01:07:06 +00:00
Jose Garcia
fddcd876b0 Some more cleanup to the port forwarder and connection 2021-07-22 01:02:03 +00:00
Camilo Garcia La Rotta
a68cda1469 refactor: break down Create() into smaller funcs 2021-07-21 20:54:18 -04:00
Jose Garcia
7332aa428c Large refactor and solidifying of APIs before tests 2021-07-22 00:45:45 +00:00
Camilo Garcia La Rotta
3db217fef0 feat: make sku survey optional 2021-07-21 20:27:22 -04:00
Camilo Garcia La Rotta
aab98ccc18 feat: break out repo and branch surveys 2021-07-21 20:06:05 -04:00
Camilo Garcia La Rotta
c751e88120 feat: introduce repo, branch and machine flags for ghcs create 2021-07-21 19:56:08 -04:00
Jose Garcia
71a55b2126 Merge branch 'main' of github.com:github/go-liveshare 2021-07-21 18:54:13 -04:00
Camilo Garcia La Rotta
5ca2fa5562 feat: ghcs delete repo REPO_NAME 2021-07-21 18:13:36 -04:00
Camilo Garcia La Rotta
7a0a8fa39c feat: ghcs delete all 2021-07-21 18:02:50 -04:00
Camilo Garcia La Rotta
0d6926e14b doc: root cmd description 2021-07-21 17:41:50 -04:00
Sam Coe
340a1fdc93
Add --force flag for extensions upgrade 2021-07-21 11:06:22 -07:00
Jose Garcia
35f458b853 Merge pull request #28 from github/jg/fix-ssh
Fix ssh command order
2021-07-21 14:06:18 -04:00
Jose Garcia
532ee68165 Fix ssh command order 2021-07-21 14:04:42 -04:00
Jose Garcia
345e3e1b8a Update main.go 2021-07-21 13:50:19 -04:00
Jose Garcia
f7c80c99e7 Merge pull request #27 from github/jg/code-command
ghcs code command support
2021-07-21 13:48:10 -04:00
Jose Garcia
b44355d80d Merge pull request #26 from github/jg/secrets-and-server-port
Don't overwrite .zshenv, support server port for SSH, forward X11
2021-07-21 13:30:16 -04:00
Jose Garcia
c2b136a84f ghcs code command support 2021-07-21 13:28:47 -04:00
Mislav Marohnić
2801206663 Switch to Cobra's bash completion V2 2021-07-21 16:32:39 +02:00
Jose Garcia
3e50fff2c9 X11 support 2021-07-21 10:22:33 -04:00
Mislav Marohnić
6ed2e8f7f8 Add completion support to repo create --gitignore and --license 2021-07-21 16:12:38 +02:00
Mislav Marohnić
4d7625c8a0 Allow shell-completing multiple --json fields separated by commas 2021-07-21 16:12:38 +02:00
Mislav Marohnić
db8204dc56 Allow space to be added after completing issue/pr list --state values
The "nospace" directive instructs the shell completion logic to avoid
adding a space after completing the word. However, this feature was
broken in an older Cobra, and users still saw a space character added.
In most case we want the space because we anticipate that the user might
want to add extra arguments to the command.
2021-07-21 16:12:38 +02:00
Mislav Marohnić
3e8f075a8e Bump Cobra for improved completion support 2021-07-21 15:01:31 +02:00
Kristján Oddsson
aa0ef37ffc Merge pull request #25 from github/fix-error-message-wording-and-link
Update error message link and wording.
2021-07-21 13:01:07 +01:00
Kristján Oddsson
7a3e47ff3e Update error message link and wording. 2021-07-21 12:46:44 +01:00