Commit graph

4761 commits

Author SHA1 Message Date
bchadwic
285f8659b3 clean up 2021-07-21 01:11:38 -07:00
bchadwic
8962aeebf9 changed functionality to open up last commit with -c / --commit for gh browse 2021-07-21 01:08:15 -07:00
Jose Garcia
e81bee6886 Doesn't overwrite .zshenv and supports server-port 2021-07-20 18:43:43 -04:00
Sam
fa354a922b
Merge pull request #3905 from cli/extensions-list-notice
Add update checking to extensions list
2021-07-20 13:21:30 -07:00
Sam Coe
e70bdbf7a9
Add update checking to extensions list 2021-07-20 13:13:20 -07:00
Mislav Marohnić
3ff94ae76b
Merge pull request #4025 from cli/revert-3926-update-goreleaser-20210630
Revert "Update GoReleaser"
2021-07-20 22:02:49 +02:00
Mislav Marohnić
6c8abe9df6
Merge branch 'trunk' into revert-3926-update-goreleaser-20210630 2021-07-20 21:43:51 +02:00
Mislav Marohnić
85d0447a6e
Revert "Update GoReleaser to v0.172.1" 2021-07-20 21:39:50 +02:00
Mislav Marohnić
5bbce4a5b9 Fix goreleaser config for linux packages 2021-07-20 20:15:48 +02:00
Mislav Marohnić
ccd4f0fa9a
Merge pull request #3706 from cristiand391/improve-automerge
PR auto-merge improvements
2021-07-20 19:55:43 +02:00
Mislav Marohnić
a83c2924c5 Never prompt to delete branch if --auto was given 2021-07-20 19:49:19 +02:00
Mislav Marohnić
6e026412df Add "UNSTABLE" to immediately mergeable statuses
This status describes a state where the head branch is mergeable and
technically not blocked per base branch requirements, but it does have
non-passing checks.
2021-07-20 19:42:53 +02:00
Mislav Marohnić
6f2dfd7eea Adjust conditions for switching between regular and auto merge
Conditions prohibiting a regular merge: BLOCKED, BEHIND, DIRTY.

Conditions triggering a regular merge even if `--auto` was set: CLEAN,
HAS_HOOKS.

Note that UNKNOWN status does not trigger either of the conditions.
2021-07-20 19:34:32 +02:00
Mislav Marohnić
0ab9c70c3f Merge remote-tracking branch 'origin' into improve-automerge 2021-07-20 18:45:47 +02:00
Mislav Marohnić
1ca49a8bcd
Merge pull request #3980 from cli/bump-survey
Bump Survey library for cursor improvements
2021-07-20 18:34:14 +02:00
Mislav Marohnić
2624ed9d8c Merge remote-tracking branch 'origin' into bump-survey 2021-07-20 18:28:58 +02:00
Mislav Marohnić
4a7b130511
Merge pull request #3981 from cli/bump-gojq
Bump gojq to latest version
2021-07-20 18:27:07 +02:00
Mislav Marohnić
25ef11198f
Merge pull request #4020 from cli/xdg-docs
Clean up GH_CONFIG_DIR docs
2021-07-20 18:02:23 +02:00
Mislav Marohnić
1121ec6669
Merge pull request #4013 from chemotaxis/docs/alias-quotes-windows
Add documentation about double quoting on Windows
2021-07-20 18:01:36 +02:00
Mislav Marohnić
75c7fc1536
Merge pull request #3972 from g14a/fix/private-repo-create
fix private repo creation in case of ignore templates & repo description bugs in case of template repos
2021-07-20 16:39:36 +02:00
Mislav Marohnić
1de756f6f3 💅 address review comments 2021-07-20 16:34:11 +02:00
Mislav Marohnić
c598a1edc2 Fix detecting cases when cfg.Hosts() is empty 2021-07-20 15:50:58 +02:00
Mislav Marohnić
efa4d43cf4 Simplify alias set documentation 2021-07-20 15:32:51 +02:00
Mislav Marohnić
9033258f5f Clean up GH_CONFIG_DIR docs
This removes the false equivalence between GH_CONFIG_DIR and
XDG_CONFIG_HOME. These settings do not have the same effect and should
not be used for the same purposes.

Also remove the documentation about what `XDG_*` settings do. We simply
conform to the XDG Base Directory Specification, but will not document
it. It's likely that users of these environment variables already know
what they do.
2021-07-20 14:24:11 +02:00
Mislav Marohnić
aec0f10041 Fix error message when using GH_ENTERPRISE_TOKEN but host is ambiguous
Before:

    $ GH_ENTERPRISE_TOKEN="..." gh pr create
    could not find hosts config: not found

Now:

    $ GH_ENTERPRISE_TOKEN="..." gh pr create
    set the GH_HOST environment variable to specify which GitHub host to use

Also amends `gh help environment` documentation to suggest the use of
GH_HOST when scripting operations with GitHub Enterprise repositories.
2021-07-20 14:11:07 +02:00
Jose Garcia
8faee1e5a9 Update main.go 2021-07-20 08:09:48 -04:00
Jose Garcia
5e803aca79 Merge pull request #20 from github/jg/better-conn-handling
Bump go-liveshare w/ better connection handling and simpler ssh setup
2021-07-20 08:08:33 -04:00
Jose Garcia
6642fb520a Better connection handling and simpler ssh setup 2021-07-20 08:04:34 -04:00
Issy Long
2f8d00e0f8 Merge pull request #19 from github/version-cmd
cmd/ghcs/main: Add `--version` flag
2021-07-20 13:02:41 +01:00
Issy Long
f7e32485fc Merge pull request #18 from github/gracefully-fail-if-token-envvar-unset
cmd/ghcs/main: Fail gracefully if `GITHUB_TOKEN` entirely unset
2021-07-20 13:02:35 +01:00
Jose Garcia
6d5726d78a Better way to discard requests & close channel/conn on disconnects 2021-07-20 11:59:14 +00:00
Mislav Marohnić
25b6eecc8d
Merge pull request #4017 from despreston/des/avoid-migrate
Skip auto migrate of config when GH_CONFIG_DIR
2021-07-20 13:33:16 +02:00
Des Preston
1c9b4bf99d Skip auto migrate of config when GH_CONFIG_DIR
If GH_CONFIG_DIR is set, don't auto migrate the config file. This fixes
the situation where the path given via GH_CONFIG_DIR does not exist and
the cli attempts to migrate an existing config to that location.

Fixes #3837
2021-07-19 16:33:51 -04:00
chemotaxis
1e4e536bcb Revise Windows note 2021-07-19 15:50:27 -04:00
chemotaxis
2c52819c1a Remove note about using Git for Windows
As discussed in pull request #4013.
2021-07-19 15:50:12 -04:00
Sam
97a52f74cd
Merge pull request #3933 from cli/extensions-upgrade
Skip trying to upgrade local extensions
2021-07-19 10:55:16 -07:00
Sam Coe
b71735d0d7
Address PR comments 2021-07-19 10:48:09 -07:00
Issy Long
4582fed1cc cmd/ghcs/main: Add --version flag
- This is built into Cobra the argument parser. Now `ghcs --version`
  exists.
- When we prepare to bump the version, we need to remember to update
  this value else the Homebrew formula, GitHub releases and the `ghcs
  --version` output will be mismatched.
- Fixes https://github.com/github/ghcs/issues/16.
2021-07-19 18:45:18 +01:00
Issy Long
cb29b11ab2 cmd/ghcs/main: Fail gracefully if GITHUB_TOKEN entirely unset
- I have my GitHub API token in my environment as
  `HOMEBREW_GITHUB_API_TOKEN`, so with things that need `GITHUB_TOKEN` I
  have to remember to `export GITHUB_TOKEN=$HOMEBREW_GITHUB_API_TOKEN`.
- I didn't for this tool, and got this unfriendly error message:

```
❯ ghcs list
Error: error getting user: Bad credentials
Usage:
  ghcs list [flags]

Flags:
  -h, --help   help for list

error getting user: Bad credentials
```

- This moves the "do you have a `GITHUB_TOKEN`" question to the very
  beginning (no guarantees about org SSO access, just a string that
  exists), erroring out with a nice message if users don't have that
  envvar set:

```
issyl0 in cetus in ~/repos/github/ghcs/cmd/ghcs on gracefully-fail-if-token-envvar-unset
❯ ./ghcs list
The GITHUB_TOKEN environment variable is required. Create a Personal Access Token with org SSO access at https://github.com/settings/tokens/new.

issyl0 in cetus in ~/repos/github/ghcs/cmd/ghcs on gracefully-fail-if-token-envvar-unset
❯ export GITHUB_TOKEN=$HOMEBREW_GITHUB_API_TOKEN

❯ ./ghcs list
+--------------------------------+--------------------+------------------------------------+----------+---------------------------+
|              NAME              |     REPOSITORY     |               BRANCH               |  STATE   |        CREATED AT         |
+--------------------------------+--------------------+------------------------------------+----------+---------------------------+
| issyl0-github-cat-ggrpj5fvwvr  | github/cat         | dependabot/bundler/graphql-1.12.13 | Shutdown | 2021-07-13T12:36:53+01:00 |
+--------------------------------+--------------------+------------------------------------+----------+---------------------------+
```
2021-07-19 18:10:15 +01:00
Jose Garcia
570a407bac Fix directive 2021-07-19 08:00:51 -04:00
chemotaxis
23ffca45f7 Unify use of single quotes to mark shell arguments and variables
The first paragraph uses single quotes when referring to shell arguments
and variables, but the rest of the docs use double quotes.  This commit
switches to using single quotes throughout the docs.

I prefer to use single quotes inside string literals because Go uses
double quotes to define a string literal.
2021-07-19 00:46:06 -04:00
chemotaxis
5314e7c398 Add note about double quotes on non-Unix-like shells
On non-Unix-like shells like Windows Command Prompt, single quotes are
handled differently.  You need to define aliases using double quotes
instead of single quotes.

I added an inline example to illustrate the quotes.  The example is
formatted as inline code blocks in Markdown.  Unfortunately, because Go
uses backticks for raw string literals, I needed to do some rather ugly
string concatenation in order to get the backticks included in the doc
string.

This also rearranges the notes so that the platform specific notes are
at the end of the documentation.
2021-07-19 00:36:07 -04:00
Jose Garcia
798413848b Portfowarding private/public/forward now supported 2021-07-17 20:32:47 -04:00
Jose Garcia
e373c91f8b UpdateSharedServerVisibility API for Server 2021-07-18 00:05:13 +00:00
Jose Garcia
3c42ab8f7a ghcs ports v1 2021-07-16 18:45:38 -04:00
Jose Garcia
98bcdd16cf Support for GetSharedServers 2021-07-16 22:34:51 +00:00
Mislav Marohnić
496b70ac0e
Merge pull request #3934 from cli/extensions-remove-notice
Add confirmation to extensions remove
2021-07-16 15:18:38 +02:00
Mislav Marohnić
882f6d33cb Merge remote-tracking branch 'origin' into extensions-remove-notice 2021-07-16 15:12:56 +02:00
Mislav Marohnić
d68df4a9d8 Do not output error messages for nontty 2021-07-16 15:10:36 +02:00
Mislav Marohnić
30beb67cb3
Merge pull request #3941 from cli/extension-install-check
Extension install check
2021-07-16 14:58:52 +02:00