Commit graph

5 commits

Author SHA1 Message Date
William Martin
9bd8f09774 Use safepaths for run download 2024-12-04 22:12:58 +01:00
Andy Feller
cdfc12caf5 Expand logic and tests to handle edge cases
This commit expands filepathDescendsFrom(string, string) to handle edge cases such as mixing absolute and relative paths or artifact name edge cases.

Additionally, tests for filepathDescendsFrom() and downloadrun() have been expanded to verify additional use cases.
2024-11-22 15:26:11 -05:00
Sam Coe
39805fa9b1
Properly handle closing files that have been writen to (#7199) 2023-03-23 01:17:47 +00:00
Mislav Marohnić
a315e6865c run download: fix extracting to root path
Our rudimentary check for whether a file path is entirely contained
under a directory had a false negative when the parent directory is "/".
2022-02-18 20:27:40 +01:00
Mislav Marohnić
f8c7fd1d28 Fix extracting workflow artifact to a relative path
To prevent zipslip, we verify that each extracted file would fall
strictly under the prefix of the path to extract to. However, this
yielded a false positive when extracting to `.`, which is the default
for downloading a single archive.
2021-04-13 19:15:14 +02:00