Commit graph

2255 commits

Author SHA1 Message Date
Mislav Marohnić
1ad9b0b14e Have FindDraftRelease be truer to its name 2020-09-03 15:35:07 +02:00
Mislav Marohnić
d4b45c68e2 Allow downloading assets from the latest release 2020-09-03 15:34:10 +02:00
Mislav Marohnić
151a7340a6 Fix .zip and .js overrides for Windows 2020-09-03 11:44:54 +02:00
Mislav Marohnić
02a057a709 Try fixing Windows tests 2020-09-02 22:11:46 +02:00
Mislav Marohnić
6933c381bf Restore Go 1.13 compatibility 2020-09-01 19:12:02 +02:00
Mislav Marohnić
4976bd75e1 Fix date-based release output and tests 2020-09-01 19:09:10 +02:00
Mislav Marohnić
0f42c7af4d Add tests for release create, delete, download, view 2020-09-01 18:56:30 +02:00
Mislav Marohnić
9ef1791fdb Provide machine-readable release view output 2020-09-01 15:23:43 +02:00
Mislav Marohnić
d0d9cc2f9b View latest release if no tag provided 2020-09-01 14:16:59 +02:00
Mislav Marohnić
9b45112e69 Add tests for release list/delete 2020-08-28 19:26:16 +02:00
Mislav Marohnić
9a4a5d86cb Merge remote-tracking branch 'origin' into release-cmd 2020-08-28 17:47:53 +02:00
Mislav Marohnić
d43d5e0bc9 Add release delete 2020-08-28 17:41:00 +02:00
Mislav Marohnić
987e95f0c8
Merge pull request #1593 from wilso199/docs/brew-installation
Updating Brew Installation Instructions
2020-08-28 12:24:49 +02:00
Mislav Marohnić
9e5b7aa371
Merge pull request #1594 from cli/remove-feedback-form
Remove reference to feedback form
2020-08-28 12:24:18 +02:00
Sam Coe
41f42d4057 Remove reference to feedback form 2020-08-28 09:06:31 +02:00
wilso199
3275690b83 Updating brew install 2020-08-27 20:48:44 -04:00
Nate Smith
87712242ad
Merge pull request #1584 from cli/pr-create-repo-override-crash
Correctly surface errors when parsing `pr create --repo` override
2020-08-27 14:00:58 -05:00
Nate Smith
74524fc8f7
Merge pull request #1585 from cli/pr-commands-repo-override-arg
Disallow `pr -R` flag for commands that operate on the current branch
2020-08-27 10:52:18 -05:00
Nate Smith
2aa0f817ef
Merge pull request #1583 from cli/oauth-device-fallback-fix
Handle "unauthorized_client" HTTP 400 error when doing Device Flow
2020-08-27 10:49:14 -05:00
Mislav Marohnić
c21caf5b2b Disallow pr -R flag for commands that operate on the current branch
If the `--repo` flag is specified, then the user intends to select a
repository other than the current one. In that case, it doesn't make
sense to fall back to detecting the PR belonging to the current branch,
so throw a descriptive error instead.
2020-08-27 16:30:34 +02:00
Mislav Marohnić
b7550fbf15 Correctly surface errors when parsing pr create --repo override
This avoids a crash when passing invalid input for the
`pr create --repo` flag.
2020-08-27 14:26:27 +02:00
Mislav Marohnić
1c0f83ffd5 Handle "unauthorized_client" HTTP 400 error when doing Device Flow
The "unauthorized_client" error means that OAuth Device Flow is implemented, but either isn't enabled on this GHES instance, or that it isn't enabled for this particular OAuth app. In these cases we fall back to old OAuth app authorization flow.
2020-08-27 14:10:16 +02:00
Nate Smith
f1ea794bf1
Merge pull request #1580 from dan1elhughes/feature/number-url-scriptable-output
Number and URL included in scriptable output
2020-08-26 16:41:53 -05:00
Dan Hughes
7b8d052f0e
Add new output to existing test 2020-08-26 17:31:13 +01:00
Dan Hughes
a3aea11e5b
Include URL and number in non-TTY output 2020-08-26 17:28:17 +01:00
Nate Smith
727b726667
Merge pull request #1579 from cli/stderr-color-windows
Enable color ANSI escape sequences on stderr on Windows
2020-08-26 10:37:42 -05:00
Mislav Marohnić
ac0b49dc00 Enable color ANSI escape sequences on stderr on Windows 2020-08-26 16:47:08 +02:00
Nate Smith
27c49279b3
Merge pull request #1567 from ganboonhong/view-without-username
View repositories without username
2020-08-25 13:57:42 -05:00
Nate Smith
e8c4b301d3
Merge pull request #1522 from cli/oauth-device-flow
Implement OAuth Device Authorization flow
2020-08-25 13:54:07 -05:00
Mislav Marohnić
9829a4dc84 Update release list output to contain badges 2020-08-25 20:33:54 +02:00
Nate Smith
fc1c800042
Merge pull request #1492 from ShubhankarKG/newConfirmations
New confirmations
2020-08-25 13:31:47 -05:00
Mislav Marohnić
f7d0988799 Offer different editor modes during release create 2020-08-25 20:20:44 +02:00
Nate Smith
82c6830849
Merge pull request #1548 from cli/auth-check
new auth flow UX
2020-08-25 10:16:23 -05:00
vilmibm
451ece198b missed a disable auth check 2020-08-25 10:10:16 -05:00
vilmibm
2850ef0e17 forgot to run goimports 2020-08-24 13:32:20 -05:00
vilmibm
f3d1f9e56e no ascii art 2020-08-24 13:29:51 -05:00
boonhong
931fee566e shorthand of view without username 2020-08-23 23:33:50 +08:00
Mislav Marohnić
4f6021a56d Add interactive flow for release create 2020-08-21 18:27:58 +02:00
Mislav Marohnić
cf46ae2db7 Log larger response bodies with DEBUG=api 2020-08-21 18:00:52 +02:00
Mislav Marohnić
33fd6b1149 Change API authentication to allow asset downloads
We install an HTTP middleware that adds the "Authorization" header on
every HTTP request. However, our asset download process might redirect
to a 3rd-party host (Amazon S3) and we want to allow those requests but
not require that they are authenticated.

Furthermore, we need the ability to specify the `Accept` request header
without it being overwritten by middleware, so now middleware only adds
headers that are not present in a request.
2020-08-21 18:00:52 +02:00
Mislav Marohnić
a00d927970 Add release download, upload files on create, upload retrying 2020-08-21 18:00:52 +02:00
Mislav Marohnić
4e05db97e4 Add release upload command 2020-08-20 17:59:47 +02:00
ShubhankarKG
7955c4f2ed doSetup wasn't getting called in cases where required.
The problem was that opts.confirmSubmit was mutated before reaching doSetup. This commit creates a copy of the initial confirmSubmit value. So the doSetup receives the initial data passed from the command, not the mutated one.
2020-08-20 14:20:55 +05:30
ShubhankarKG
00b2777a14 Change visibility strings to Sentence case 2020-08-20 14:10:18 +05:30
Nate Smith
b9292f582f
Merge pull request #1476 from rimazk123/prclose-delete
Add delete branch flag to pr close
2020-08-19 21:11:48 -05:00
vilmibm
e44eb665a1 Merge remote-tracking branch 'origin/trunk' into prclose-delete 2020-08-19 21:06:04 -05:00
Nate Smith
ddfa1714d2
Merge pull request #1479 from wilso199/pr-checkout-submodules
PR Checkout - Recurse Submodules
2020-08-19 16:46:21 -05:00
vilmibm
16f69e9c12 fix tests 2020-08-19 16:40:13 -05:00
vilmibm
5c4f93ad0a Merge remote-tracking branch 'origin/trunk' into pr-checkout-submodules 2020-08-19 16:37:01 -05:00
Nate Smith
88b5a3b2f4
Merge pull request #1534 from mmontes11/pr-diff-use-default-pager
Using default pager in gh pr diff
2020-08-19 12:40:33 -05:00