Phill MV
1cbdcedc80
Merge branch 'trunk' into phillmv/improve-gh-at-inspect
2024-11-27 16:40:22 -05:00
Andy Feller
1fe14c956d
Merge commit from fork
...
Use only one pattern for credential helper matching
2024-11-27 15:57:08 -05:00
William Martin
bd44d33eaa
Add checkout test that uses ssh git remote url
2024-11-27 13:06:35 +01:00
William Martin
72a6fd00a4
Rename backwards compatible credentials pattern
2024-11-27 12:21:55 +01:00
William Martin
efd8ff6d46
General cleanup and docs
2024-11-26 22:30:11 +01:00
William Martin
19d62826d6
Allow repo sync fetch to use insecure credentials pattern
2024-11-26 22:30:07 +01:00
William Martin
6b7f1ff060
Allow client fetch to use insecure credentials pattern
2024-11-26 22:30:03 +01:00
William Martin
7affcadb5e
Allow client push to use insecure credential pattern
2024-11-26 22:29:58 +01:00
William Martin
75712de712
Allow client pull to use insecure credential pattern
2024-11-26 22:29:51 +01:00
William Martin
46922694dc
Support secure credential pattern
2024-11-26 22:29:38 +01:00
Phill MV
c8e6ac2e6c
wip, linting, getting tests to pass
2024-11-26 16:19:05 -05:00
Andy Feller
b133f9cce0
Merge pull request #9791 from cli/kw/cli-9773-informative-message-for-workflow-scope
...
Print friendly error when `release create` fails due to missing `workflow` OAuth scope
2024-11-26 08:30:59 -05:00
bagtoad
deb34d6456
Refactor error handling for missing "workflow" scope in createRelease
2024-11-23 16:59:49 -07:00
Kynan Ware
a4f96d29e3
Refactor workflow scope checking
...
Refactor the logic for checking `workflow` scope checking in releases to be in the positive - check if the scope is there, not check if it isn't there. Then, when the function is called we invert it.
Also update comments to be more imperative.
This refactor also incorporates @andyfeller's suggestion to use `slices`.
Co-Authored-By: Andy Feller <andyfeller@github.com>
2024-11-23 13:17:09 -07:00
Phill MV
b50022db08
wip: added new printSummaryInspection
2024-11-22 17:08:51 -05:00
Kynan Ware
ae87caf8d6
Merge pull request #9948 from cli/kw/use-heredoc-for-several-command-docs
...
Fix some multiline command documentation to use `heredoc` strings
2024-11-22 10:11:32 -07:00
Phill MV
6a9a1f0143
Merge branch 'trunk' into phillmv/improve-gh-at-inspect
2024-11-22 11:09:48 -05:00
Phill MV
583a3ac656
Merge branch 'trunk' into phillmv/improve-gh-at-inspect
2024-11-22 11:09:19 -05:00
Meredith Lancaster
f92d703554
pr feedback
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-21 15:40:15 -07:00
Meredith Lancaster
0fd09eb5ff
pr feedback
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-21 15:30:41 -07:00
Meredith Lancaster
fed3c8142c
Update pkg/cmd/attestation/verify/attestation_integration_test.go
...
Co-authored-by: Phill MV <phillmv@github.com>
2024-11-21 15:20:44 -07:00
Kynan Ware
74f13a9b4f
Apply suggestions from code review
...
Co-authored-by: Andy Feller <andyfeller@github.com>
2024-11-21 13:55:35 -07:00
bagtoad
677ed2cdcf
Refactor command documentation to use heredoc
2024-11-21 13:23:03 -07:00
Meredith Lancaster
27a268cf17
Merge branch 'trunk' into verify-result-processing
2024-11-21 10:07:03 -07:00
Meredith Lancaster
2d41225dd5
pr feedback
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-21 09:11:18 -07:00
Meredith Lancaster
28565dc1f8
remove unused test file
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-21 08:58:55 -07:00
Meredith Lancaster
7a271b008a
undo change
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-21 08:58:23 -07:00
Meredith Lancaster
4d277df559
add more testing testing fixtures
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-21 08:43:21 -07:00
Meredith Lancaster
19afe453c7
update test with new test bundle
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-20 14:53:02 -07:00
Meredith Lancaster
5601149c83
naming
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-20 13:34:40 -07:00
Meredith Lancaster
ff8844a308
update test
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-20 13:22:55 -07:00
Meredith Lancaster
4671b8d66b
update test
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-20 12:46:06 -07:00
Meredith Lancaster
3e6861e7e1
clean up
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-19 16:28:36 -07:00
Meredith Lancaster
b5788f2523
wrap sigstore and cert ext verification into a single function
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-19 16:24:17 -07:00
Dalius Dobravolskas
9414930b5d
Adding option to return baseRefOid in pr view
...
You need to know exact `baseRefOid` so you could show correct diff.
`baseRefName` is not enough sometimes because branch from which PR was
forked might have changes already.
Example usage:
```
gh pr view --json headRefName,headRefOid,number,baseRefName,baseRefOid,reviewDecision
```
2024-11-19 23:50:45 +02:00
Meredith Lancaster
f48e6b56e3
verify cert extensions function should return filtered result list
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-19 14:38:28 -07:00
Meredith Lancaster
9177b22a21
Merge pull request #9892 from malancas/refactor-fetch-attestations
...
Refactor the `getAttestations` functions
2024-11-18 13:56:46 -07:00
Meredith Lancaster
63f37eb369
pr feedback
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-18 08:24:25 -07:00
Meredith Lancaster
30ae1388e4
Update pkg/cmd/attestation/download/download.go
...
Co-authored-by: Phill MV <phillmv@github.com>
2024-11-18 08:19:41 -07:00
Meredith Lancaster
762e99d151
fix function param calls
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-18 08:19:07 -07:00
Meredith Lancaster
c518a3b1f5
Update pkg/cmd/attestation/verification/extensions.go
...
Co-authored-by: Phill MV <phillmv@github.com>
2024-11-18 08:18:04 -07:00
bagtoad
68f3ef79ca
Handle missing "workflow" scope in createRelease
2024-11-16 19:32:37 -07:00
Kynan Ware
04e2a5dd63
Merge branch 'trunk' into 9904-gh-repo-create-to-work-on-bare-repos
2024-11-15 11:56:31 -07:00
Andy Feller
b8ef951de1
Shorten extension release checking from 3s to 1s
...
Addressing feedback from extension author demonstration about a noticable pause waiting for extension execution to complete due to amount of time waiting on channel.
2024-11-13 13:04:01 -05:00
William Martin
7bcb063391
Modify push prompt on repo create when bare
2024-11-11 16:17:06 +01:00
William Martin
8e63268aba
Doc push behaviour for bare repo create
2024-11-11 16:10:32 +01:00
William Martin
e3665955a5
Push --mirror on bare repo create
2024-11-11 16:09:03 +01:00
William Martin
2efb9935db
Doc isLocalRepo and git.Client IsLocalRepo differences
2024-11-11 14:18:26 +01:00
William Martin
f515e9c1e7
Use errWithExitCode interface in repo create isLocalRepo
2024-11-11 14:17:29 +01:00
William Martin
bc85e11d05
Backfill repo creation failure tests
2024-11-11 14:11:16 +01:00
