Commit graph

1907 commits

Author SHA1 Message Date
Sibi
2491e98c41 Title of the PR will be shown while closing, merging and re-opening & test cases updated 2020-07-08 12:22:38 +05:30
Sibi
125547fb7b Show title while closing/reopening issue and meriging PR 2020-07-08 01:25:19 +05:30
Mislav Marohnić
b81122cabd
Merge pull request #1329 from rchaganti/trunk
Update pr.go to add clarity around --delete-branch flag
2020-07-07 15:54:10 +02:00
Ravikanth C
92b936f0f9 Merge branch 'trunk' of https://github.com/rchaganti/cli into trunk 2020-07-07 17:54:56 +05:30
Ravikanth C
4f503a65bd Merge remote-tracking branch 'upstream/trunk' into trunk 2020-07-07 17:52:08 +05:30
Mislav Marohnić
e319aaa6ab Tweak pr merge docs 2020-07-07 13:41:57 +02:00
Ravikanth C
6cbcdf2a74 Clarify how the branch can be retained after pr merge 2020-07-07 13:41:39 +02:00
Mislav Marohnić
ec34cf3873
Merge pull request #1305 from cli/homebrew-tap-branch
Fix `brew install github/gh/gh --HEAD`
2020-07-07 10:42:05 +02:00
Mislav Marohnić
a6ffea8cf5
Merge pull request #1310 from cli/linter-fix
Fix linter warning about sprintf within println
2020-07-07 10:37:54 +02:00
Mislav Marohnić
d0342a42d8
Merge pull request #1304 from cli/missing-config-file
Support `hosts.yml` existing while `config.yml` does not
2020-07-07 10:34:35 +02:00
Ravikanth C
5526dfdd23 Update pr.go
proper go fmted
2020-07-06 19:50:31 +05:30
Ravikanth C
3a87124454 Update pr.go
ran gofmt on this
2020-07-06 19:44:29 +05:30
Ravikanth C
143c80c56c Update pr.go 2020-07-06 19:40:49 +05:30
Ravikanth C
742bb15583 Update pr.go
adding long description for pr merge subcommand to clarify on how the source branch can be retained after a merge
2020-07-06 19:33:17 +05:30
Mislav Marohnić
cc4c8438fa
Merge pull request #1328 from ShubhankarKG/dev
Avoid crash in `issue close/reopen` when issue number is invalid
2020-07-06 14:38:20 +02:00
ShubhankarKG
37d6be58b8 Fixed gh issue close and gh issue reopen when issue number invalid 2020-07-06 17:57:34 +05:30
Mislav Marohnić
94db0a1a04
Merge pull request #1317 from danshearer/trunk
Indicate that Go 1.13 is supported for building from source
2020-07-06 11:20:49 +02:00
danshearer
9b890d9a10 Reduce minimum reuqired version from 1.14 to 1.13.8. This is the version
that ships with Ubuntu 20.04 Long Term Support release and it seems to
work fine.
2020-07-04 16:14:47 +01:00
Mislav Marohnić
9c7d52f9f6 Bump golangci-lint 2020-07-02 17:02:38 +02:00
Mislav Marohnić
ac7b56fc61 Fix linter warning about sprintf within println 2020-07-02 17:01:37 +02:00
Mislav Marohnić
6cc03d30ed
Merge pull request #1253 from cli/remove-global-repo-flag-for-real-this-time
Remove the global repo flag
2020-07-02 15:45:39 +02:00
Mislav Marohnić
cd5a0d69fb :nail_polish: be clearer about the value passed to ResolveRemotesToRepos
`repo` will always be blank here, so replace the argument with a blank
literal instead.
2020-07-02 12:36:31 +02:00
Mislav Marohnić
ed781103c7
Merge pull request #644 from eddumelendez/add_filters_issues
Add filters issues
2020-07-02 12:24:30 +02:00
Mislav Marohnić
ac04c878c0
Merge pull request #1279 from pborzenkov/delete-branch-422
Gracefully handle "422: Reference does not exist" when deleting remote branch
2020-07-02 12:11:12 +02:00
Mislav Marohnić
7eeeed9f58
Merge pull request #1283 from AliabbasMerchant/apiSilent
Support for --silent flag in api
2020-07-02 12:10:13 +02:00
Mislav Marohnić
7d6ae441dd
Merge pull request #1307 from eli-schwartz/makefile-cflags
Make: properly add environment C compiler flags to CGO
2020-07-01 19:34:05 +02:00
Nate Smith
b95ecbb898
Merge pull request #1301 from wilso199/set-vscode-example
Config Documentation - VS Code Example
2020-07-01 12:23:54 -05:00
Eli Schwartz
9bbdf4af99
Make: properly add environment C compiler flags to CGO
Do not pass LDFLAGS as arguments to -ldflags, since these are passed to
'go tool link' and C compiler ldflags need to be passed as
-ldflags "-extldflags \"$LDFLAGS\"" with unreliable handling. Instead
copy over (unmodified) the standard environment variable to the special
golang-specific variable which the go compiler chooses to respect.

While we are at it, handle CPPFLAGS and CFLAGS too.
2020-07-01 11:04:51 -04:00
Mislav Marohnić
b6206aa036 Update the branch name in the github/gh/gh brew formula 2020-07-01 16:14:11 +02:00
Mislav Marohnić
569645a050 Support hosts.yml existing while config.yml does not
After a person copies `hosts.yml` to a headless system, they will still
be forced to go through re-authentication flow unless they copy or
initialize a `config.yml` as well. This fixes respecting authentication
info from `hosts.yml` even if `config.yml` is missing.
2020-07-01 14:34:44 +02:00
wilso199
10b4c8ab26 Adding config set example for vscode to docs 2020-06-30 18:17:05 -04:00
Mislav Marohnić
1ca3d171e6 Tweak HTTP 422 handling when deleting branches 2020-06-30 19:21:39 +02:00
Mislav Marohnić
db88ac4155 Declare -R, --repo flag on all issue and pr subcommands 2020-06-30 18:51:53 +02:00
Mislav Marohnić
15126a71c9 Merge remote-tracking branch 'origin' into remove-global-repo-flag-for-real-this-time 2020-06-30 17:39:45 +02:00
AliabbasMerchant
7a04bf1672 api --silent Changes:
Show Response Headers (if requested) even with `--silent` flag
Shift silent tests to `Test_apiRun`
Changed usage string of `--silent` flag
2020-06-30 19:18:28 +05:30
Mislav Marohnić
6ac61e90b7 Merge remote-tracking branch 'origin' into add_filters_issues 2020-06-30 14:24:30 +02:00
Mislav Marohnić
757bd05c7a 💅 tweaks for mention/milestone filter 2020-06-30 14:24:01 +02:00
AliabbasMerchant
aa43c55f60 Skip printing headers when --silent in api 2020-06-29 07:13:06 +05:30
AliabbasMerchant
5e56e31384 Added Test for --silent flag in api 2020-06-29 00:30:24 +05:30
AliabbasMerchant
cb2308c077 --silent flag in api 2020-06-29 00:15:34 +05:30
Pavel Borzenkov
3afec6f90a api: gracefully handle already deleted remote refs
If a GitHub repo is configured to automatically delete branches after PR
is merged, `gh pr merge` fails with error like:

failed to delete remote branch: ... (422): 'Reference does not exist'

Gracefully handle such case and don't report the error.

Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
2020-06-27 19:10:42 +03:00
Pavel Borzenkov
c66eebc6fb api: return structured error for failed API calls
`fmt.Errorf` hides information and makes it hard to test for specific
conditions in returned error. Return a structured error instead.

Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
2020-06-27 18:47:34 +03:00
Pavel Borzenkov
aa8f8e8904 httpmock: propagate original HTTP request to HTTP response
So that it's possible to access it in mocked HTTP tests.

Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
2020-06-27 18:47:06 +03:00
Mislav Marohnić
15a7ab6b92
Merge pull request #1187 from gabgodBB/Disabling_color_for_output_file
Issue #930 - Removing color for output files
2020-06-24 17:18:22 +02:00
Mislav Marohnić
ab903bdfc0
Merge pull request #1155 from metalogical/FIX-detached-head
fix regression in support for detached HEAD state
2020-06-24 17:01:22 +02:00
Nate Smith
9c804907db
Merge pull request #1252 from cli/pr-checkout-maintainercanmodify
Fix `pr checkout OWNER:BRANCH` when maintainer can modify
2020-06-23 16:47:05 -05:00
Mislav Marohnić
657e633238
Merge pull request #1222 from cli/api-pagination
Add `api --paginate` option
2020-06-23 19:01:16 +02:00
Mislav Marohnić
c945fb4336 Automatically add per_page=100 to paginated REST requests
Most endpoints respect this parameter by default. Those that don't will
just ignore it. The `per_page=100` parameter is not added if there is
already a `per_page` parameter specified in the request.
2020-06-23 18:42:57 +02:00
Corey Johnson
6d70f31b66
Merge pull request #994 from AliabbasMerchant/fix-incorrect-docs
Fix incorrect docs in Issue&PR create
2020-06-23 09:38:08 -04:00
Corey Johnson
625b673b58 Ignore repo flag errors in determineBaseRepo 2020-06-22 15:30:22 -04:00