Commit graph

3920 commits

Author SHA1 Message Date
Mislav Marohnić
25b6eecc8d
Merge pull request #4017 from despreston/des/avoid-migrate
Skip auto migrate of config when GH_CONFIG_DIR
2021-07-20 13:33:16 +02:00
Des Preston
1c9b4bf99d Skip auto migrate of config when GH_CONFIG_DIR
If GH_CONFIG_DIR is set, don't auto migrate the config file. This fixes
the situation where the path given via GH_CONFIG_DIR does not exist and
the cli attempts to migrate an existing config to that location.

Fixes #3837
2021-07-19 16:33:51 -04:00
Sam
97a52f74cd
Merge pull request #3933 from cli/extensions-upgrade
Skip trying to upgrade local extensions
2021-07-19 10:55:16 -07:00
Sam Coe
b71735d0d7
Address PR comments 2021-07-19 10:48:09 -07:00
Mislav Marohnić
496b70ac0e
Merge pull request #3934 from cli/extensions-remove-notice
Add confirmation to extensions remove
2021-07-16 15:18:38 +02:00
Mislav Marohnić
882f6d33cb Merge remote-tracking branch 'origin' into extensions-remove-notice 2021-07-16 15:12:56 +02:00
Mislav Marohnić
d68df4a9d8 Do not output error messages for nontty 2021-07-16 15:10:36 +02:00
Mislav Marohnić
30beb67cb3
Merge pull request #3941 from cli/extension-install-check
Extension install check
2021-07-16 14:58:52 +02:00
Mislav Marohnić
d6b0749ea2 Tweak error messages and add more tests for extension install name check 2021-07-16 14:52:05 +02:00
Nate Smith
4d9867243c
Merge pull request #3911 from cli/fix-extensions-panic
Fix issue in FindEntry that causes extensions and alias crash
2021-07-15 11:27:10 -05:00
Sam
6d0fb9b473
Merge pull request #3926 from chemotaxis/update-goreleaser-20210630
Update GoReleaser to `v0.172.1`
2021-07-15 08:12:16 -07:00
Mislav Marohnić
aed8966f75
Merge pull request #3995 from despreston/3989-fix-pr-create-confirm
fix repo create --confirm
2021-07-14 17:26:15 +02:00
Des Preston
17b58bf0b2 fix repo create --confirm
Respect the --confirm flag when deciding whether to prompt for gitignore
and license creation during `repo create`

Fixes #3989
2021-07-14 09:59:04 -04:00
Nate Smith
161de77fd7
Merge pull request #3943 from silby/browse-output
Add a no-browser mode to gh browse
2021-07-12 13:39:30 -05:00
nate smith
98d3b7cc79 don't check Fprintf error
we don't ever check the return of Fprintf anywhere else in the codebase
so doing it here suggests that it's a special case. if it's something we
should be doing we can circle back and do it more consistently.
2021-07-12 13:05:49 -05:00
Nate Smith
6c7bff2524
Merge pull request #3912 from bchadwic/trunk
Added colors to issue / pr labels in the terminal
2021-07-12 12:46:01 -05:00
Mislav Marohnić
cd3df4cdf9
Merge pull request #3982 from despreston/des/err-return
Return SilentError if completed run failed
2021-07-12 17:05:41 +02:00
Mislav Marohnić
13037226c2 Add test for gh run watch --exit-status with completed runs 2021-07-12 16:58:45 +02:00
Des Preston
1980cc83b9 return SilentError if completed run failed
If `gh run watch ${ID} --exit-status` is run and "ID" is the ID of a
completed job that failed, return a SilentError. This ensures that the
program returns a non-zero code.

Fixes #3962
2021-07-09 11:54:58 -04:00
bchadwic
47314a6bbc modified HexToRGB to check whether terminal and gh have color enabled, as well as created tests for HexToRGB 2021-07-03 17:09:25 -07:00
Evan Silberman
49ff0c6530 Add a no-browser mode to gh browse
For when you just want the destination URL on stdout.
2021-07-02 17:12:16 -07:00
Sam Coe
16d218508d
Fix tests 2021-07-02 13:53:26 -07:00
Sam Coe
0482e5cd9b
Disallow installing extensions with the same name 2021-07-02 13:50:15 -07:00
chemotaxis
ab675a33f3 Upgrade GoReleaser
Now that the config file is updated, upgrade from v0.169.0 to v0.172.1.
2021-07-01 18:41:13 -04:00
Sam Coe
103e18cab5
Disallow installing extensions with same name as gh command 2021-07-01 13:45:29 -07:00
Sam Coe
bc7eaf8004
Add IsLocal helper func 2021-07-01 11:19:25 -07:00
Sam Coe
86f2df1f49
Add confirmation to extensions remove 2021-07-01 10:43:41 -07:00
Sam Coe
d19c348d7a
Rework code for go 1.15 2021-07-01 10:14:29 -07:00
Sam Coe
e9a8b7f781
Skip trying to upgrade local extensions 2021-07-01 09:45:30 -07:00
chemotaxis
f82750dfe6 Update goreleaser config
`nfpms.files` is deprecated: <https://goreleaser.com/deprecations/#nfpmsfiles>

```shell
goreleaser version 0.172.1
commit: 32a44ab928879bb32c1e266b80de32e07d5d6721
```

Before this commit, `goreleaser check` prints this:

```shell
$goreleaser check
   • loading config file       file=.goreleaser.yml
   ⨯ command failed            error=yaml: unmarshal errors:
  line 67: field files not found in type config.NFPM
```
2021-07-01 03:04:02 -04:00
Nate Smith
a6710ec506
Merge pull request #3924 from cli/rest-org-repo-bug
fix repo create in org with license/ignore
2021-06-30 16:49:34 -07:00
Nate Smith
717c91c912
Merge pull request #3922 from cli/fix-branch-protection
Fix bug where branchProtectionRule doesn't exist in enterprise 2.22
2021-06-30 15:46:33 -07:00
vilmibm
589b695bcf test for org + license/ignore 2021-06-30 17:41:39 -05:00
vilmibm
202168ee8d add nebula preview 2021-06-30 17:38:07 -05:00
vilmibm
2723a01760 fix repo generation in org with license/ignore 2021-06-30 17:21:58 -05:00
Sam Coe
e5b099b1dd
Fix bug where branchProtectionRule doesn't exist in enterprise 2.22 2021-06-30 09:47:30 -07:00
bchadwic
af2499cb69 renamed func RGB to HexToRGB 2021-06-29 22:35:23 -07:00
bchadwic
4c412bc88c Added in label rgb functionality for both prs and issues 2021-06-29 22:26:41 -07:00
Sam Coe
b514d22f1e
Fix issue in FindEntry that causes extensions and alias crash 2021-06-29 15:01:00 -07:00
vilmibm
3cc4c40dcb pin goreleaser version 2021-06-29 13:52:10 -05:00
Nate Smith
554250bc4e
Merge pull request #3779 from jgold-stripe/unix
Add ability to dial API via unix socket
2021-06-29 09:46:33 -07:00
Nate Smith
0474ba686d
Merge pull request #3773 from bchadwic/first-browse-pull
Feature/Create browse command
2021-06-29 09:17:30 -07:00
Sam
33c3fb5cdd
Merge pull request #3870 from cli/extensions-revisited
Improvements to gh extensions
2021-06-28 17:12:29 -07:00
Nate Smith
7fc0acd8a5
Merge pull request #3746 from g14a/feature/repo-with-gitignore-license
Feature/create repo with gitignore license
2021-06-28 14:57:31 -07:00
nate smith
6c984f4512 remove dead code 2021-06-28 14:36:51 -05:00
Nate Smith
c33b7d0c22
Merge pull request #3807 from camillesf/nonempty_fork_org
repo fork: check that --org is not the empty string
2021-06-28 11:16:30 -07:00
jonathan gold
666ed2f3d9 Apply value of http_unix_socket if present in config 2021-06-25 11:47:24 -07:00
jonathan gold
5f162561ac Add config handling for http_unix_socket 2021-06-25 11:47:22 -07:00
jonathan gold
fb54cae00e Add package httpunix 2021-06-25 11:26:21 -07:00
jonathan gold
fc3dec4a58 Change signature of NewHTTPClient to accomodate errors 2021-06-25 11:26:21 -07:00