Commit graph

2061 commits

Author SHA1 Message Date
vilmibm
815f461e8b more strict erroring around missing user/token 2020-04-20 12:49:46 -05:00
vilmibm
b1d5264524 do not import testing outside of a _test file 2020-04-20 12:37:52 -05:00
vilmibm
1a5bc0687e usage cleanup 2020-04-20 12:33:32 -05:00
vilmibm
bd907ec74d favor %w over %s for error wrapping 2020-04-20 12:22:12 -05:00
Nate Smith
664d250a61
Merge pull request #785 from pabs3/debian-instructions
Update Debian instructions for modern apt versions
2020-04-20 10:36:34 -05:00
vilmibm
e823ad0c6c staunch some type bleeding 2020-04-17 15:27:52 -05:00
vilmibm
a0b7f37935 clean up Config interface 2020-04-17 15:21:44 -05:00
vilmibm
a325db3051 new config infrastructure
- adds config get and config set commands
- supports arbitrary k/v strings set at top and host level
- supports writing an updated config, preserving comments
- supports mostly lazy evaluation of yaml
2020-04-17 15:17:44 -05:00
Mislav Marohnić
39c4a5bc1b Remove unnecessary nil check 2020-04-17 20:29:18 +02:00
Mislav Marohnić
d3a89b8744 Expand issue create metadata flags to pr create
- Includes support `pr create --reviewer <login>`
- Hide "Preview in browser" menu option when any metadata are set
2020-04-17 20:23:57 +02:00
Mislav Marohnić
206cff9b67
Please avoid adding installation instructions for your OS 2020-04-17 15:34:41 +02:00
Mislav Marohnić
2f02a79df0
Touch up CONTRIBUTING docs 💅 2020-04-17 15:29:12 +02:00
Mislav Marohnić
de59f6a1bf Add flags to add additional metadata to issue create
- `-a, --assignee` (accepts multiple)
- `-l, --label` (accepts multiple)
- `-p, --project` (accepts multiple)
- `-m, --milestone`
2020-04-15 18:28:52 +02:00
Mislav Marohnić
3d566dc5a6 Detect and warn about read:org OAuth scope being missing 2020-04-15 17:25:15 +02:00
Mislav Marohnić
14ce1f99a7 Ask for an additional read:org OAuth scope
This is to facilitate:
- requesting teams for review on `pr create`
- allowing `repo create ORG/REPO --team TEAM`
2020-04-15 14:28:07 +02:00
Paul Wise
a6618cf02f
Update Debian instructions for modern apt versions
apt can now install local .deb files too, with dependencies.
2020-04-15 12:41:01 +08:00
Mislav Marohnić
82bd7b97cf
Merge pull request #772 from gertd/bug/rest-204
fix api.REST(DELETE, ...) failure with "unexpected end of JSON input" error
2020-04-14 09:44:07 +02:00
Mislav Marohnić
8f3dcb3e22
Merge pull request #780 from cli/setup-go-beta
Avoid intermittent CI failures while setting up Go
2020-04-13 19:27:29 +02:00
Mislav Marohnić
26ee7baf67 💅 indent 2020-04-13 17:16:47 +02:00
Mislav Marohnić
4e393fdab4 Avoid intermittent CI failures while setting up Go
Switch to `actions/setup-go@v2-beta` which advertises better retries
around downloading the Go version
2020-04-13 17:15:59 +02:00
Mislav Marohnić
609beb5596
Merge pull request #778 from cli/bump-spinner
Avoid race conditions when interacting with the spinner
2020-04-13 16:57:03 +02:00
Mislav Marohnić
ea9f89f366 go mod tidy 2020-04-13 16:53:46 +02:00
Mislav Marohnić
3fdae05bcf
Merge pull request #779 from cli/composite-literals-lint
Appease linter that warns about redundant type in composite literals
2020-04-13 16:52:53 +02:00
Mislav Marohnić
f09994dd84 Appease linter that warns about redundant type in composite literals 2020-04-13 15:15:41 +02:00
Mislav Marohnić
aa183d7408 Set spinner writer stream in a preferred way 2020-04-13 14:09:56 +02:00
Mislav Marohnić
0bc631179b Update spinner library to avoid race condition after Stop() 2020-04-13 14:07:16 +02:00
Toshiya Doi
502f6709af Extract the reviewerstate formatter into a function 2020-04-11 15:03:43 +09:00
Toshiya Doi
fe27c842bb Fix slice initialization with provided capacity 2020-04-11 15:03:34 +09:00
gertd
203525c031 pr bug/rest-204 review feedback 2020-04-10 16:48:11 -07:00
Billy Griffin
971e658b63
Merge pull request #771 from cli/contributers-gonna-contribute
Update contributing doc to reflect something closer to reality
2020-04-10 08:46:05 -06:00
gertd
b9f1b5dac1 fix api.REST(DELETE, ...) json.Unmarshal failure 2020-04-09 22:19:28 -07:00
Nate Smith
c670049ce7
Merge pull request #745 from doi-t/add-metadata-to-view
Add relevant metadata to issue view in CLI
2020-04-09 16:27:07 -05:00
Toshiya Doi
fbff7226ac Add comments on review state values 2020-04-10 04:51:42 +09:00
Toshiya Doi
2df5281f2f Merge branch 'master' into reviewers-in-pr-view 2020-04-10 04:46:05 +09:00
Billy Griffin
8518b8255a
Update contributing to reflect something closer to reality 2020-04-09 13:40:03 -06:00
Mislav Marohnić
d14b5d3e2c
Merge pull request #764 from cli/pr-view-docs
Improve `issue/pr/repo view` documentation
2020-04-09 19:12:34 +02:00
Nate Smith
3c335104c5
Merge pull request #748 from doi-t/add-pr-metadata-to-view
Add relevant metadata to pr view in CLI
2020-04-09 12:12:18 -05:00
Mislav Marohnić
7f9aef6c0d
Merge pull request #761 from cli/completion-fixes
Improve `completion` command
2020-04-09 19:10:36 +02:00
Toshiya Doi
6223a2c198 Puts completed reviews before review requests and sort reviewer names alphabetically 2020-04-10 01:16:43 +09:00
Toshiya Doi
6d0e5bf2b8 Remove Participants related codes for pr view` 2020-04-10 01:02:51 +09:00
Toshiya Doi
054ec3c635 Remove Participants related codes 2020-04-10 00:56:45 +09:00
Toshiya Doi
531bfbc295 Update unit tests for PR metadata 2020-04-08 20:07:19 +09:00
Mislav Marohnić
a6495a8c0d
Merge pull request #733 from michaelld/add_MP_to_readme
add MacPorts usage info
2020-04-08 12:27:30 +02:00
Mislav Marohnić
60e7bb6243
Tweak macOS installation docs 2020-04-08 12:26:15 +02:00
Mislav Marohnić
d1754b2bb0 Improve issue/pr/repo view documentation
- Short-form docs for `pr/repo view` no longer say "in browser"

- Long-form docs for all these commands now list more information about
  what will be displayed in the terminal, plus stressing out the
  alternate behavior with the `--web` flag.

- `--web` flag docs: add English articles
2020-04-08 12:04:39 +02:00
Toshiya Doi
5c261e2318 Give a color to reviewer states 2020-04-08 16:27:30 +09:00
Toshiya Doi
bc42228171 Parses Reviews and ReviewRequests to show reviewers and their state 2020-04-08 16:27:30 +09:00
Toshiya Doi
cef525a0a2 Update unit tests for PR metadata 2020-04-08 16:27:10 +09:00
Toshiya Doi
d07617817d Query first 100 issue metadata by PR number and branch (3 --> 100) 2020-04-08 14:53:55 +09:00
Toshiya Doi
542314a9c3 Omit participants metadata from pr view 2020-04-08 14:53:23 +09:00