Commit graph

2227 commits

Author SHA1 Message Date
Nate Smith
2aa0f817ef
Merge pull request #1583 from cli/oauth-device-fallback-fix
Handle "unauthorized_client" HTTP 400 error when doing Device Flow
2020-08-27 10:49:14 -05:00
Mislav Marohnić
1c0f83ffd5 Handle "unauthorized_client" HTTP 400 error when doing Device Flow
The "unauthorized_client" error means that OAuth Device Flow is implemented, but either isn't enabled on this GHES instance, or that it isn't enabled for this particular OAuth app. In these cases we fall back to old OAuth app authorization flow.
2020-08-27 14:10:16 +02:00
Nate Smith
f1ea794bf1
Merge pull request #1580 from dan1elhughes/feature/number-url-scriptable-output
Number and URL included in scriptable output
2020-08-26 16:41:53 -05:00
Dan Hughes
7b8d052f0e
Add new output to existing test 2020-08-26 17:31:13 +01:00
Dan Hughes
a3aea11e5b
Include URL and number in non-TTY output 2020-08-26 17:28:17 +01:00
Nate Smith
727b726667
Merge pull request #1579 from cli/stderr-color-windows
Enable color ANSI escape sequences on stderr on Windows
2020-08-26 10:37:42 -05:00
Mislav Marohnić
ac0b49dc00 Enable color ANSI escape sequences on stderr on Windows 2020-08-26 16:47:08 +02:00
Nate Smith
27c49279b3
Merge pull request #1567 from ganboonhong/view-without-username
View repositories without username
2020-08-25 13:57:42 -05:00
Nate Smith
e8c4b301d3
Merge pull request #1522 from cli/oauth-device-flow
Implement OAuth Device Authorization flow
2020-08-25 13:54:07 -05:00
Nate Smith
fc1c800042
Merge pull request #1492 from ShubhankarKG/newConfirmations
New confirmations
2020-08-25 13:31:47 -05:00
Nate Smith
82c6830849
Merge pull request #1548 from cli/auth-check
new auth flow UX
2020-08-25 10:16:23 -05:00
vilmibm
451ece198b missed a disable auth check 2020-08-25 10:10:16 -05:00
vilmibm
2850ef0e17 forgot to run goimports 2020-08-24 13:32:20 -05:00
vilmibm
f3d1f9e56e no ascii art 2020-08-24 13:29:51 -05:00
boonhong
931fee566e shorthand of view without username 2020-08-23 23:33:50 +08:00
ShubhankarKG
7955c4f2ed doSetup wasn't getting called in cases where required.
The problem was that opts.confirmSubmit was mutated before reaching doSetup. This commit creates a copy of the initial confirmSubmit value. So the doSetup receives the initial data passed from the command, not the mutated one.
2020-08-20 14:20:55 +05:30
ShubhankarKG
00b2777a14 Change visibility strings to Sentence case 2020-08-20 14:10:18 +05:30
Nate Smith
b9292f582f
Merge pull request #1476 from rimazk123/prclose-delete
Add delete branch flag to pr close
2020-08-19 21:11:48 -05:00
vilmibm
e44eb665a1 Merge remote-tracking branch 'origin/trunk' into prclose-delete 2020-08-19 21:06:04 -05:00
Nate Smith
ddfa1714d2
Merge pull request #1479 from wilso199/pr-checkout-submodules
PR Checkout - Recurse Submodules
2020-08-19 16:46:21 -05:00
vilmibm
16f69e9c12 fix tests 2020-08-19 16:40:13 -05:00
vilmibm
5c4f93ad0a Merge remote-tracking branch 'origin/trunk' into pr-checkout-submodules 2020-08-19 16:37:01 -05:00
Nate Smith
88b5a3b2f4
Merge pull request #1534 from mmontes11/pr-diff-use-default-pager
Using default pager in gh pr diff
2020-08-19 12:40:33 -05:00
Nate Smith
e441ea65c0
Merge pull request #1462 from fsmiamoto/fix-milestone
Fix `--milestone` flag on `issues list` command
2020-08-19 12:39:51 -05:00
vilmibm
2753f6fa48 Merge remote-tracking branch 'origin/trunk' into fix-milestone 2020-08-19 12:31:32 -05:00
vilmibm
6408ae111c oops 2020-08-19 11:37:05 -05:00
vilmibm
b08255a720 bonus: GitHub Enterprise Server wording 2020-08-19 10:32:00 -05:00
vilmibm
cba401deb0 check parent annotatiosn for auth skip 2020-08-19 10:21:19 -05:00
vilmibm
9975cbf291 whitespace 2020-08-19 10:16:13 -05:00
vilmibm
919fb02f34 s/one/day/ 2020-08-19 10:15:04 -05:00
vilmibm
621f6a262b minor 2020-08-19 10:11:16 -05:00
vilmibm
c02b396971 do not print ascii art for narrow terminal 2020-08-19 10:11:06 -05:00
vilmibm
3ef5687070 avoid nil cmd 2020-08-19 10:10:49 -05:00
vilmibm
0d48e8de59 linter appeasement 2020-08-18 18:03:48 -05:00
vilmibm
bf3585c30b notice 401 errors and provide hint 2020-08-18 17:57:52 -05:00
vilmibm
b1a6346e07 take out auto browser flow 2020-08-18 17:57:52 -05:00
vilmibm
231ed71e7f TODOs 2020-08-18 17:57:52 -05:00
vilmibm
ff9ecd2944 CTA for ghes remote auth case 2020-08-18 17:57:52 -05:00
vilmibm
850a7ef243 print nice login message when no auth detected 2020-08-18 17:57:52 -05:00
ShubhankarKG
130c5262b2 Refactor changes 2020-08-18 16:23:16 +05:30
ShubhankarKG
2b6535f951 Merge branch 'trunk' of https://github.com/cli/cli into newConfirmations 2020-08-18 11:25:43 +05:30
Martín Montes
df66a8f131 Using default pager in gh pr diff 2020-08-17 22:31:30 +02:00
Mislav Marohnić
0cc59488a8
Merge pull request #1536 from kcubeterm/patch-1
Add installation step for android termux.
2020-08-17 12:38:28 +02:00
Mislav Marohnić
746e7c21a3
💅 Install docs tweaks 2020-08-17 12:37:16 +02:00
Mislav Marohnić
5534c3e302
Merge pull request #1535 from royling/fix-pr-diff
Fix  `gh pr diff` with hostname override
2020-08-17 11:47:08 +02:00
Krishna Kanhaiya
fde470f9c5
Add installation step for android termux. 2020-08-15 19:40:52 +05:30
Roy Ling
006426331c Fix gh pr diff with hostname override
Removed hardcoded url prefix in PR diff
2020-08-15 22:03:42 +08:00
Mislav Marohnić
d8c5b7bfc0
Merge pull request #1517 from cli/select-host
Allow explicitly setting hostname for gh operations
2020-08-14 19:08:13 +02:00
Mislav Marohnić
85f0f3aad7 Enable repo create for GHE 2020-08-14 19:02:17 +02:00
Mislav Marohnić
a6776d0ba2 Allow more HTTP 40x codes to trigger fallback to old OAuth flow
I want to avoid falling back to the old OAuth flow for just any HTTP
4xx/5xx because other statuses should be allowed to surface a problem
with a request or the server.
2020-08-14 17:31:23 +02:00