Zach Steindler
2b293c4840
Add unit test, update naming, ensure DSSE envelope is in-toto
...
Signed-off-by: Zach Steindler <steiza@github.com>
2024-04-10 09:49:34 -04:00
Zach Steindler
c96fb7c553
Updates from linter feedback
...
Signed-off-by: Zach Steindler <steiza@github.com>
2024-04-09 17:34:45 -04:00
Zach Steindler
643f4031b2
Add support to attestation command for more predicate types.
...
Before, we required all attestations have predicateType
https://slsa.dev/provenance/v1 . This allows you to use other predicate
types, and adds the ability to filter responses from the API for a
particular predicate type.
Signed-off-by: Zach Steindler <steiza@github.com>
2024-04-09 17:26:32 -04:00
William Martin
a76230454a
Merge pull request #8945 from cli/wm/you-didnt-see-nothin
...
Close zip file in run view tests
2024-04-08 17:02:09 +02:00
William Martin
61584b83cb
Close zip file in run view tests
2024-04-08 16:50:43 +02:00
William Martin
3ba976a3a4
Merge pull request #8944 from cli/wm/ensure-run-log-cache-creates-cache-dir
...
Ensure run log cache creates cache dir if it doesn't exist
2024-04-08 16:02:21 +02:00
William Martin
bbeccd69ad
Ensure run log cache creates cache dir if it doesn't exist
2024-04-08 15:51:29 +02:00
William Martin
3be7a02fec
Merge pull request #8932 from cli/wm/fix-api-cache-test
...
Fix api cache test
2024-04-05 17:10:20 +02:00
William Martin
9738d68bba
Fix api cache test
2024-04-05 16:47:29 +02:00
William Martin
3aa3d61108
Merge pull request #8929 from cli/wm/parse-url-no-nakaed-return
...
Remove naked returns from git ParseURL
2024-04-05 16:33:09 +02:00
William Martin
b0b147e60c
Use testify in git url tests
2024-04-05 16:07:04 +02:00
William Martin
b6239238c8
Merge pull request #8931 from cli/wm/run-log-cache-stronger-abstraction
...
Create stronger run log cache abstraction
2024-04-05 16:00:28 +02:00
William Martin
c2aee1e402
Ensure cache dir is always available in RunLogCache
2024-04-05 15:39:33 +02:00
William Martin
103586a94c
Remove RunLogCache interface
2024-04-05 15:33:49 +02:00
William Martin
a3ffc1ca33
Use real Run Log Cache in run view tests
2024-04-05 15:18:18 +02:00
William Martin
e644dc50d6
Capture error on Run Log Cache Exists
2024-04-05 15:16:12 +02:00
Andy Feller
b0a3975948
Merge pull request #8882 from zdrve/zdrve/job-name-prefix
...
Anchor the log filename to the start
2024-04-05 09:11:50 -04:00
William Martin
a89d50fc63
Rework Run Log Cache so that cache dir is injected
2024-04-05 14:59:24 +02:00
William Martin
f808dcee62
Expose CacheDir on Config
2024-04-05 14:58:12 +02:00
Andy Feller
0a2ede0279
Merge pull request #8837 from t4kamura/fix-cannot-lock-pr-url
...
Fixed `gh pr lock/unlock` not working when URL is passed
2024-04-05 08:29:35 -04:00
Andy Feller
1540a37fee
Merge branch 'trunk' into fix-cannot-lock-pr-url
2024-04-05 08:13:44 -04:00
William Martin
1b57b0f917
Minorly refactor scheme normalization in git ParseURL
2024-04-05 12:29:27 +02:00
William Martin
2c2a09c73e
Test for parsing error in git ParseURL
2024-04-05 12:25:24 +02:00
William Martin
27f3d62d02
Remove naked returns from git ParseURL
2024-04-05 12:23:47 +02:00
Babak K. Shandiz
47efef6d70
Fix parsing IPv6 remote URLs ( #8893 )
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-04-05 11:54:55 +02:00
Meredith Lancaster
2c53d7c9a8
Add codeowners entry for the GitHub TUF root included in the attestation command set ( #8919 )
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-04-05 09:41:34 +02:00
William Martin
6cb85d54cc
Merge pull request #8925 from cli/dependabot/go_modules/google.golang.org/grpc-1.61.2
...
build(deps): bump google.golang.org/grpc from 1.61.1 to 1.61.2
2024-04-04 16:58:09 +02:00
dependabot[bot]
dd0a827ce5
build(deps): bump google.golang.org/grpc from 1.61.1 to 1.61.2
...
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go ) from 1.61.1 to 1.61.2.
- [Release notes](https://github.com/grpc/grpc-go/releases )
- [Commits](https://github.com/grpc/grpc-go/compare/v1.61.1...v1.61.2 )
---
updated-dependencies:
- dependency-name: google.golang.org/grpc
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-04-04 14:38:42 +00:00
William Martin
ca39101b3e
Merge pull request #8906 from babakks/8675-fix-repo-rename-panic
...
Fix panic when running `gh repo rename`
2024-04-04 14:59:55 +02:00
Babak K. Shandiz
642b2c57c1
Add tests for FindByRepo
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-04-04 00:19:15 +01:00
William Martin
9744489510
Merge pull request #8920 from cli/wm/bump-glam-glam
2024-04-03 18:45:08 +02:00
William Martin
32882db3e2
Bump go-gh to v2.8.0 and go mod tidy
2024-04-03 17:12:06 +02:00
William Martin
18d37e2940
Merge pull request #8923 from cli/dependabot/go_modules/github.com/sigstore/protobuf-specs-0.3.1
...
build(deps): bump github.com/sigstore/protobuf-specs from 0.3.0 to 0.3.1
2024-04-03 16:35:06 +02:00
dependabot[bot]
eb24a5b241
build(deps): bump github.com/sigstore/protobuf-specs from 0.3.0 to 0.3.1
...
Bumps [github.com/sigstore/protobuf-specs](https://github.com/sigstore/protobuf-specs ) from 0.3.0 to 0.3.1.
- [Release notes](https://github.com/sigstore/protobuf-specs/releases )
- [Changelog](https://github.com/sigstore/protobuf-specs/blob/main/CHANGELOG.md )
- [Commits](https://github.com/sigstore/protobuf-specs/compare/v0.3.0...v0.3.1 )
---
updated-dependencies:
- dependency-name: github.com/sigstore/protobuf-specs
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-04-03 14:20:03 +00:00
Babak K. Shandiz
72fcd8c87d
Improve error message returned by FindByRepo
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-04-02 21:46:28 +01:00
William Martin
83f200d91f
Bump glamour to v0.7.0 and go mod tidy
2024-04-02 20:08:19 +02:00
William Martin
28c5e1b503
Merge pull request #8914 from cli/dependabot/go_modules/github.com/google/go-containerregistry-0.19.1
...
build(deps): bump github.com/google/go-containerregistry from 0.19.0 to 0.19.1
2024-04-02 17:43:10 +02:00
dependabot[bot]
47f190f2b5
build(deps): bump github.com/google/go-containerregistry
...
Bumps [github.com/google/go-containerregistry](https://github.com/google/go-containerregistry ) from 0.19.0 to 0.19.1.
- [Release notes](https://github.com/google/go-containerregistry/releases )
- [Changelog](https://github.com/google/go-containerregistry/blob/main/.goreleaser.yml )
- [Commits](https://github.com/google/go-containerregistry/compare/v0.19.0...v0.19.1 )
---
updated-dependencies:
- dependency-name: github.com/google/go-containerregistry
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-04-02 15:30:53 +00:00
William Martin
5150eb0001
Merge pull request #8913 from cli/dependabot/go_modules/github.com/gorilla/websocket-1.5.1
...
build(deps): bump github.com/gorilla/websocket from 1.5.0 to 1.5.1
2024-04-02 17:29:55 +02:00
William Martin
7b4d74b66d
Merge pull request #8912 from cli/dependabot/go_modules/google.golang.org/grpc-1.61.1
...
build(deps): bump google.golang.org/grpc from 1.61.0 to 1.61.1
2024-04-02 17:22:03 +02:00
William Martin
96a75139f8
Merge pull request #8888 from satoqz/trunk
...
Fix segfault in error handling of `gh repo rename`
2024-04-02 16:28:09 +02:00
dependabot[bot]
f66b2fc6eb
build(deps): bump github.com/gorilla/websocket from 1.5.0 to 1.5.1
...
Bumps [github.com/gorilla/websocket](https://github.com/gorilla/websocket ) from 1.5.0 to 1.5.1.
- [Release notes](https://github.com/gorilla/websocket/releases )
- [Commits](https://github.com/gorilla/websocket/compare/v1.5.0...v1.5.1 )
---
updated-dependencies:
- dependency-name: github.com/gorilla/websocket
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-04-02 14:11:31 +00:00
dependabot[bot]
228c31f205
build(deps): bump google.golang.org/grpc from 1.61.0 to 1.61.1
...
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go ) from 1.61.0 to 1.61.1.
- [Release notes](https://github.com/grpc/grpc-go/releases )
- [Commits](https://github.com/grpc/grpc-go/compare/v1.61.0...v1.61.1 )
---
updated-dependencies:
- dependency-name: google.golang.org/grpc
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-04-02 14:11:27 +00:00
William Martin
4ea4ed85ec
Merge pull request #8903 from cli/dependabot/go_modules/github.com/docker/docker-24.0.9incompatible
...
build(deps): bump github.com/docker/docker from 24.0.7+incompatible to 24.0.9+incompatible
2024-04-02 15:46:09 +02:00
William Martin
504f73613f
Merge pull request #8902 from cli/dependabot/go_modules/gopkg.in/go-jose/go-jose.v2-2.6.3
...
build(deps): bump gopkg.in/go-jose/go-jose.v2 from 2.6.1 to 2.6.3
2024-04-02 15:44:16 +02:00
William Martin
200c95e5b2
Rely on go.mod go version in all workflows ( #8911 )
2024-04-02 13:22:31 +00:00
Naoya Yasuda
5d79a95a32
Upgrade to Go 1.22 ( #8836 )
2024-04-02 14:34:59 +02:00
dependabot[bot]
82254f7d49
build(deps): bump github.com/docker/docker
...
Bumps [github.com/docker/docker](https://github.com/docker/docker ) from 24.0.7+incompatible to 24.0.9+incompatible.
- [Release notes](https://github.com/docker/docker/releases )
- [Commits](https://github.com/docker/docker/compare/v24.0.7...v24.0.9 )
---
updated-dependencies:
- dependency-name: github.com/docker/docker
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-04-01 17:15:19 +00:00
dependabot[bot]
acb5b9bd42
build(deps): bump gopkg.in/go-jose/go-jose.v2 from 2.6.1 to 2.6.3
...
Bumps gopkg.in/go-jose/go-jose.v2 from 2.6.1 to 2.6.3.
---
updated-dependencies:
- dependency-name: gopkg.in/go-jose/go-jose.v2
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-04-01 17:14:59 +00:00
Meredith Lancaster
90b7bf97c5
gh-attestation cmd integration ( #8698 )
...
* add attestation cmd
Signed-off-by: Meredith Lancaster <malancas@github.com>
* add codeowners
Signed-off-by: Meredith Lancaster <malancas@github.com>
* update args passed to the attestation cmd
Signed-off-by: Meredith Lancaster <malancas@github.com>
* rename file
Signed-off-by: Meredith Lancaster <malancas@github.com>
* use gh-attestation branch for passing iostreams from the root
Signed-off-by: Meredith Lancaster <malancas@github.com>
* add package security team entry to codeowners
Signed-off-by: Meredith Lancaster <malancas@github.com>
* start moving over verify cmd and general verification code
Signed-off-by: Meredith Lancaster <malancas@github.com>
* clean up common and verify specific policy code
Signed-off-by: Meredith Lancaster <malancas@github.com>
* move artifact package over
Signed-off-by: Meredith Lancaster <malancas@github.com>
* start pulling in the github api client wrapper
Signed-off-by: Meredith Lancaster <malancas@github.com>
* fix imports
Signed-off-by: Meredith Lancaster <malancas@github.com>
* add logger and test packages
Signed-off-by: Meredith Lancaster <malancas@github.com>
* add additional packages to support verify command
Signed-off-by: Meredith Lancaster <malancas@github.com>
* fix mock api client
Signed-off-by: Meredith Lancaster <malancas@github.com>
* clean up mock api client
Signed-off-by: Meredith Lancaster <malancas@github.com>
* include missing fields
Signed-off-by: Meredith Lancaster <malancas@github.com>
* use correct owner
Signed-off-by: Meredith Lancaster <malancas@github.com>
* add more mock api client options
Signed-off-by: Meredith Lancaster <malancas@github.com>
* add download cmd
Signed-off-by: Meredith Lancaster <malancas@github.com>
* add inspect cmd
Signed-off-by: Meredith Lancaster <malancas@github.com>
* pass factory object to inspect cmd, add inspect sub cmd to attestation cmd
Signed-off-by: Meredith Lancaster <malancas@github.com>
* add verify-tuf-root cmd
Signed-off-by: Meredith Lancaster <malancas@github.com>
* pass iostream struct from command
Signed-off-by: Meredith Lancaster <malancas@github.com>
* rename logger pkg to logger
Signed-off-by: Meredith Lancaster <malancas@github.com>
* fix path in codeowners
Signed-off-by: Meredith Lancaster <malancas@github.com>
* formatter
Signed-off-by: Meredith Lancaster <malancas@github.com>
* go mod tidy
Signed-off-by: Meredith Lancaster <malancas@github.com>
* fix printf linter issue
Signed-off-by: Meredith Lancaster <malancas@github.com>
* fix printf linter issue
Signed-off-by: Meredith Lancaster <malancas@github.com>
* check user's GH host for compatibility
Signed-off-by: Meredith Lancaster <malancas@github.com>
* pass oci client to commands directly
Signed-off-by: Meredith Lancaster <malancas@github.com>
* rename command
Signed-off-by: Meredith Lancaster <malancas@github.com>
* mark tuf-root-verify cmd hidden
Signed-off-by: Meredith Lancaster <malancas@github.com>
* move client initialization back to subcommands
Signed-off-by: Meredith Lancaster <malancas@github.com>
* add more verbose options and logging
Signed-off-by: Meredith Lancaster <malancas@github.com>
* add missing logger
Signed-off-by: Meredith Lancaster <malancas@github.com>
* add testing around OCI and API client
Signed-off-by: Meredith Lancaster <malancas@github.com>
* add integration test
Signed-off-by: Meredith Lancaster <malancas@github.com>
* fix file path
Signed-off-by: Meredith Lancaster <malancas@github.com>
* fix command
Signed-off-by: Meredith Lancaster <malancas@github.com>
* build executable before integration test
Signed-off-by: Meredith Lancaster <malancas@github.com>
* split integration tests
Signed-off-by: Meredith Lancaster <malancas@github.com>
* remove integration test steps
Signed-off-by: Meredith Lancaster <malancas@github.com>
* fix flag value
Signed-off-by: Meredith Lancaster <malancas@github.com>
* run integration tests on ubuntu for now
Signed-off-by: Meredith Lancaster <malancas@github.com>
* pull over doc updates
Signed-off-by: Meredith Lancaster <malancas@github.com>
* delete unused test data
Signed-off-by: Meredith Lancaster <malancas@github.com>
* remove Go patch version
Signed-off-by: Meredith Lancaster <malancas@github.com>
* switch assert to require
Signed-off-by: Meredith Lancaster <malancas@github.com>
* rename file
Signed-off-by: Meredith Lancaster <malancas@github.com>
* move integration tests to prexisting test workflow
Signed-off-by: Meredith Lancaster <malancas@github.com>
* use platform matrix for integration tests
Signed-off-by: Meredith Lancaster <malancas@github.com>
* simplify build step
Signed-off-by: Meredith Lancaster <malancas@github.com>
* use StringEnumFlag handling
Signed-off-by: Meredith Lancaster <malancas@github.com>
* typo
Signed-off-by: Meredith Lancaster <malancas@github.com>
* use the iostreams.Test helper func
Signed-off-by: Meredith Lancaster <malancas@github.com>
* create interface for oci client
Signed-off-by: Meredith Lancaster <malancas@github.com>
* add tests for oci client
Signed-off-by: Meredith Lancaster <malancas@github.com>
* rename files
Signed-off-by: Meredith Lancaster <malancas@github.com>
* format file
Signed-off-by: Meredith Lancaster <malancas@github.com>
* fix shellcheck issues
Signed-off-by: Meredith Lancaster <malancas@github.com>
* use testing TempDir method
Signed-off-by: Meredith Lancaster <malancas@github.com>
* cleanup unused tempdir handling
Signed-off-by: Meredith Lancaster <malancas@github.com>
* use table driven tests
Signed-off-by: Meredith Lancaster <malancas@github.com>
* check correct cmd
Signed-off-by: Meredith Lancaster <malancas@github.com>
* support repo option in download sub cmd
Signed-off-by: Meredith Lancaster <malancas@github.com>
* switch over to using RunE
Signed-off-by: Meredith Lancaster <malancas@github.com>
* unexport top level subcommand funcs
Signed-off-by: Meredith Lancaster <malancas@github.com>
* add comment around keychain option
Signed-off-by: Meredith Lancaster <malancas@github.com>
* update comments
Signed-off-by: Meredith Lancaster <malancas@github.com>
* fix inconsistent naming
Signed-off-by: Meredith Lancaster <malancas@github.com>
* add tests for CLI commands
Signed-off-by: Meredith Lancaster <malancas@github.com>
* check for noattestationsfound err
Signed-off-by: Meredith Lancaster <malancas@github.com>
* try out metadata abstraction instead
Signed-off-by: Meredith Lancaster <malancas@github.com>
* switch to using MetadataStore abstraction
Signed-off-by: Meredith Lancaster <malancas@github.com>
* include test case with failing metadata store
Signed-off-by: Meredith Lancaster <malancas@github.com>
* look for err specific to file write
Signed-off-by: Meredith Lancaster <malancas@github.com>
* unexport fields
Signed-off-by: Meredith Lancaster <malancas@github.com>
* return err when an unsupported hash alg is provided
Signed-off-by: Meredith Lancaster <malancas@github.com>
* PrintTableToStdOut returns err when rendering fails
Signed-off-by: Meredith Lancaster <malancas@github.com>
* start adding sigstore verifier unit tests
Signed-off-by: Meredith Lancaster <malancas@github.com>
* add more sigstore verifier specific tests
Signed-off-by: Meredith Lancaster <malancas@github.com>
* use cli table printer
Signed-off-by: Meredith Lancaster <malancas@github.com>
* return JSON results in slice instead of table
Signed-off-by: Meredith Lancaster <malancas@github.com>
* move mock client to test file
Signed-off-by: Meredith Lancaster <malancas@github.com>
* remove unneeded table printer method
Signed-off-by: Meredith Lancaster <malancas@github.com>
* add initial tests for tufrootverify cmd
Signed-off-by: Meredith Lancaster <malancas@github.com>
* formatting
Signed-off-by: Meredith Lancaster <malancas@github.com>
* cleanup method
Signed-off-by: Meredith Lancaster <malancas@github.com>
* close file in error handling branch
Signed-off-by: Meredith Lancaster <malancas@github.com>
* normalize artifact path
Signed-off-by: Meredith Lancaster <malancas@github.com>
* remove unneeded embedded file system
Signed-off-by: Meredith Lancaster <malancas@github.com>
* include image name reference err
Signed-off-by: Meredith Lancaster <malancas@github.com>
* use GH_DEBUG value for io handling
Signed-off-by: Meredith Lancaster <malancas@github.com>
* remove quiet and verbose flags
Signed-off-by: Meredith Lancaster <malancas@github.com>
* add more tufrootveriify tests
Signed-off-by: Meredith Lancaster <malancas@github.com>
* GitHubTUFOptions no longer needs to return error
Signed-off-by: Meredith Lancaster <malancas@github.com>
* remove unneeded slice
Signed-off-by: Meredith Lancaster <malancas@github.com>
* normalize all relative paths
Signed-off-by: Meredith Lancaster <malancas@github.com>
* clean up nil client checks
Signed-off-by: Meredith Lancaster <malancas@github.com>
* set api server based on host
Signed-off-by: Meredith Lancaster <malancas@github.com>
* add comment about http client
Signed-off-by: Meredith Lancaster <malancas@github.com>
* use format flag to handle json output in verify cmd
Signed-off-by: Meredith Lancaster <malancas@github.com>
* use format flag to handle json output
Signed-off-by: Meredith Lancaster <malancas@github.com>
* use normalized path for cli test arg
Signed-off-by: Meredith Lancaster <malancas@github.com>
* add tests for json output
Signed-off-by: Meredith Lancaster <malancas@github.com>
* cleanup error wrapping
Signed-off-by: Meredith Lancaster <malancas@github.com>
* use test fixtures correctly by normalizing path
Signed-off-by: Meredith Lancaster <malancas@github.com>
* dont clean
Signed-off-by: Meredith Lancaster <malancas@github.com>
* escape backwards slash for windows files with replace
Signed-off-by: Meredith Lancaster <malancas@github.com>
* use strings.Split func
Signed-off-by: Meredith Lancaster <malancas@github.com>
* use strings.Replace for all command tests
Signed-off-by: Meredith Lancaster <malancas@github.com>
* use CLI cache dir to store tuf metadata
Signed-off-by: Meredith Lancaster <malancas@github.com>
* Tweaked docstrings for gh attestation download
* Tweaked docstrings for gh attestation verify
* Fix for bug in gh attestation where the wrong hostname was being passed to the API client.
* lets hide tuf-root-verify eh?
* Forgot verify's short str.
* add remote verification test
Signed-off-by: Meredith Lancaster <malancas@github.com>
* Revert "add remote verification test"
This reverts commit c0ceb99ca8
2024-04-01 11:13:47 -06:00
