Caleb Brose
2ca8f8b633
Merge pull request #5969 from jungaretti/jungaretti/disable-ssh-password
...
Remove misleading Codespaces ssh/copy password prompt
2022-07-20 14:33:07 -05:00
JP Ungaretti
ec9e50ff93
Always set PasswordAuthentication option
2022-07-19 16:55:14 -07:00
Nate Smith
954689ea9f
Merge pull request #5681 from heaths/issue5679
...
Use alternate screen buffer for watching runs
2022-07-14 15:03:43 -07:00
Mislav Marohnić
25756aaf88
Merge pull request #5943 from cli/uncache-http-client
...
Remove accidental caching from `repo list` and other commands
2022-07-14 19:17:23 +02:00
Mislav Marohnić
c22a85e2b5
Remove accidental caching from repo list and other commands
...
Any gh command that has invoked NewCachedHTTPClient has also
inadvertently enabled caching for the original `http.Client` due to the
nature that NewCachedHTTPClient mutates the original argument passed.
2022-07-14 19:10:32 +02:00
Nate Smith
7b7929bb6b
Merge pull request #5939 from pxeger/5934
...
Strip whitespace when adding topics
2022-07-14 09:39:51 -05:00
Patrick Reader
0cf2600725
strip whitespace when adding topics
...
closes #5934
2022-07-14 13:17:40 +01:00
Sam Coe
9d70d62520
Set blank headers so they are not automatically resolved by go-gh ( #5935 )
2022-07-14 14:13:34 +02:00
Sam Coe
e5cf302ad8
Post go-gh integration cleanup ( #5933 )
2022-07-13 14:58:50 +02:00
vilmibm
1bcf97b914
Merge remote-tracking branch 'origin' into issue5679
2022-07-12 15:40:29 -05:00
Sam Coe
1e8cb9c1b2
Fix login flow ( #5928 )
2022-07-12 15:46:35 +02:00
Taylor Faubion
11b1059237
fix gh run download <run-id> not getting > 100 artifacts ( #5799 )
...
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-07-12 11:01:38 +00:00
Mislav Marohnić
dea1af1227
pr checks: avoid deduplicating same-named checks under different workflows ( #5919 )
2022-07-12 09:48:39 +00:00
Mislav Marohnić
1037917d67
Merge pull request #5916 from cli/fork-without-rename
...
repo fork: directly fork under the desired name
2022-07-12 11:37:59 +02:00
ffalor
821f8ba1d2
Add error message to pr close when missing args ( #5885 )
2022-07-11 15:30:12 +00:00
Mark Phelps
994fbebf0a
Merge pull request #5873 from cli/fix-codespace-pending-create-panic
2022-07-11 10:05:34 -04:00
Mislav Marohnić
0f67999d52
Merge pull request #5915 from cli/pr-status-headref
...
pr status: fix detecting PR for curent branch
2022-07-11 14:00:59 +02:00
Mislav Marohnić
5656296ade
repo fork: directly fork under the desired name
...
A new GitHub feature landed where the API client can specify the desired
name of the new fork. This avoids the necessity of subsequently having
to rename the forked repo after the fork operation has created one.
For backwards compatibility, the renaming logic is still here, but
activates only if the resulting repo name is not the desired name.
2022-07-11 13:54:58 +02:00
Mislav Marohnić
04485144ea
pr status: fix detecting PR for curent branch
2022-07-11 13:16:33 +02:00
dependabot[bot]
dd8ad5c5fa
Bump github.com/gabriel-vasile/mimetype from 1.4.0 to 1.4.1 ( #5903 )
...
Bumps [github.com/gabriel-vasile/mimetype](https://github.com/gabriel-vasile/mimetype ) from 1.4.0 to 1.4.1.
- [Release notes](https://github.com/gabriel-vasile/mimetype/releases )
- [Commits](https://github.com/gabriel-vasile/mimetype/compare/v1.4.0...v1.4.1 )
---
updated-dependencies:
- dependency-name: github.com/gabriel-vasile/mimetype
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-07-11 11:00:24 +02:00
Mislav Marohnić
24798b4ee0
Merge pull request #5910 from casswedson/typo-smash
...
chore: typo hunting ft. codespell
2022-07-11 09:18:14 +02:00
casswedson
00bc550dc6
chore: typo hunting ft. codespell
2022-07-09 21:41:09 -05:00
Mark Phelps
6014b31d03
Fix case where codespace created while in provisioning state causes panic
2022-07-01 13:08:44 -04:00
Caleb Brose
604adc57ef
Merge pull request #5859 from cli/cmbrose/fix-auto-key-path
...
Use `codespaces.auto` instead for the automatic ssh keys
2022-06-29 12:35:42 -05:00
cmbrose
b2fe329011
Close files to actually fix windows
2022-06-29 12:28:21 -05:00
Caleb Brose
4eac4fbf4c
Make a new dir per test to work around windows failures
2022-06-29 11:48:23 -05:00
Caleb Brose
b5348f661e
Handle case of partial name match
2022-06-29 11:36:27 -05:00
Caleb Brose
1aa457499d
Use Fatal instead to avoid nil-ref
2022-06-29 11:27:18 -05:00
Caleb Brose
fb4ad53dd0
Check MkdirAll error
2022-06-29 11:17:24 -05:00
Caleb Brose
1bae759d3e
Don't use strings.Replace
2022-06-29 11:10:50 -05:00
Caleb Brose
77ecd0a147
Rename public key first for edge cases
2022-06-29 10:56:31 -05:00
Caleb Brose
2ac379f689
Comment
2022-06-29 10:54:07 -05:00
Caleb Brose
c5b07762d1
Check the key paths too
2022-06-29 10:51:17 -05:00
Caleb Brose
19b5400811
Handle back compat
2022-06-29 10:46:44 -05:00
Caleb Brose
0687f66208
Use codespaces.auto instead for the automatic ssh keys
2022-06-28 16:26:18 -05:00
Mark Phelps
38ea62afba
Codespaces list by repo ( #5854 )
...
* WIP
* Allow to list codespaces by repo
* Tests
* Cleanup
* respond to PR feedback
* Address review comments
2022-06-28 13:34:04 +00:00
Mislav Marohnić
8adfc9a4f2
Merge pull request #5850 from cli/dependabot/go_modules/github.com/stretchr/testify-1.7.5
...
Bump github.com/stretchr/testify from 1.7.4 to 1.7.5
2022-06-27 12:02:48 +02:00
dependabot[bot]
0ef1ba59d1
Bump github.com/stretchr/testify from 1.7.4 to 1.7.5
...
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify ) from 1.7.4 to 1.7.5.
- [Release notes](https://github.com/stretchr/testify/releases )
- [Commits](https://github.com/stretchr/testify/compare/v1.7.4...v1.7.5 )
---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-06-24 14:28:00 +00:00
Sam Coe
cacff4ad6d
Use go-gh config package ( #5771 )
2022-06-23 11:50:04 +00:00
Mislav Marohnić
5227af0c99
Merge pull request #5844 from cli/linux-keyring-perm
...
Linux installation: ensure GPG keyring is world-readable
2022-06-23 12:10:11 +02:00
Heath Stewart
1ed80ffd45
Resolve PR feedback
2022-06-23 00:53:34 -07:00
Sam Coe
074ed50b8a
Integrate go-gh API package ( #5614 )
2022-06-23 04:05:31 +01:00
Mislav Marohnić
449460ebb0
Linux installation: ensure GPG keyring is world-readable
...
This alleviates problems with umask at the time of installation.
2022-06-22 21:40:42 +02:00
Mislav Marohnić
6e3689d58b
Apply UI polish around codespaces org-admin commands ( #5843 )
2022-06-22 20:35:56 +02:00
Ashwin Jeyaseelan
47f5abdb6f
8gitbrix/add delete org codespace ( #5827 )
...
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-06-22 18:28:09 +02:00
Greggory Rothmeier
2294f49d07
Add support for org admins to stop a members codespace ( #5812 )
2022-06-22 13:56:22 +02:00
Mislav Marohnić
d76c1f352a
Merge pull request #5841 from wilhelmeek/avoid-keep-multiselect
...
clear pr create multiselect on select
2022-06-22 12:13:00 +02:00
wilhelm
0f02371734
clear pr create multiselect on select
2022-06-22 17:43:41 +10:00
Jake Shorty
5893c9864d
Merge pull request #5828 from cli/jshorty/indent-billable-owner-notice
...
Indent org billable owner notice for new codespaces
2022-06-21 09:32:27 -06:00
Jake Shorty
bb753731e6
Update test for indentation
2022-06-21 15:19:24 +00:00