Commit graph

10788 commits

Author SHA1 Message Date
Babak K. Shandiz
31f3756089
fix(workflow run): bail out on feature detection error
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2026-02-17 11:48:25 +00:00
Babak K. Shandiz
52eca96873
refactor(featuredetection): remove temp in favour of early returns
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2026-02-17 11:46:33 +00:00
Babak K. Shandiz
ce016217d0
docs(workflow run): improve help docs
Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
2026-02-16 22:49:42 +00:00
Babak K. Shandiz
c47a10e583
docs(workflow run): add cleanup marker with explanation on future changes
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2026-02-16 22:02:18 +00:00
Babak K. Shandiz
36a85fd71f
fix(workflow run): apply url.PathEscape when compiling URL
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2026-02-16 21:55:25 +00:00
Babak K. Shandiz
3e9fbbb2fa
refactor(workflow run): remove temp out
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2026-02-16 21:53:17 +00:00
Babak K. Shandiz
61ab5e0b5d
docs(featuredetection): fix typo in comment
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2026-02-16 13:07:24 +00:00
Babak K. Shandiz
b64dd58d8b
test(featuredetection): fix test case name
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2026-02-16 13:06:23 +00:00
Babak K. Shandiz
bf2ff7c39b
test(workflow run): verify retrieval of workflow run details
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2026-02-16 12:57:01 +00:00
Babak K. Shandiz
e73bf113dd
feat(workflow run): retrieve workflow run if supported by the API
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2026-02-16 12:56:01 +00:00
Babak K. Shandiz
33825477ae
test(featuredetection): add tests for ActionsFeatures
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2026-02-16 11:54:07 +00:00
Babak K. Shandiz
a0dea00fdd
fix(featuredetection): add ActionsFeatures to detect workflow dispatch features
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2026-02-16 11:53:33 +00:00
William Martin
1af2823fc3
Merge pull request #12680 from cli/wm-add-api-version
Pin REST API version to 2022-11-28
2026-02-13 19:55:27 +01:00
William Martin
166db75d36 pin REST API version to 2022-11-28
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-02-13 19:46:16 +01:00
William Martin
4e76bb0f47
Merge pull request #12679 from cli/wm-run-view-exit-status-not-respected
Respect `--exit-status` with `--log` and `--log-failed` in `run view`
2026-02-13 19:40:48 +01:00
William Martin
24964681a8 Respect --exit-status with --log and --log-failed
Fixes #12674
2026-02-13 16:04:06 +01:00
William Martin
2c54a0d36a
Merge pull request #12673 from cli/wm-explore-fork-branches-in-pr
Fork with default branch only during pr create
2026-02-13 15:50:38 +01:00
William Martin
2b5c3b5ecb document fork default branch behavior 2026-02-13 15:36:37 +01:00
William Martin
7448aed8ab fork default branch only in pr create 2026-02-12 16:56:14 +01:00
Babak K. Shandiz
4e65637471
Merge pull request #12631 from cli/kw/bump-go-is-workflow-dispatchable
Add manual dispatch to bump-go workflow
2026-02-09 12:48:34 +00:00
Kynan Ware
a2b8b687c0
Merge pull request #12629 from cli/dependabot/go_modules/golang.org/x/crypto-0.47.0
chore(deps): bump golang.org/x/crypto from 0.46.0 to 0.47.0
2026-02-06 12:31:17 -07:00
Kynan Ware
cde6edcba2 update third party licenses 2026-02-06 12:23:17 -07:00
dependabot[bot]
7fb3e1ad80
chore(deps): bump golang.org/x/crypto from 0.46.0 to 0.47.0
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.46.0 to 0.47.0.
- [Commits](https://github.com/golang/crypto/compare/v0.46.0...v0.47.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-version: 0.47.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-02-06 18:54:51 +00:00
Kynan Ware
2ad10c1c93
Merge pull request #12630 from cli/kw/bump-go-1.25.7
Bump go to 1.25.7
2026-02-06 11:53:28 -07:00
Kynan Ware
35828f44cd Add manual dispatch to bump-go workflow
Enable manual runs of the Bump Go workflow by adding the workflow_dispatch trigger alongside the existing scheduled cron. This allows maintainers to trigger the bump process on-demand while keeping the daily 3 AM UTC schedule intact.
2026-02-06 11:52:24 -07:00
Kynan Ware
18c67c9ccc bump go to 1.25.7 2026-02-06 11:44:34 -07:00
Kynan Ware
0f04a4815f
Merge pull request #12616 from cli/dependabot/go_modules/golang.org/x/term-0.39.0
chore(deps): bump golang.org/x/term from 0.38.0 to 0.39.0
2026-02-06 11:40:15 -07:00
Kynan Ware
0a2841fb9d update third party licenses 2026-02-06 11:30:46 -07:00
dependabot[bot]
4de27314a0
chore(deps): bump golang.org/x/term from 0.38.0 to 0.39.0
Bumps [golang.org/x/term](https://github.com/golang/term) from 0.38.0 to 0.39.0.
- [Commits](https://github.com/golang/term/compare/v0.38.0...v0.39.0)

---
updated-dependencies:
- dependency-name: golang.org/x/term
  dependency-version: 0.39.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-02-06 18:28:20 +00:00
Kynan Ware
cc3fd78414
Merge pull request #12468 from cli/dependabot/go_modules/golang.org/x/text-0.33.0
chore(deps): bump golang.org/x/text from 0.32.0 to 0.33.0
2026-02-06 11:27:05 -07:00
Kynan Ware
ad305b7217 update third party licenses 2026-02-06 11:19:27 -07:00
dependabot[bot]
28ed4bdbf0
chore(deps): bump golang.org/x/text from 0.32.0 to 0.33.0
Bumps [golang.org/x/text](https://github.com/golang/text) from 0.32.0 to 0.33.0.
- [Release notes](https://github.com/golang/text/releases)
- [Commits](https://github.com/golang/text/compare/v0.32.0...v0.33.0)

---
updated-dependencies:
- dependency-name: golang.org/x/text
  dependency-version: 0.33.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-02-06 18:17:42 +00:00
Kynan Ware
fa43288852
Merge pull request #12567 from cli/kw/multi-select-with-search-and-ccr
`gh pr edit`: Add support for Copilot as reviewer with search capability, performance and accessibility improvements
2026-02-06 10:51:36 -07:00
Kynan Ware
c0febc1ac8 Add toGitHubV4Strings helper to reduce code duplication 2026-02-04 15:18:49 -07:00
Kynan Ware
ebf932a043 Address PR review comments
Address PR review comments: code consistency and DRY improvements

- Add botTypeName const for consistency with teamTypeName
- Create extractTeamSlugs helper using strings.SplitN to simplify
  team slug extraction logic
- Replace duplicate code in AddPullRequestReviews and
  RemovePullRequestReviews with extractTeamSlugs helper
- Fix ClientMutationId naming with explicit graphql tag for
  consistency with other mutations in the codebase
2026-02-04 15:15:29 -07:00
Kynan Ware
af4dad088a
Merge pull request #12469 from cli/dependabot/go_modules/github.com/gdamore/tcell/v2-2.13.7
chore(deps): bump github.com/gdamore/tcell/v2 from 2.13.4 to 2.13.7
2026-02-03 11:49:46 -07:00
Kynan Ware
bc689e358a update third party licenses 2026-02-03 11:39:31 -07:00
dependabot[bot]
915750902c
chore(deps): bump github.com/gdamore/tcell/v2 from 2.13.4 to 2.13.7
Bumps [github.com/gdamore/tcell/v2](https://github.com/gdamore/tcell) from 2.13.4 to 2.13.7.
- [Release notes](https://github.com/gdamore/tcell/releases)
- [Changelog](https://github.com/gdamore/tcell/blob/main/CHANGESv3.md)
- [Commits](https://github.com/gdamore/tcell/compare/v2.13.4...v2.13.7)

---
updated-dependencies:
- dependency-name: github.com/gdamore/tcell/v2
  dependency-version: 2.13.7
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-02-03 18:35:17 +00:00
Kynan Ware
5378856954
Merge pull request #12555 from cli/dependabot/go_modules/github.com/theupdateframework/go-tuf/v2-2.4.1
chore(deps): bump github.com/theupdateframework/go-tuf/v2 from 2.3.1 to 2.4.1
2026-02-03 11:31:45 -07:00
Kynan Ware
188dfde7aa Update third party licenses 2026-02-03 18:23:45 +00:00
dependabot[bot]
291637aabf
chore(deps): bump github.com/theupdateframework/go-tuf/v2
Bumps [github.com/theupdateframework/go-tuf/v2](https://github.com/theupdateframework/go-tuf) from 2.3.1 to 2.4.1.
- [Release notes](https://github.com/theupdateframework/go-tuf/releases)
- [Commits](https://github.com/theupdateframework/go-tuf/compare/v2.3.1...v2.4.1)

---
updated-dependencies:
- dependency-name: github.com/theupdateframework/go-tuf/v2
  dependency-version: 2.4.1
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-02-03 18:01:55 +00:00
Kynan Ware
1714ae5407
Merge pull request #12524 from cli/dependabot/go_modules/github.com/sigstore/rekor-1.5.0
chore(deps): bump github.com/sigstore/rekor from 1.4.3 to 1.5.0
2026-02-03 10:59:55 -07:00
Kynan Ware
b9a63c8923 Update third-party licenses 2026-02-03 10:50:17 -07:00
Kynan Ware
db19b778ad
Merge pull request #12558 from cli/dependabot/github_actions/actions/attest-build-provenance-3.2.0
chore(deps): bump actions/attest-build-provenance from 3.1.0 to 3.2.0
2026-02-03 10:43:42 -07:00
Kynan Ware
a9a0486c70 Clarify comment on reviewer API behavior
Update comment in FetchOptions to specify that the APIs used for both GHES and GitHub.com accept user logins and team slugs directly, clarifying why non-interactive flows with Add/Remove don't need to fetch reviewers/teams. Comment-only change; no functional modifications.
2026-01-30 11:33:22 -07:00
Kynan Ware
aac223ab71 Clarify assignee/reviewer fetching behavior
Add clarifying comment in pkg/cmd/pr/edit/edit.go to note that missing assignee/reviewer search functions trigger a downstream fallback to legacy fetching. In pkg/cmd/pr/shared/editable.go remove a redundant line and add a TODO urging migration of non-interactive assignee updates to use the new logins input with ReplaceActorsForAssignable to avoid unnecessary fetching. These are comment and doc changes to clarify intent and future improvements.
2026-01-30 11:29:11 -07:00
Kynan Ware
4569aae0e4 Clarify EditableReviewers comment
Remove a redundant struct-level comment and update the DefaultLogins field comment in pkg/cmd/pr/shared/editable.go to more accurately describe its purpose: used to disambiguate actors from display names rather than to compute add/remove sets.
2026-01-30 11:20:30 -07:00
Kynan Ware
7303c44483 Clarify Copilot assignee comment
Reword the comment for CopilotAssigneeLogin to indicate it refers to Copilot when retrieved as an assignee. This updates wording from the previous 'Actor/assignable actors' phrasing for clarity; no code behavior changed.
2026-01-30 11:17:25 -07:00
Kynan Ware
c8b1409803 Use unfiltered totalCount for reviewer 'more results' display
Query aliased fields without search filter to get stable counts.
2026-01-29 12:54:04 -07:00
Kynan Ware
484526da77 Include name in reviewer display for existing review requests
Fetch name field in reviewRequests GraphQL query and show as 'login (Name)'.
2026-01-29 12:46:26 -07:00