STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
4658 commits 87 branches 0 tags 160 MiB
Commit graph

4658 commits

This branch
This branch
All branches
Author SHA1 Message Date
Gabriel Ramírez
34f9c0a67c
Updating docs and interation exit condition to not check the final page 2021-10-06 14:18:44 +00:00
Gabriel Ramírez
aa49a3a557
Adding a second condition just in case 2021-10-05 21:43:28 +00:00
Gabriel Ramírez
61b0fe36b2
Adding additional tests for mid-flight deletions and additions 2021-10-05 21:31:47 +00:00
Gabriel Ramírez
02145cc4fd
Updated PR with suggestions 
- created a new method  to avoid defer pileup issue
- removed extra api call at the end of the sequence
 2021-10-05 21:15:24 +00:00
Gabriel Ramírez
c6dc50983d
Update internal/codespaces/api/api.go 
Co-authored-by: Jose Garcia <josebalius@github.com>
 2021-10-05 15:33:22 -05:00
Gabriel Ramírez
4314f734e3
Update internal/codespaces/api/api.go 
Co-authored-by: Jose Garcia <josebalius@github.com>
 2021-10-05 15:33:16 -05:00
Gabriel Ramírez
e793a5961d
Add strconv 2021-10-05 19:00:21 +00:00
Gabriel Ramírez
fd5894d28d
Merge remote-tracking branch 'upstream/trunk' into geramirez/codespaces-pagination 2021-10-05 18:58:23 +00:00
Gabriel Ramírez
409cd9c388
Fixing Has() issue due to go version 2021-10-05 18:49:41 +00:00
Gabriel Ramírez
777978644c
Adding pagination to list codespaces 2021-10-05 16:49:40 +00:00
Jose Garcia
616d6c2db1
Merge pull request #4431 from cli/jg/get-skus-public 
codespace machine: switch `API.GetCodespacesMachines` to use new API
 2021-10-05 12:44:38 -04:00
Jose Garcia
3652307cf3
Merge pull request #4429 from cli/jg/start-codespace-public 
codespace create: update `API.StartCodespace` to use new API endpoint
 2021-10-05 09:20:33 -04:00
Jose Garcia
a2e6df18e7
Merge pull request #4432 from cli/jg/rename-pkg 
codespace: rename the cmd pkg to codespace
 2021-10-05 08:23:36 -04:00
Jose Garcia
50d8f1e09a
Merge pull request #4409 from cli/jg/delete-codespace-public 
codespace delete: update DeleteCodespaces to new API endpoint
 2021-10-05 08:20:53 -04:00
Jose Garcia
d02876e6ea Rename the cmd pkg to codespace 2021-10-04 14:16:04 -04:00
Jose Garcia
e0db10e4dd Switch API.GetCodespacesMachines to use new API 
- The SKU terminology is also dropped in favor of "machine" which
  matches the nomenclature of the rest of the product.
 2021-10-04 13:40:18 -04:00
Jose Garcia
a3efb53c44 Update API.StartCodespace to use new API endpoint 
- Switch to using name instead of GUID
- Remove GUID from the code since it is not used anywhere else
- Add docs to the api client methods
- Re-gen mocked client
 2021-10-04 08:32:02 -04:00
Jose Garcia
61af29bb96 Update telemetry path 2021-10-01 13:02:29 -04:00
Jose Garcia
93cea6d370
Merge pull request #4408 from cli/jg/create-codespace-public 
codespace create: update startCreate to use new API endpoint
 2021-10-01 12:55:44 -04:00
Jose Garcia
6b1876161d Update DeleteCodespaces to new API endpoint 
- Drop the need for the user argument
- Update mocks
- Remove no longer applicable TODO comment
- Show message for successful deletion (this regressed)
 2021-10-01 12:53:35 -04:00
Jose Garcia
86a4706ed2 Update startCreate to use new API endpoint 
- Updates the signature of startCreate
- Can't update API.CreateCodespace just yet until we support expanded
  access on the GET codespace endpoint which is used for polling
 2021-10-01 11:29:16 -04:00
Jose Garcia
68e54a5904
Merge pull request #4407 from cli/jg/list-codespaces-public 
codespace list: update ListCodespaces to use new API endpoint
 2021-10-01 11:28:37 -04:00
Mislav Marohnić
cb6db95ec6
Merge pull request #4403 from cli/cs-concurrent-requests 
Don't allow the lazyLoadedHTTPClient mutex to wrap `Do()`
 2021-10-01 17:26:04 +02:00
Jose Garcia
05297b8c8d Update ListCodespaces to use new API endpoint 
- Removes the need for a User to list codespaces which should result in
  a slight speed improvement.
 2021-10-01 10:37:15 -04:00
Mislav Marohnić
77e8b16b27
Merge pull request #4405 from cli/bump-survey 
Bump Survey to fix "Unexpected escape sequence"
 2021-10-01 14:20:37 +02:00
Mislav Marohnić
6249bee148 Bump Survey to fix "Unexpected escape sequence" 
https://github.com/AlecAivazis/survey/pull/367
 2021-10-01 14:14:55 +02:00
Mislav Marohnić
a723813064 Don't allow the lazyLoadedHTTPClient mutex to wrap Do() 
We only need a mutex around accessing `l.httpClient`, but never around
the actual HTTP request.
 2021-10-01 11:18:15 +02:00
Jose Garcia
be22cabe0b
Merge pull request #4395 from cli/jg/move-ghcs-cmd 
pkg/cmd/codespace: move `cmd/ghcs` to `pkg/cmd/codespace`
 2021-09-30 12:49:50 -04:00
Jose Garcia
0859de0124 Merge branch 'trunk' of github.com:cli/cli into jg/move-ghcs-cmd 2021-09-30 12:38:41 -04:00
Jose Garcia
ab27d1b5e1
Merge pull request #4394 from cli/jg/move-codespace-api 
codespace api: move `internal/api` to `internal/codespaces/api`
 2021-09-30 12:02:14 -04:00
Jose Garcia
94953ed3fc Merge branch 'trunk' of github.com:cli/cli into jg/move-codespace-api 2021-09-30 11:52:22 -04:00
Jose Garcia
4e9c443adf
Merge pull request #4393 from cli/jg/move-liveshare 
liveshare: move location from `internal/liveshare` to `pkg/liveshare`
 2021-09-30 11:50:07 -04:00
Jose Garcia
9e6c11e767 Move cmd/ghcs to pkg/cmd/codespace 
- Delete pkg/cmd/codespace/main as it is no longer needed in this
  codebase
 2021-09-30 11:20:13 -04:00
Jose Garcia
23d41ddb0d Format files 2021-09-30 11:09:59 -04:00
Jose Garcia
b5bbb442fd Move internal/api to internal/codespaces/api 2021-09-30 11:06:43 -04:00
Jose Garcia
53e4149c91 Update tests 2021-09-30 10:42:03 -04:00
Jose Garcia
f4a5f82312 Move internal/liveshare to pkg/liveshare 2021-09-30 10:34:27 -04:00
Jose Garcia
877ad22da6
Merge pull request #4384 from cli/import-codespaces 
Import codespaces
 2021-09-30 09:44:29 -04:00
Jose Garcia
a1e72af1da
Merge pull request #4392 from cli/jg/validate-host-key 
codespace: validate host public keys
 2021-09-30 09:26:28 -04:00
Jose Garcia
2ce14f603f Update tests with mock public key and test case 2021-09-30 08:40:18 -04:00
Jose Garcia
5b5c3da393 Validate host public keys 2021-09-30 08:16:28 -04:00
Mislav Marohnić
c4ec0a65ba
Merge pull request #4363 from RasmusWL/patch-1 
Also set `pushRemote` on `gh pr checkout` from fork
 2021-09-30 12:01:47 +02:00
Nate Smith
af812e2bdc
Merge pull request #4373 from cli/ext-bin-upgrade 
binary extensions list & upgrade
 2021-09-29 16:03:05 -05:00
Jose Garcia
c3ce95ea1c Add mutex to guard httpClient 2021-09-29 16:45:51 -04:00
Mislav Marohnić
0d0152b0fa Have gh codespace inherit the correct API client 2021-09-29 21:21:16 +02:00
vilmibm
7efd06b87d rename function 2021-09-29 13:43:37 -05:00
vilmibm
a2e7eaf808 test update available for binary ext in list 2021-09-29 13:39:00 -05:00
Jose Garcia
9bc50f5ab8
Merge pull request #4379 from cli/import-codespaces-add-nacl 
Switch to using cli/crypto & test fixes
 2021-09-29 10:49:30 -04:00
Mislav Marohnić
48bac0abd2 Fix race in codespaces delete test 2021-09-29 16:40:40 +02:00
Jose Garcia
a0f11b6664 Handle concurrency in tests and logger 
- Live Share tests
- Logger implementation for ghcs
 2021-09-29 16:40:40 +02:00