STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
2968 commits 87 branches 0 tags 160 MiB
Commit graph

50 commits

Author SHA1 Message Date
Mislav Marohnić
75ebb863e3 Use testify assertions for error matching 2021-01-19 13:59:37 +01:00
Cristian Dominguez
45f4a1f087 Equal: flip arguments position 2021-01-18 21:00:59 -03:00
Cristian Dominguez
3afb1d0b1a Use Testify assertions in test 2021-01-16 19:19:30 -03:00
Cristian Dominguez
ce151420f3 Migrate legacy tests 2021-01-11 21:07:19 -03:00
Mislav Marohnić
f4152454f2
Merge pull request #2472 from cristiand391/preserve-metadata-state 
Prompt: avoid resetting PR/issue metadata
 2020-12-03 18:51:29 +01:00
Mislav Marohnić
8db2027c99 Allow interactive pr create even if we failed to look up commits 2020-12-03 18:02:24 +01:00
Mislav Marohnić
be39f4363b Make MetadataSurvey testable by accepting an interface 2020-12-03 17:47:40 +01:00
Mislav Marohnić
8e1f736775
Merge pull request #2519 from cli/issue-create-browser-fix 
Fix respecting chosen action in interactive `issue create`
 2020-12-02 13:02:16 +01:00
Mislav Marohnić
be759785f0 Fix "Continue in browser" for pr create coming from forks 
Ensures that the `owner:` prefix is present when referencing the head branch
 2020-12-01 21:23:39 +01:00
Max Horstmann
34d549e7b6
Document that reviewers can be teams (#2465) 
Co-authored-by: Mislav Marohnić <mislav@github.com>
 2020-11-26 17:31:15 +01:00
vilmibm
cf37ce7463 no shorthand for --recover 2020-11-23 11:24:28 -08:00
vilmibm
d6e84a75fb switch to recover instead of resubmit 2020-11-23 11:21:34 -08:00
vilmibm
d300526318 preserve and restore issue/pr input on failure 2020-11-23 11:21:28 -08:00
Josh Soref
0e681ca6c4 spelling: beginning 2020-11-21 21:43:46 -05:00
vilmibm
ef52376fe0 fix survey invocation 2020-11-13 10:35:32 -08:00
vilmibm
a686455fb6 add Draft to issue state 2020-11-12 12:17:37 -08:00
vilmibm
b231e6c2cf use NewIssueState 2020-11-12 12:15:48 -08:00
vilmibm
f5277e452e get everything working 2020-11-12 12:03:32 -08:00
vilmibm
0ed7879329 stop using Defaults struct 2020-11-12 12:03:20 -08:00
vilmibm
6671106448 WIP works, probably some title/body input edge cases 2020-11-12 12:03:20 -08:00
vilmibm
6fde02df1c use named output param 2020-11-12 12:02:17 -08:00
Nate Smith
24d863eccc
Merge pull request #2316 from cli/colors-1624 
migrate off of utils color functions
 2020-11-03 12:49:02 -06:00
Sam Coe
9acbf8aae4
Refactor regexp writer 2020-11-03 09:59:40 +03:00
Sam Coe
bf46b870cb
Add multiple writes test 2020-11-03 09:59:39 +03:00
Sam Coe
eaa685ac9b
Use custom scanLines function for RegexWriter 2020-11-03 09:59:38 +03:00
Sam Coe
212993632b
Fix up regex to escape dot in URL 2020-11-03 09:59:11 +03:00
Sam Coe
28b3b2c9e7
Address PR comments 2020-11-03 09:59:09 +03:00
vilmibm
a2aa154794 port entirely to ColorScheme 2020-10-29 12:37:45 -07:00
Ian Billett
0f61272333 Allow PullRequestForBranch to search in closed pull requests 2020-10-28 15:50:59 +01:00
Mislav Marohnić
4b395c5dd2
Merge pull request #2234 from XD-DENG/stringsbuilder 
Use strings.Builder for more efficient string concatenation
 2020-10-21 18:22:43 +02:00
Mislav Marohnić
d5cb5574d0 💅 simplify generateCompareURL and test 2020-10-21 12:09:46 +00:00
Leonardo
d0bee19eaf Query escape branch names to allow branch/#123 names 2020-10-21 12:09:46 +00:00
XD-DENG
7e9f1c7147 Use strings.Builder for more efficient string concatenation 
It minimizes memory copying.

Reference: https://golang.org/pkg/strings/#Builder
 2020-10-19 20:51:51 +02:00
Dimitris Apostolou
6f550b5d12
Fix typos 2020-10-04 22:16:30 +03:00
Harsh Shandilya
0107b00043
Don't override user provided title and body when --fill is used (#1994) 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
 2020-09-30 16:15:30 +02:00
Mislav Marohnić
80b60fc6a9 Fix pr create for branches published under a different name 2020-09-24 11:35:02 +02:00
Mislav Marohnić
e2efc0b8a3 Fix pr create when branch was already pushed to a non-base remote 2020-09-23 19:53:27 +02:00
Mislav Marohnić
f99a55438f Remove issue create examples from pr create 2020-09-16 15:48:13 +02:00
Mislav Marohnić
7a8db80420 Prompt for push target during pr create 
We no longer guess the head repository using heuristics; instead, we
present the user with the choice of pushable repositories and an
additional option to create a new fork.

The new `pr create --head` flag is available for the user to specify the
head branch in `branch` or `owner:branch` format and completely skip any
forking or auto-pushing checks.
 2020-09-16 14:49:36 +02:00
Mislav Marohnić
d534a94d1b Change how base repository is resolved 
On first run in a git repository, `BaseRepo()` will now prompt the user
which repository should be queried as base repository if there are
multiple git remotes or when we are in the context of a fork.

In non-interactive mode, the prompt is skipped and we default to the
first git remote instead.

After the base repo is resolved, the result is cached in the local
repository using `git config` so that RepositoryNetwork API lookups can
be avoided in the future.
 2020-09-15 21:27:12 +02:00
vilmibm
1073c97409 review feedback 2020-09-11 11:36:24 -05:00
vilmibm
c0fc31f7d5 use CanPrompt in commands 2020-09-10 12:13:48 -05:00
Daniel Leong
c7e702203b Update template test to reflect inclusion of "default" text 
Also, avoid excessive amounts of newlines separating the two
 2020-09-08 20:25:52 -04:00
Daniel Leong
41543b564d "Check" the error value of ioutil.WriteFile 
We could, alternatively, use t.Fatal... this matches the MkdirAll
invocation from github_template_test, however...
 2020-09-08 20:12:28 -04:00
Daniel Leong
a33124414c Add a test to verify the behavior of prepending commit body to message 2020-09-08 20:12:28 -04:00
Nate Smith
c2d7cbf51f
Merge pull request #1582 from AliabbasMerchant/interactiveCreationTests 
Interactive template selection test for issue create
 2020-09-08 16:55:04 -05:00
AliabbasMerchant
9e7279604d Fix failing tests for Windows (due to line-ending issues) 2020-09-02 10:03:56 +05:30
AliabbasMerchant
51c5595cad Interactive template selection test for PR create 2020-09-02 09:56:28 +05:30
Mislav Marohnić
766e4950d9 Be transparent about which part of pr create flow failed 
When applying metadata to the new PR such as assignees or reviewers, if
the operation fails, an error message would get printed:

    failed to create pull request: <API error text>

This was misleading, because the PR did get created; it's just that
updating it failed. The new error message is:

    https://github.com/OWNER/REPO/pull/123
    pull request update failed: <API error text>

The PR URL is printed on stdout and the error message is printed on
stderr. In case of any errors, the exit code is still non-zero.
 2020-08-31 16:46:22 +02:00
Mislav Marohnić
558e3f3dea Isolate pr create command 2020-08-04 18:29:42 +02:00