Commit graph

3959 commits

Author SHA1 Message Date
Mislav Marohnić
3e8f075a8e Bump Cobra for improved completion support 2021-07-21 15:01:31 +02:00
Sam
fa354a922b
Merge pull request #3905 from cli/extensions-list-notice
Add update checking to extensions list
2021-07-20 13:21:30 -07:00
Sam Coe
e70bdbf7a9
Add update checking to extensions list 2021-07-20 13:13:20 -07:00
Mislav Marohnić
3ff94ae76b
Merge pull request #4025 from cli/revert-3926-update-goreleaser-20210630
Revert "Update GoReleaser"
2021-07-20 22:02:49 +02:00
Mislav Marohnić
6c8abe9df6
Merge branch 'trunk' into revert-3926-update-goreleaser-20210630 2021-07-20 21:43:51 +02:00
Mislav Marohnić
85d0447a6e
Revert "Update GoReleaser to v0.172.1" 2021-07-20 21:39:50 +02:00
Mislav Marohnić
5bbce4a5b9 Fix goreleaser config for linux packages 2021-07-20 20:15:48 +02:00
Mislav Marohnić
ccd4f0fa9a
Merge pull request #3706 from cristiand391/improve-automerge
PR auto-merge improvements
2021-07-20 19:55:43 +02:00
Mislav Marohnić
a83c2924c5 Never prompt to delete branch if --auto was given 2021-07-20 19:49:19 +02:00
Mislav Marohnić
6e026412df Add "UNSTABLE" to immediately mergeable statuses
This status describes a state where the head branch is mergeable and
technically not blocked per base branch requirements, but it does have
non-passing checks.
2021-07-20 19:42:53 +02:00
Mislav Marohnić
6f2dfd7eea Adjust conditions for switching between regular and auto merge
Conditions prohibiting a regular merge: BLOCKED, BEHIND, DIRTY.

Conditions triggering a regular merge even if `--auto` was set: CLEAN,
HAS_HOOKS.

Note that UNKNOWN status does not trigger either of the conditions.
2021-07-20 19:34:32 +02:00
Mislav Marohnić
0ab9c70c3f Merge remote-tracking branch 'origin' into improve-automerge 2021-07-20 18:45:47 +02:00
Mislav Marohnić
1ca49a8bcd
Merge pull request #3980 from cli/bump-survey
Bump Survey library for cursor improvements
2021-07-20 18:34:14 +02:00
Mislav Marohnić
2624ed9d8c Merge remote-tracking branch 'origin' into bump-survey 2021-07-20 18:28:58 +02:00
Mislav Marohnić
4a7b130511
Merge pull request #3981 from cli/bump-gojq
Bump gojq to latest version
2021-07-20 18:27:07 +02:00
Mislav Marohnić
25ef11198f
Merge pull request #4020 from cli/xdg-docs
Clean up GH_CONFIG_DIR docs
2021-07-20 18:02:23 +02:00
Mislav Marohnić
1121ec6669
Merge pull request #4013 from chemotaxis/docs/alias-quotes-windows
Add documentation about double quoting on Windows
2021-07-20 18:01:36 +02:00
Mislav Marohnić
75c7fc1536
Merge pull request #3972 from g14a/fix/private-repo-create
fix private repo creation in case of ignore templates & repo description bugs in case of template repos
2021-07-20 16:39:36 +02:00
Mislav Marohnić
1de756f6f3 💅 address review comments 2021-07-20 16:34:11 +02:00
Mislav Marohnić
efa4d43cf4 Simplify alias set documentation 2021-07-20 15:32:51 +02:00
Mislav Marohnić
9033258f5f Clean up GH_CONFIG_DIR docs
This removes the false equivalence between GH_CONFIG_DIR and
XDG_CONFIG_HOME. These settings do not have the same effect and should
not be used for the same purposes.

Also remove the documentation about what `XDG_*` settings do. We simply
conform to the XDG Base Directory Specification, but will not document
it. It's likely that users of these environment variables already know
what they do.
2021-07-20 14:24:11 +02:00
Mislav Marohnić
25b6eecc8d
Merge pull request #4017 from despreston/des/avoid-migrate
Skip auto migrate of config when GH_CONFIG_DIR
2021-07-20 13:33:16 +02:00
Des Preston
1c9b4bf99d Skip auto migrate of config when GH_CONFIG_DIR
If GH_CONFIG_DIR is set, don't auto migrate the config file. This fixes
the situation where the path given via GH_CONFIG_DIR does not exist and
the cli attempts to migrate an existing config to that location.

Fixes #3837
2021-07-19 16:33:51 -04:00
chemotaxis
1e4e536bcb Revise Windows note 2021-07-19 15:50:27 -04:00
chemotaxis
2c52819c1a Remove note about using Git for Windows
As discussed in pull request #4013.
2021-07-19 15:50:12 -04:00
Sam
97a52f74cd
Merge pull request #3933 from cli/extensions-upgrade
Skip trying to upgrade local extensions
2021-07-19 10:55:16 -07:00
Sam Coe
b71735d0d7
Address PR comments 2021-07-19 10:48:09 -07:00
chemotaxis
23ffca45f7 Unify use of single quotes to mark shell arguments and variables
The first paragraph uses single quotes when referring to shell arguments
and variables, but the rest of the docs use double quotes.  This commit
switches to using single quotes throughout the docs.

I prefer to use single quotes inside string literals because Go uses
double quotes to define a string literal.
2021-07-19 00:46:06 -04:00
chemotaxis
5314e7c398 Add note about double quotes on non-Unix-like shells
On non-Unix-like shells like Windows Command Prompt, single quotes are
handled differently.  You need to define aliases using double quotes
instead of single quotes.

I added an inline example to illustrate the quotes.  The example is
formatted as inline code blocks in Markdown.  Unfortunately, because Go
uses backticks for raw string literals, I needed to do some rather ugly
string concatenation in order to get the backticks included in the doc
string.

This also rearranges the notes so that the platform specific notes are
at the end of the documentation.
2021-07-19 00:36:07 -04:00
Mislav Marohnić
496b70ac0e
Merge pull request #3934 from cli/extensions-remove-notice
Add confirmation to extensions remove
2021-07-16 15:18:38 +02:00
Mislav Marohnić
882f6d33cb Merge remote-tracking branch 'origin' into extensions-remove-notice 2021-07-16 15:12:56 +02:00
Mislav Marohnić
d68df4a9d8 Do not output error messages for nontty 2021-07-16 15:10:36 +02:00
Mislav Marohnić
30beb67cb3
Merge pull request #3941 from cli/extension-install-check
Extension install check
2021-07-16 14:58:52 +02:00
Mislav Marohnić
d6b0749ea2 Tweak error messages and add more tests for extension install name check 2021-07-16 14:52:05 +02:00
Nate Smith
4d9867243c
Merge pull request #3911 from cli/fix-extensions-panic
Fix issue in FindEntry that causes extensions and alias crash
2021-07-15 11:27:10 -05:00
Sam
6d0fb9b473
Merge pull request #3926 from chemotaxis/update-goreleaser-20210630
Update GoReleaser to `v0.172.1`
2021-07-15 08:12:16 -07:00
Mislav Marohnić
5c21c949a0 Merge remote-tracking branch 'origin' into fix/private-repo-create 2021-07-15 12:58:00 +02:00
Mislav Marohnić
0ad153f696 Separate payload structs for REST vs GraphQL repo create
This enforces strict separation between serialization structs used for
repository creation payload with respect to whether GraphQL or REST was
used. Before, a field added to a GraphQL payload would leak to REST
payload (and vice versa).
2021-07-15 12:56:14 +02:00
Mislav Marohnić
aed8966f75
Merge pull request #3995 from despreston/3989-fix-pr-create-confirm
fix repo create --confirm
2021-07-14 17:26:15 +02:00
Des Preston
17b58bf0b2 fix repo create --confirm
Respect the --confirm flag when deciding whether to prompt for gitignore
and license creation during `repo create`

Fixes #3989
2021-07-14 09:59:04 -04:00
Gowtham Munukutla
e600ce054a fix description related bugs in creating a template repo 2021-07-13 09:38:34 +05:30
Gowtham Munukutla
0a9fcb9332 Merge branch 'trunk' of https://github.com/cli/cli into fix/private-repo-create 2021-07-13 09:30:48 +05:30
Nate Smith
161de77fd7
Merge pull request #3943 from silby/browse-output
Add a no-browser mode to gh browse
2021-07-12 13:39:30 -05:00
nate smith
98d3b7cc79 don't check Fprintf error
we don't ever check the return of Fprintf anywhere else in the codebase
so doing it here suggests that it's a special case. if it's something we
should be doing we can circle back and do it more consistently.
2021-07-12 13:05:49 -05:00
Nate Smith
6c7bff2524
Merge pull request #3912 from bchadwic/trunk
Added colors to issue / pr labels in the terminal
2021-07-12 12:46:01 -05:00
Mislav Marohnić
cd3df4cdf9
Merge pull request #3982 from despreston/des/err-return
Return SilentError if completed run failed
2021-07-12 17:05:41 +02:00
Mislav Marohnić
13037226c2 Add test for gh run watch --exit-status with completed runs 2021-07-12 16:58:45 +02:00
Mislav Marohnić
4dc23d869e Bump gojq to latest version
Upgrades gojq, the library that powers the `--jq` filter flag for JSON.
This upgrade is purely housekeeping and not to address any particular
issue reported with gh.

https://github.com/itchyny/gojq/releases/tag/v0.12.4
2021-07-12 15:34:08 +02:00
Mislav Marohnić
079542d35c Bump Survey library for cursor improvements
https://github.com/AlecAivazis/survey/releases/tag/v2.2.14
2021-07-12 14:47:40 +02:00
Gowtham Munukutla
a1f26057de gofmt 2021-07-10 23:04:46 +05:30