Commit graph

73 commits

Author SHA1 Message Date
Jose Garcia
40886479ae Close SSH even if RPC Close fails 2021-09-20 20:35:12 +00:00
Jose Garcia
57d04dc5f0 Allow clients to Close a Session, general tidy up
- Allow clients to call Close on a Session to clean up resources
- Switch to the %w verb for error wrapping
- Fix typo on Port struct after verifying the server does not have a
  typo
2021-09-20 13:16:38 +00:00
Jose Garcia
22433a57db Merge pull request #18 from github/jg/ssh-server-docs
ssh server: docs
2021-09-15 09:52:31 -04:00
Jose Garcia
20e618fd02 pr feedback 2021-09-15 13:49:03 +00:00
Jose Garcia
8abff2af97 move StartSSHServer to Session 2021-09-15 13:14:58 +00:00
Alan Donovan
2de51a8ec8 Merge pull request #17 from github/rm-terminal
Remove Terminal, no longer needed by ghcs
2021-09-15 09:06:49 -04:00
Jose Garcia
497b45e4e2 ssh server docs 2021-09-14 23:57:40 +00:00
Alan Donovan
5b23d87d47 Remove Terminal, no longer needed by ghcs 2021-09-10 15:15:05 -04:00
Jose Garcia
467c695122 Merge pull request #16 from github/jg/ignore-pf-errs
port forwarder: ignore conn errors
2021-09-09 17:00:47 -04:00
Jose Garcia
272ea57b54 revert comment update 2021-09-09 21:00:09 +00:00
Jose Garcia
efe519cb7a comments + fix Forward method 2021-09-09 20:11:45 +00:00
Jose Garcia
920f793c6d pr feedback 2021-09-09 19:33:16 +00:00
Jose Garcia
1ff5c514fb fix erroneous ctx waiting and introduce back io.EOF handling 2021-09-09 18:35:05 +00:00
Alan Donovan
2b4e881018 Merge pull request #15 from github/lightstep
Add OpenTelemetry instrumentation
2021-09-09 13:31:20 -04:00
Jose Garcia
8b0e8c990e ignore pf conn errors 2021-09-09 17:31:18 +00:00
Alan Donovan
72659a3603 add lightstep instrumentation 2021-09-08 17:24:23 -04:00
Alan Donovan
5c26d1488f Merge pull request #14 from github/ssh-close-workaround
add workaround for ssh.channel.Close EOF
2021-09-03 15:13:20 -04:00
Alan Donovan
50523c4f10 remove ListenTCP and add workaround for ssh.channel.Close EOF 2021-09-03 14:39:47 -04:00
Alan Donovan
10a129b764 Merge pull request #13 from github/listen-race
move Listen call into clients to avoid race
2021-09-03 10:05:02 -04:00
Alan Donovan
e2552fbd2a rename to ForwardToListener 2021-09-03 09:43:31 -04:00
Alan Donovan
5bd0519ef3 move Listen call into clients to avoid race 2021-09-02 17:52:49 -04:00
Alan Donovan
b4686935b9 Merge pull request #12 from github/fix-share-data-race
Fix data race in StartSharing
2021-09-02 15:44:49 -04:00
Alan Donovan
4438b85e29 comment tweaks 2021-09-02 15:41:36 -04:00
Alan Donovan
94319d4cfe move localPort parameter to ForwardToLocalPort 2021-09-02 15:34:57 -04:00
Alan Donovan
94b91661cc don't forget to close conn in case of sharing error 2021-09-02 14:30:19 -04:00
Alan Donovan
87b15aa264 Fix data race in StartSharing 2021-09-02 14:03:48 -04:00
Alan Donovan
e9cb521bfd Merge pull request #11 from github/session
rename Server to Session and simplify API
2021-09-02 12:37:00 -04:00
Alan Donovan
6f45c7fa7d point out data races to be fixed 2021-09-02 12:14:04 -04:00
Alan Donovan
23ea329f2e Merge branch 'main' into session 2021-09-02 11:49:13 -04:00
Alan Donovan
05a3d90a99 more tweaks 2021-09-02 11:39:29 -04:00
Alan Donovan
34c20cf105 Merge pull request #10 from github/rpc-fixes
fix two data races in rpcHandler
2021-09-02 11:38:38 -04:00
Alan Donovan
4cceda1af0 rename Server to Session and simplify API 2021-09-02 11:06:58 -04:00
Alan Donovan
af38292f1e fix data races 2021-09-01 18:18:43 -04:00
Alan Donovan
ca6d074333 Merge branch 'main' into wip 2021-09-01 17:55:31 -04:00
Alan Donovan
55fa17d8bc wip 2021-08-31 17:30:40 -04:00
Alan Donovan
9964a444b0 Merge pull request #9 from github/liveshare-spelling
spell Live Share product name correctly in UI
2021-08-31 17:30:19 -04:00
Alan Donovan
fc4c678d03 Merge pull request #8 from github/portfwd-errors
handle errors in port forwarding
2021-08-31 16:23:33 -04:00
Alan Donovan
b63972b62f spell Live Share product name correctly in UI 2021-08-31 11:07:26 -04:00
Alan Donovan
4af240d87d handle errors in port forwarding 2021-08-30 17:36:28 -04:00
Jose Garcia
273782bcbc rename file 2021-08-27 11:49:21 +00:00
Edmundo Gonzalez
49cebb11ca Merge pull request #5 from github/edgonmsft/codespaces-ssh-rpc
Adding sshRPC interface
2021-08-26 16:27:16 -07:00
Edmundo Gonzalez
0eb769d608 Rename File 2021-08-26 23:04:35 +00:00
Edmundo Gonzalez
18ab421b08 Rename to SSHServer 2021-08-26 23:04:05 +00:00
Edmundo Gonzalez
a89c17a564 Adding sshRPC interface 2021-08-26 22:34:56 +00:00
Jose Garcia
269196c94f support existing connections for port forwarding 2021-08-18 15:12:47 +00:00
Jose Garcia
79111d85ac Merge pull request #4 from github/jg/port-forwarding-errors-test-server
Port forwarding improvements & slight refactor
2021-08-13 08:41:43 -04:00
Jose Garcia
eb2a176450 remove err print 2021-08-07 17:54:43 +00:00
Jose Garcia
fbf0d28672 port forwarding err handling and test refactors 2021-08-06 01:03:03 +00:00
Jose Garcia
cd99399290 Merge pull request #3 from github/jg/ignore-eof-terminal
Ignore EOF on terminal close
2021-07-28 09:56:07 -04:00
Jose Garcia
ae29c3c1ea Ignore EOF on terminal close 2021-07-28 13:55:33 +00:00