Commit graph

2019 commits

Author SHA1 Message Date
Mislav Marohnić
5fdeb8b0a2
Merge pull request #5549 from cli/editor-shellquote-fix
issue comment: support quotes and arguments in EDITOR value
2022-05-02 13:09:51 +02:00
chemotaxis
a291b3eed3
Fix grammar in repo create prompt (#5557)
* Use plural linking verb

While it looks like you could use "there's" informally, grammatically, it should be "are" since "commits" is plural.

<https://dictionary.cambridge.org/us/grammar/british-grammar/there-is-there-s-and-there-are>

* Omit "the"

I created a remote called "github" and got this prompt:

> Would you like to push commits from the current branch to the "github"?

Normally, the default name "origin" doesn't sound bad in that prompt,
but using the name "github" made the prompt sound like something wasn't
right to my American English-speaking ears.

Here are a few options.  Yes, I know English grammar sucks, to put it
mildly.  But, hopefully, the following options and explanations make
sense.

Get rid of "the".  This is the option I went with.  "github" acts as a
proper noun, so no determiner is needed.  If you substitute your own
name for "github" in the original prompt above, you get the same effect:

> Would you like to push commits from the current branch to "github"?

Add the implicit word "remote".  "github" now acts as an adjective and
"the" refers to "remote":

> Would you like to push commits from the current branch to the "github" remote?

Or, combine the two.  This last option relies on the fact that
instructions and manuals often omit definite articles because most
articles are definite.  See the [zero-marking][2] article on Wikipedia.
The original prompt already does this by omitting "the" before the word
"commits":

> Would you like to push commits from the current branch to "github" remote?

Reference:

[1]: http://writing.umn.edu/sws/quickhelp/grammar/articlesproper.html

[2]: https://en.wikipedia.org/wiki/Zero-marking_in_English
2022-05-02 10:21:59 +02:00
Mislav Marohnić
5986f88565 issue comment: support quotes and arguments in EDITOR value
The `issue comment` command would perform a `filepath.Base()` on the
value of EDITOR and use the result for launching the editor, which is
undesireable for both functional and display purposes:

- For functional purposes, always shellsplit the value of GH_EDITOR or
  EDITOR before we shell out to that process;
- For display purposes, extract the basename only after shellsplitting.
2022-04-29 18:05:39 +02:00
Caleb Brose
55bce59ab7
Add command to open codespaces in JupyterLab
Add command to open codespaces in JupyterLab
2022-04-28 16:11:14 -05:00
JP Ungaretti
3526d25a1e Remove mention of function 2022-04-28 20:55:43 +00:00
JP Ungaretti
8aa132e6c6 Use named return values 2022-04-28 18:42:05 +00:00
JP Ungaretti
ceba2c896b Use safeClose instead of Close 2022-04-28 18:38:46 +00:00
JP Ungaretti
6ddd3360d8 Update auth error message 2022-04-28 18:10:14 +00:00
Heath Stewart
5ed83e2b2a
Remove Stringer from ghrepo.Interface (#5536) 2022-04-28 08:58:34 +02:00
ffalor
7d0a7f98e1
Add progress indicator to gist create (#5526) 2022-04-27 08:17:17 +00:00
Heath Stewart
171baca07d
Clarify label edit --name switch (#5525)
Follow-up from #5519
2022-04-27 09:37:28 +02:00
Håvard Anda Estensen
58cb773e09
Replace ioutil with io and os (#5498) 2022-04-26 13:07:44 +02:00
Heath Stewart
6edb4ecdbb
Add label edit command (#5519) 2022-04-26 09:43:07 +00:00
Sam Coe
db85b1d3cb
Properly handle issue and pr state options when building search queries (#5513) 2022-04-25 20:18:58 +02:00
Heath Stewart
19a852ae9f
Add label clone command (#5452) 2022-04-25 18:13:22 +00:00
Roshan Padaki
13342cb272
Don't error on list commands when no results found (#5479)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-04-25 17:55:52 +00:00
Mislav Marohnić
0bc8aae45f Avoid crash when deleting gist with no owner
This removes the explicit check for the gist owner, speeding up the gist
deletion due to fewer API requests, but resulting in a more vague error
message in case the gist is "not found".
2022-04-25 13:24:19 +02:00
JP Ungaretti
fce69a5350 Add context to errors 2022-04-21 15:03:07 -07:00
JP Ungaretti
f21faca03e Resolve feedback 2022-04-21 14:56:55 -07:00
JP Ungaretti
3216d1bb3a Remove function return 2022-04-21 14:29:30 -07:00
Jeff Hubbard
7678274464
Merge pull request #5076 from cli/multi-devcontainer
Multi devcontainer
2022-04-20 12:06:23 -07:00
Jeff Hubbard
2b57084bd0 PR feedback 2022-04-20 11:52:32 -07:00
Sam Coe
c99c47f34d
Fix displayed header for search prs command (#5488) 2022-04-20 12:06:45 +02:00
Roshan Padaki
25a55948cf
add ls alias to gh repo list (#5480) 2022-04-19 16:14:22 +02:00
JP Ungaretti
4452f37819 Clarify session helper 2022-04-14 17:10:11 -05:00
JP Ungaretti
322fae53b1 Clean up more errors 2022-04-14 16:14:29 -05:00
JP Ungaretti
e8e9b58670 Clean up errors 2022-04-14 16:12:44 -05:00
JP Ungaretti
eaf8f84baf Merge branch 'trunk' into add-cs-jupyter 2022-04-14 15:27:40 -05:00
JP Ungaretti
ee1625add2 Fix -c option 2022-04-14 15:26:06 -05:00
JP Ungaretti
9874d57d62 Print JupyterLab URL 2022-04-14 14:55:40 -05:00
JP Ungaretti
9fd5923b9b Clean up Jupyter code 2022-04-14 14:40:42 -05:00
Ariel Deitcher
c445529719
warn if PR is already merged (#5463) 2022-04-14 07:47:04 +00:00
Heath Stewart
1b7d03fa8a
Allow forcibly creating labels (#5451) 2022-04-14 07:26:05 +00:00
Heath Stewart
fc8739cf97
Add column for listing the label color (#5462)
Fixes #5448
2022-04-14 08:51:37 +02:00
Luke Karrys
c847e935f1
pr create --body-file can read from stdin (#5461) 2022-04-14 06:32:26 +00:00
Mislav Marohnić
ae0b93575e Add support for installing binary extensions on M1 Macs
If the extension publishes an amd64 binary and Rosetta is available,
use that binary as it will most likely work.

If the extension publishes an arm64 binary, make sure to codesign it
after downloading so that the OS allows its execution.
2022-04-13 20:01:18 +02:00
Johannes Plunien
186e5ccfb2
Add release edit command (#5422)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-04-13 14:51:49 +00:00
Kiran Adhikari
4f7c88ea4e
pr merge: print instructions for merge conflicts (#5330)
Co-authored-by: Sam Coe <samcoe@users.noreply.github.com>
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-04-13 10:28:05 +00:00
Roshan Padaki
8f046e0b77
gh extensions list: Don't error if no extensions installed (#5445) 2022-04-13 07:31:24 +00:00
Jeff Hubbard
9fb6cf5423 Fix tests 2022-04-12 10:26:08 -07:00
Sam Coe
2c0236d096
Add extension upgrade --dry-run (#5098) 2022-04-12 07:18:08 +00:00
Mislav Marohnić
adf274851e
Merge pull request #5396 from opelr/5346/issue-delete-confirm
Add 'confirm' flag for issue delete subcommand
2022-04-11 19:17:44 +02:00
Jack Meyer
ce0562c5f2
Add codespace open --web flag (#5380)
Co-authored-by: Luan Vieira <luanzeba@github.com>
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-04-11 19:09:27 +02:00
Naïm Favier
8dbd07212c
Stop auth commands from modifying global config file (#5378) 2022-04-11 17:26:18 +02:00
Sam Coe
6fa8e4299c
Add ability to comment on close/reopen of issues/pull requests (#5437) 2022-04-11 17:06:35 +02:00
Christopher Nethercott
933a91e18e
Add "new" alias to "create" commands (#5388)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-04-11 16:48:34 +02:00
Sam Coe
8a0c1f903c
Change issue close color from red to purple (#5436) 2022-04-11 11:50:55 +02:00
Jeff Hubbard
de9b5ad8f8
Merge branch 'trunk' into multi-devcontainer 2022-04-08 15:17:33 -07:00
Mislav Marohnić
7ec2b2251d status: respect host configuration
Respect the default hostname determined from `hosts.yml` or GH_HOST
instead of always using `github.com`.
2022-04-08 14:54:40 +02:00
Jake Shorty
6783509d3b
Merge pull request #5410 from cli/codespaces-location-optional
Make location an optional flag when creating codespaces
2022-04-07 10:58:39 -06:00