Commit graph

756 commits

Author SHA1 Message Date
Nate Smith
48ffd5aa00
Merge pull request #484 from cli/issue-template-labels
Add labels to issue template
2020-02-18 10:04:54 -06:00
Nate Smith
0215074f5e
Merge pull request #481 from cli/ci-pulls
Enable CI for pull requests from forks
2020-02-18 10:03:13 -06:00
Mislav Marohnić
75b7e9588a
Merge pull request #491 from arnottcr/version
command: default to toolchain version
2020-02-18 14:04:16 +01:00
Mislav Marohnić
408b565fd9 Allow setting version via ldflags again 2020-02-18 13:47:57 +01:00
Mislav Marohnić
032390ee22
Merge pull request #490 from jschmid1/patch-1
Add openSUSE/SUSE install instructions to README
2020-02-18 12:42:41 +01:00
Mislav Marohnić
7dc24a867a
Merge pull request #488 from emecas/doc-manual-pages-clarification
(Docs) Updating CONTRIBUTING.md
2020-02-18 12:26:27 +01:00
Colin Arnott
de6e99aa75
command: default to toolchain version
Since the Go toolchain is able to extract the module version at build
time, we should use that as a default instead of DEV. This means
customers installing via go-get will get the correct version.

Unfortunately, the toolchain does not store when the build occurs, so
BuildTime now defaults to the empty string. It is still set if build
officially, just not for go-get.
2020-02-18 07:55:54 +00:00
Joshua Schmid
abfc4d3b1a
Add openSUSE/SUSE install instructions to README 2020-02-18 08:53:37 +01:00
Emerson Castaneda
103d62b309 Add manual-pages-are-automatically-generated clarification 2020-02-17 21:29:04 -05:00
Mislav Marohnić
9dd9b8c763
Merge pull request #406 from Foxboron/morten/fix-reproducible
[Makefile] Support reproducible builds
2020-02-17 16:54:19 +01:00
Mislav Marohnić
69d859a47f Add labels to issue template 2020-02-17 15:43:51 +01:00
Mislav Marohnić
5f6fd35a99 Enable CI for pull requests from forks 2020-02-17 12:52:48 +01:00
Mislav Marohnić
5d2677ed33
Merge pull request #476 from sh7dm/chore/typoes
Correct typoes in comments
2020-02-17 12:17:45 +01:00
Mislav Marohnić
df60d8829d
Merge pull request #461 from TaKO8Ki/fix-typo
Fix typo
2020-02-17 12:17:17 +01:00
Mislav Marohnić
08811c1e05
Merge pull request #466 from emecas/doc/req_go_version_13
[DOCs] Indicate Go's Version Required for Installing from Source
2020-02-17 12:08:16 +01:00
Mislav Marohnić
3138b3b2a6
Update note about required Go version 2020-02-17 12:07:39 +01:00
Mislav Marohnić
a60a6dc621
Merge pull request #462 from gep13/chocolatey
(doc) Update Windows installation options
2020-02-17 10:40:40 +01:00
Mislav Marohnić
101fbc27e1
Reword Windows install instructions 2020-02-17 10:37:14 +01:00
Dmitry Sharshakov
b67bb55383 Correct typoes 2020-02-16 17:28:03 +03:00
Emerson Castaneda
3075af84d9 Add Go ver. note for installing from source 2020-02-15 16:08:54 -05:00
Gary Ewan Park
71b1c49227
(doc) Update Windows installation options
To include installing/upgrading from Chocolatey
2020-02-15 15:19:24 +00:00
TaKO8Ki
5c8dd70bb7 fix typo 2020-02-15 23:20:15 +09:00
Nate Smith
10ea161f92
Merge pull request #428 from vertextau/oauth-fix
Improve randomString function
2020-02-14 10:20:22 -06:00
Nate Smith
96dc4376a1
Merge pull request #429 from cli/co-drawing-board
revert pr checkout branch prefixing
2020-02-13 17:37:42 -06:00
Nate Smith
2e7feddcc4
Merge pull request #362 from cli/cross-repo-create
Cross repo pr create
2020-02-13 17:23:47 -06:00
vilmibm
c5a511a2d1 Revert "prefix branch names for local pr checkout"
This reverts commit 5b8d7c1841.
2020-02-13 17:16:53 -06:00
vertextau
95cbc56dec Improve randomString func 2020-02-13 22:42:58 +01:00
Nate Smith
15d6d4bcf0
Merge pull request #405 from arkentos/master
Fix: Nil pointer dereference while previewing PR and Issues with empty body
2020-02-13 13:19:59 -06:00
Nate Smith
65a7d05205
Merge pull request #387 from ahmedelgabri/master
Make sure editor is set properly & not overridden later
2020-02-13 13:14:41 -06:00
Nate Smith
bd97b84fb1
Merge pull request #415 from cli/dotcom-ghes-others
Add availability section to README
2020-02-13 13:11:11 -06:00
Nate Smith
be639e80b2
Merge pull request #420 from odinuge/remote-url-err
Fix wrong repo url being used for pushing
2020-02-13 13:07:36 -06:00
Odin Ugedal
12887db9c8
Fix wrong repo url being used for pushing
afaik this should be finalURL (the fork) and not initURL (the upstream),
otherwise a bit of the code above can be removed.
2020-02-13 17:30:54 +01:00
Billy Griffin
26159ddcb3
Add availability section to readme 2020-02-13 07:52:09 -07:00
Morten Linderud
1b7009087e
[Makefile] Support reproducible builds
It's bad form to embed timestamps in binaries as it prevents
reproducible builds of the resulting binary.

The Reproducible Builds project defines SOURCE_DATE_EPOCH to help
reproduce binaries by allowing the date format to be overridden. This
patch adds support for this for GNU and BSD date.

Go 1.13 introduces `-trimpath` which strips build paths from all
compiled binaries. This enables people to reproduce the distributed cli
binary without having to recreate the build path.

https://reproducible-builds.org/specs/source-date-epoch/
https://reproducible-builds.org/docs/build-path/

Signed-off-by: Morten Linderud <morten@linderud.pw>
2020-02-13 11:22:04 +01:00
Anowar Islam
2c2c8a9991
added fix for empty body in issue preview 2020-02-13 01:44:03 -08:00
Anowar Islam
8f9574be35
added fix for empty body in pr preview 2020-02-13 01:43:51 -08:00
vilmibm
212dc1da1d properly specify head ref for cross-repo/same-branch 2020-02-12 16:11:04 -06:00
Nate Smith
c27d7807a0
Merge pull request #355 from vilmibm/pr-parent-repo
More nuanced handling of parent/fork in various commands
2020-02-12 16:10:32 -06:00
Ahmed El Gabri
4a5135d820
Use if/else/if instead 2020-02-12 23:07:36 +01:00
Nate Smith
1a65c9bb6d
Merge pull request #363 from inverse/patch-1
Change AUR package
2020-02-12 13:26:11 -06:00
Malachi Soord
b6bd044cde
Change AUR package 2020-02-12 19:01:34 +01:00
vilmibm
2ff31909cd use new helper 2020-02-12 11:33:24 -06:00
Billy Griffin
6685efbe43
Merge pull request #358 from cli/update-docs-link
Update docs link to correct manual page
2020-02-12 09:16:41 -07:00
Billy Griffin
d122f1ff17
Update docs link to correct manual page 2020-02-12 09:02:25 -07:00
vilmibm
4f10a6d813 do not use local template files if overriding base repo 2020-02-12 08:57:55 -06:00
vilmibm
6732aa9725 fix tests 2020-02-12 08:48:25 -06:00
vilmibm
dd57b891d3 add helper for stubbing repo resolve response 2020-02-12 08:48:04 -06:00
vilmibm
a998a650cd still WIP, need to pause and refactor 2020-02-12 08:15:10 -06:00
vilmibm
c8a4ac66d8 start on fixing tests 2020-02-11 21:56:20 -06:00
vilmibm
135c63aa36 remove --self for now 2020-02-11 20:46:46 -06:00