Commit graph

2636 commits

Author SHA1 Message Date
Mislav Marohnić
49378fb60f Handle Ctrl-C in repo garden 2020-10-16 13:20:23 +00:00
Mislav Marohnić
02f494693c
Merge pull request #2190 from quiye/issues-data-race
Fix issue label overrides caused by pagination
2020-10-15 13:42:30 +02:00
Mislav Marohnić
e270cdb29e Simplify test to avoid use of reflect 2020-10-14 15:54:42 +02:00
Mislav Marohnić
813fbc9b8d Ensure that we don't reuse the same deserialization struct over pagination iterations
This is to avoid subtle deserialization issues in nested slices.
2020-10-14 15:38:21 +02:00
zamasu
a90b62fb6c Fix parsing labels in paginated IssueList 2020-10-14 15:32:45 +02:00
Mislav Marohnić
2565c9dc24
Merge pull request #2186 from cli/help-wanted-docs
Improve contributing documentation
2020-10-14 12:02:00 +02:00
Mislav Marohnić
bd25dae5e0 Update triaging docs 2020-10-13 18:07:05 +02:00
Mislav Marohnić
d66fd2fe9e Remove needs-user-input from "please avoid"
The user input might have come in a reply already, but the maintainers
haven't gotten around to remove the stale label yet. This shouldn't
prevent someone from submitting a PR.
2020-10-13 18:06:00 +02:00
Mislav Marohnić
ef907463d9 Fix label links 2020-10-13 18:05:27 +02:00
Mislav Marohnić
b3f64acc55 Clarify contributions section 2020-10-13 17:44:13 +02:00
Mislav Marohnić
3d734a5e7e Merge remote-tracking branch 'origin' into help-wanted-docs 2020-10-13 17:43:12 +02:00
Mislav Marohnić
bb6a571ab5 Tweak contributing guidelines 2020-10-13 16:40:40 +02:00
Mislav Marohnić
f87b684447
Merge pull request #2156 from waldyrious/patch-2
Improve installation instructions in README
2020-10-13 13:24:00 +02:00
Waldir Pimenta
10e1c5260c Suggested changes from PR review 2020-10-12 13:10:52 +01:00
Waldir Pimenta
d29fc16df9 Suggested changes from PR review 2020-10-12 11:57:43 +01:00
Waldir Pimenta
c38003d78b
Improve installation instructions
- Mention downloadable binaries for macOS and Linux
- Mention Homebrew for Linux
- Cleanup whitespace throughout the file
2020-10-11 10:57:04 +01:00
Mislav Marohnić
20f88bbd5a Update references to the help wanted label after rename
GitHub has some special behavior for the `help wanted` label, but not
the `help-wanted` label, so I've renamed ours.

Bonus: updated links to docs.github.com
2020-10-09 19:06:25 +02:00
Mislav Marohnić
a2aa07d497
Merge pull request #2134 from ShubhankarKG/updates
Update shouldCheckForUpdate
2020-10-09 18:30:48 +02:00
Mislav Marohnić
ce8f37aca2 💅 tweak update notifier 2020-10-09 18:15:28 +02:00
ShubhankarKG
78b67fabdd 1. Added GH_NO_UPDATE_NOTIFIER to hhelp_topics
2. Updated test to check if passed variable is not empty
2020-10-08 21:22:26 +05:30
Sam
338e03631c
Merge pull request #2132 from Pushpamk/documentation
updated new github doc. link
2020-10-08 17:21:35 +02:00
Pushpamk
581783176a deleted comment 2020-10-08 20:34:10 +05:30
Pushpamk
f8a49ca624 updated reference comment 2020-10-08 16:04:28 +05:30
ShubhankarKG
fa536990e6 revert accidentally committed config options 2020-10-08 12:19:17 +05:30
ShubhankarKG
3a22ab7eba Update shouldCheckForUpdate 2020-10-08 12:04:57 +05:30
Pushpamk
40a0b0d511 updated new github doc. link 2020-10-08 00:55:44 +05:30
Mislav Marohnić
0d593e78aa
Merge pull request #2056 from cli/scoop
Fix updating scoop bucket, homebrew-core formula on release
2020-10-06 15:04:06 +02:00
Mislav Marohnić
01bd0dce5e fix hub release download 2020-10-06 15:01:59 +02:00
Mislav Marohnić
38ef66a06f Improve release titles 2020-10-06 15:01:55 +02:00
Mislav Marohnić
2eab4a940f
Merge pull request #2025 from mmontes11/pr-create-use-git-branch-show-current
Avoding --short option in git symbolic-ref for getting the current branch
2020-10-06 14:31:34 +02:00
Mislav Marohnić
54e292703b
Merge pull request #2054 from cli/ghe-auth
Handle edge cases in GHE auth
2020-10-06 14:27:32 +02:00
Mislav Marohnić
115357c6af
Merge pull request #2035 from cli/ghe-2.20-compat
GHE 2.20 compatibility for `pr` commands
2020-10-06 12:50:08 +02:00
Nate Smith
14a5e00c4a
Merge pull request #2034 from cristiand391/check-gist-ownership
Check gist ownership before editing
2020-10-05 16:20:34 -05:00
Nate Smith
d63b5a9297
Merge pull request #1763 from Matt-Gleich/trunk
♻️ Refactor gist list to use graphQL
2020-10-05 16:15:39 -05:00
Nate Smith
edec480b34
Merge pull request #2057 from cli/auth-scopes-doc
Specify minimum required token scopes in `gh help auth login`
2020-10-05 16:00:25 -05:00
Nate Smith
9869b874f8
Merge pull request #2072 from jmdejong/garden-resore-terminal
restore tty settings after gh repo garden
2020-10-05 15:34:18 -05:00
vilmibm
fa68a3a858 linter appeasement 2020-10-05 15:19:49 -05:00
Nate Smith
c1af527cbc
Merge pull request #2091 from rex4539/typos
Fix typos
2020-10-05 15:03:47 -05:00
Mislav Marohnić
cd2adfeba0 Port listing gists to githubv4 GraphQL client
- Fetching more than 100 gists is now supported
- The GraphQL query name is now `GistList` instead of `ListGists` for
  consistency with other queries
- Avoid fetching unnecessary Files fields
- Gists are now rendered in the order that the API returned them in
- The gist timestamp for machine-readable output is now rendered in
  RFC3339 format instead of in `time.Time.String()` format which is only
  meant for debugging and is not considered stable
- Ensure newlines in gist description are rendered as spaces
2020-10-05 20:33:31 +02:00
Mislav Marohnić
1859728f7e Fix parsing gist list --public/--secret flags
It's not sufficient to use `Changed("public")` to test if a boolean flag
was activated, since the user might have passed `--public=false`.
Instead, check the true value of the flag.

The `--public` and `--secret` flags should be mutually exclusive, so now
if both are activated, `--secret` takes precedence.
2020-10-05 20:27:05 +02:00
Mislav Marohnić
1eb972292b
Merge pull request #2092 from antleblanc/patch-1
Add link to Homebrew and MacPorts
2020-10-05 12:05:00 +02:00
Antoine Leblanc
b047d63555
Add link to Homebrew and MacPorts 2020-10-04 21:17:48 +02:00
Dimitris Apostolou
6f550b5d12
Fix typos 2020-10-04 22:16:30 +03:00
Matthew Gleich
f124370154
♻️ Refactor to only pass time in once for test
Signed-off-by: Matthew Gleich <email@mattglei.ch>
2020-10-04 15:02:13 -04:00
Matthew Gleich
d8ef8b836e
🐛 Fix stubs
Signed-off-by: Matthew Gleich <email@mattglei.ch>
2020-10-04 01:57:36 -04:00
troido
974c6d8958 restore tty settings after gh repo garden
the command 'gh repo garden' used to leave the terminal in noecho mode when exiting

This restores the tty settings to their state before running 'gh repo garden'
2020-10-03 11:01:38 +02:00
Mislav Marohnić
70412ef06a Add trailing newline 2020-10-02 17:48:40 +02:00
Mislav Marohnić
2376c81460 Fix scoop-gen 2020-10-02 17:48:34 +02:00
Mislav Marohnić
7663acdc29 Improve HTTP caching layer
- make thread-safe
- only cache GET, HEAD, and GraphQL requests
- only cache non-5xx, non-403 responses
- include `Accept` and `Authorization` headers in cache key
2020-10-02 15:19:40 +02:00
Mislav Marohnić
f7a82a216b Avoid error from cache file being prematurely closed
I have no idea what's going on there, so I'll just give up the streaming
approach and read the entire contents of the cache file to memory.

https://github.com/cli/cli/pull/2035/checks?check_run_id=1194798056
2020-10-01 22:06:15 +02:00