Commit graph

7230 commits

Author SHA1 Message Date
vilmibm
3bd1d6770c fix variable name 2023-05-24 12:40:46 -07:00
William Martin
2717dc5758 Add cmd test for pr status with counts by state 2023-05-24 16:00:34 +02:00
William Martin
e2dc66baea Reorder Check and Status States enums variants alphabetically 2023-05-23 17:36:20 +02:00
William Martin
dad5f25748 Use go enums for status and check status graphql enums 2023-05-23 17:22:56 +02:00
William Martin
505c954544 Remove unused emptyIntrospectionFor test helper 2023-05-23 17:13:48 +02:00
William Martin
b73ad06f15 Avoid setting status check rollups when user supplies fields 2023-05-23 16:53:16 +02:00
William Martin
04ecac9a6f Rework state parsing for CheckRuns and StatusContexts 2023-05-23 16:51:08 +02:00
William Martin
90e680f21a Split CheckRunState and StatusState parsing 2023-05-23 15:59:12 +02:00
William Martin
b02d5efb18 Use two queries in one request for PR feature detection 2023-05-23 15:42:38 +02:00
Mislav Marohnić
9846af16eb
Merge pull request #7477 from cli/jtpetty/issue-7024-take-2
Updated to sanitize asset filename prior to uploading. Fixes #7024
2023-05-23 11:18:12 +02:00
Mislav Marohnić
cb33bce8c1
Merge pull request #7474 from cli/bump-browser
Update browser package to avoid Windows crash
2023-05-23 11:13:31 +02:00
vilmibm
a15eb91a0c go generate 2023-05-23 00:13:57 -07:00
vilmibm
5597139df3 switch to []int return for multiselect 2023-05-23 00:12:44 -07:00
vilmibm
bfdd6e9c4b Merge remote-tracking branch 'upstream' into run-prompts 2023-05-22 23:46:04 -07:00
Tommy Petty
e9ff00bd01 Updated to sanitize asset filename prior to uploading. Fixes #7024 2023-05-22 15:29:48 -04:00
William Martin
c90b87bdad Remove unused prInstrospection fixture 2023-05-22 18:46:28 +02:00
William Martin
42b61ad53e Inject fake detector into PR status tests 2023-05-22 18:44:51 +02:00
William Martin
cdd05a38c6 Move CheckRunAndStatusContextCounts feature detection up stack 2023-05-22 17:32:52 +02:00
William Martin
75e35e2dde Use pseudo field for statusCheckRollupWithCountByState 2023-05-22 17:28:15 +02:00
William Martin
6f4038d981
Merge pull request #7476 from cli/dependabot/go_modules/github.com/mattn/go-isatty-0.0.19
build(deps): bump github.com/mattn/go-isatty from 0.0.18 to 0.0.19
2023-05-22 17:18:45 +02:00
dependabot[bot]
0a3c5726b7
build(deps): bump github.com/mattn/go-isatty from 0.0.18 to 0.0.19
Bumps [github.com/mattn/go-isatty](https://github.com/mattn/go-isatty) from 0.0.18 to 0.0.19.
- [Commits](https://github.com/mattn/go-isatty/compare/v0.0.18...v0.0.19)

---
updated-dependencies:
- dependency-name: github.com/mattn/go-isatty
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-05-22 15:00:08 +00:00
Mislav Marohnić
aee2a11a22
Merge pull request #7475 from torgeir/clarify-wording-listing-workflows
Clarify docs regarding what is listed when running gh workflow list
2023-05-22 14:29:45 +02:00
Torgeir Thoresen
70678b7333
Clarify docs regarding what is listed when running gh workflow list
Prevent confusion that `--all` actually list all workflows, `--limit` is
what actually needs to be adjusted to list all workflows, if there are
many.
2023-05-22 13:48:18 +02:00
William Martin
9e45b0b2d9
Merge pull request #7473 from cli/wm/update-triage-with-sev-descriptions
Update triage.md with severity descriptions
2023-05-22 13:11:44 +02:00
Mislav Marohnić
917c1faa71
Update browser package to avoid Windows crash 2023-05-22 12:31:05 +02:00
William Martin
bf5427a653
Update triage.md with severity descriptions 2023-05-22 12:19:37 +02:00
Nate Smith
bd65e488a4
Merge pull request #7469 from cli/dependabot/go_modules/github.com/stretchr/testify-1.8.3
build(deps): bump github.com/stretchr/testify from 1.8.2 to 1.8.3
2023-05-19 10:37:45 -07:00
vilmibm
8a605fbaf5 Merge remote-tracking branch 'upstream/trunk' into run-prompts 2023-05-19 10:25:18 -07:00
dependabot[bot]
d8888f2641
build(deps): bump github.com/stretchr/testify from 1.8.2 to 1.8.3
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.2 to 1.8.3.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](https://github.com/stretchr/testify/compare/v1.8.2...v1.8.3)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-05-19 14:58:34 +00:00
Josh Kraft
2e5a728338
Merge branch 'trunk' into gh-cache-command 2023-05-17 14:34:10 -06:00
William Martin
ebb7d26f3a Implement initial spike for detecting and using counts by state 2023-05-17 19:59:03 +02:00
William Martin
bfd3c7b20b Short circuit status check GQL introspection for GitHub.com 2023-05-17 18:45:25 +02:00
William Martin
c2e3dae602 Add support for detecting status and check counts in GQL 2023-05-17 18:45:25 +02:00
William Martin
9d81c1134d Implement parsing and counting of PR checks using new GQL fields 2023-05-17 18:45:25 +02:00
William Martin
1081e51648
Merge pull request #7460 from cli/dependabot/go_modules/github.com/stretchr/testify-1.8.2
build(deps): bump github.com/stretchr/testify from 1.8.1 to 1.8.2
2023-05-17 17:20:19 +02:00
William Martin
5ec494f00d
Merge pull request #7454 from cli/wm/pull-request-checks-status-confidence
Get some additional confidence around PullRequest ChecksStatus
2023-05-17 17:05:07 +02:00
dependabot[bot]
4a76659996
build(deps): bump github.com/stretchr/testify from 1.8.1 to 1.8.2
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.1 to 1.8.2.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](https://github.com/stretchr/testify/compare/v1.8.1...v1.8.2)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-05-17 14:58:44 +00:00
Mislav Marohnić
c5fc35527e
Merge pull request #7459 from cli/bump-wincred
Fix windows crash by bumping wincred
2023-05-17 15:25:12 +02:00
William Martin
7e2bac89bd
Remove old, unused detector fields (#7458) 2023-05-17 14:50:28 +02:00
Mislav Marohnić
83d6dc5878
Fix windows crash by bumping wincred 2023-05-17 14:43:31 +02:00
William Martin
bfb5e8f1d6 Avoid using named return in PR ChecksStatus
See: https://dave.cheney.net/practical-go/presentations/gophercon-israel.html#_avoid_named_return_values
2023-05-16 19:53:35 +02:00
William Martin
c4bb344ddd Add some comments to PR ChecksStatus 2023-05-16 19:53:35 +02:00
William Martin
cd8547b227 Add some further test coverage around PR ChecksStatus 2023-05-16 19:53:35 +02:00
Sam Coe
f77a3dcacb
Do not fall back to legacy template if template selector returns nil (#7444) 2023-05-16 09:44:00 +12:00
Nate Smith
4af21f71c0
Merge pull request #7445 from ffalor/7216
respect GH_REPO env variable in `pr create`
2023-05-15 13:51:40 -07:00
Nate Smith
7b78e3204e
Merge pull request #7449 from goldstar611/patch-1
Mention setting GH_ENTERPRISE_TOKEN when GH_HOST is set
2023-05-15 11:07:42 -07:00
Tony F
ae3e879480
Mention setting GH_ENTERPRISE_TOKEN
When GH_HOST is set
2023-05-15 10:49:45 -05:00
ffalor
ff991c3c84
Merge branch 'trunk' into 7216 2023-05-15 09:57:07 -05:00
Rick Kilgore
0d110ea8bf
survey: fix color contrast of default values in prompts (#7354) 2023-05-15 11:47:53 +02:00
ffalor
ae58b7714c respect GH_REPO env variable in pr create 2023-05-14 22:38:49 -05:00