Commit graph

2458 commits

Author SHA1 Message Date
Amanda Pinsker
51d6bcb4f1
Merge pull request #1638 from cli/readme-updates
Update README.md
2020-09-16 13:08:32 -04:00
Amanda Pinsker
2570f13768
Merge branch 'trunk' into readme-updates 2020-09-16 13:02:56 -04:00
Mislav Marohnić
b2e36a0979
Merge pull request #1706 from cli/base-resolve
Improve repository base and head resolution
2020-09-16 18:53:21 +02:00
Nate Smith
bdadb3058b
Merge pull request #1699 from cli/more-gists
bunch of gist stuff
2020-09-16 11:36:54 -05:00
vilmibm
7c986c0454 help typo 2020-09-16 11:23:14 -05:00
Mislav Marohnić
6d0da077b6
Merge pull request #1631 from cli/color-env
Add support for CLICOLOR standard
2020-09-16 18:20:13 +02:00
Mislav Marohnić
cd32ef8389
Merge pull request #1708 from cli/wsl-detection
Fallback browser when `xdg-open` does not exist
2020-09-16 18:16:27 +02:00
vilmibm
2b70e8266a better time stub 2020-09-16 10:57:20 -05:00
Mislav Marohnić
b2de27c624 Fix Survey's presentation of default values
For default values for e.g. `Input` prompts, Survey uses the literal "white" color, which makes no sense on dark terminals and is literally invisible on light backgrounds.

This overrides Survey to output a gray color for 256-color terminals and "default" for basic terminals.
2020-09-16 17:57:13 +02:00
Mislav Marohnić
88aacc14f0 Fix gray color presentation across terminals
We used to send the ANSI sequence for "bright black" when we wanted gray, but this color turns out to not be visible in some popular color schemes.

Instead, when we detect a 256-color terminal, switch to displaying a color sequence for gray that is consistent and does not depend on terminal color scheme.
2020-09-16 17:57:13 +02:00
Sam Coe
9058feebec
Fix up structure for better testing 2020-09-16 17:19:11 +02:00
Sam Coe
fd1d09dfc2
Clean up linux logic to have better default logic 2020-09-16 16:56:47 +02:00
Mislav Marohnić
086d8ed29a Merge remote-tracking branch 'origin' into color-env 2020-09-16 16:51:38 +02:00
Mislav Marohnić
3049db646f
Merge pull request #1630 from cli/pager-for-everyone
Extend PAGER support to all commands producing significant output
2020-09-16 16:22:58 +02:00
Mislav Marohnić
fa2513dea6 Document PAGER environment variable 2020-09-16 16:15:57 +02:00
Mislav Marohnić
f6dd1bcd0a Add the pager config option 2020-09-16 16:15:37 +02:00
Mislav Marohnić
c643778701 Have only one test assert default config rendering 2020-09-16 16:10:53 +02:00
Sam Coe
7551139caf
Address PR comments 2020-09-16 16:04:58 +02:00
Mislav Marohnić
00ac966c65 Merge remote-tracking branch 'origin' into pager-for-everyone 2020-09-16 15:58:54 +02:00
Mislav Marohnić
5a2c7e7957
Merge pull request #1707 from cli/fix-zsh-autocomplete
Remove square brackets from persistent flag description to fix zsh autocomplete
2020-09-16 15:53:41 +02:00
Sam Coe
dd1c24a20a
Use LookPath to determine if xdg-open exists 2020-09-16 15:52:34 +02:00
Mislav Marohnić
f99a55438f Remove issue create examples from pr create 2020-09-16 15:48:13 +02:00
Mislav Marohnić
f9239661f2 Reuse the StubRepoInfoReponse test helper 2020-09-16 15:01:13 +02:00
Mislav Marohnić
7a8db80420 Prompt for push target during pr create
We no longer guess the head repository using heuristics; instead, we
present the user with the choice of pushable repositories and an
additional option to create a new fork.

The new `pr create --head` flag is available for the user to specify the
head branch in `branch` or `owner:branch` format and completely skip any
forking or auto-pushing checks.
2020-09-16 14:49:36 +02:00
Sam Coe
6d111b2458
Use WSL2 detection to pick browser 2020-09-16 14:45:06 +02:00
Sam Coe
3f3c781ab6
Remove square brackets from persistent flag description to fix zsh autocomplete 2020-09-16 11:47:15 +02:00
vilmibm
0d45dd82f3 finish edit tests 2020-09-15 17:29:54 -05:00
vilmibm
15cf786c5a wip tests 2020-09-15 17:20:36 -05:00
vilmibm
a9ab2a98fc move Edit to opts for testing 2020-09-15 17:04:43 -05:00
vilmibm
62f54f0f02 start on edit tests 2020-09-15 16:18:26 -05:00
vilmibm
ada2c56606 test gist view 2020-09-15 16:05:30 -05:00
vilmibm
4a467864d5 linter appeasement 2020-09-15 15:22:28 -05:00
vilmibm
f124b426fe tweak gist view; support --filename 2020-09-15 14:56:13 -05:00
vilmibm
a61c897e4c show filename if no description 2020-09-15 14:55:55 -05:00
vilmibm
ba5b639be4 finish list tests 2020-09-15 14:33:14 -05:00
Mislav Marohnić
d534a94d1b Change how base repository is resolved
On first run in a git repository, `BaseRepo()` will now prompt the user
which repository should be queried as base repository if there are
multiple git remotes or when we are in the context of a fork.

In non-interactive mode, the prompt is skipped and we default to the
first git remote instead.

After the base repo is resolved, the result is cached in the local
repository using `git config` so that RepositoryNetwork API lookups can
be avoided in the future.
2020-09-15 21:27:12 +02:00
vilmibm
9fd87faadc wip tests 2020-09-15 14:15:44 -05:00
vilmibm
425f707c7d fix tests 2020-09-15 13:36:32 -05:00
vilmibm
0af61ff1ff Merge remote-tracking branch 'origin/trunk' into more-gists 2020-09-15 13:25:06 -05:00
Nate Smith
2071c72a05
Merge pull request #1705 from cli/feedback-tmpl
add issue template for general feedback
2020-09-15 13:01:04 -05:00
Mislav Marohnić
969321bff2 🔥 cleanup in context 2020-09-15 19:09:16 +02:00
Nate Smith
50211eade3
add issue template for general feedback
is this a good idea?
2020-09-15 12:00:07 -05:00
Sam
4933fd9415
Merge pull request #1696 from cli/env-help-topic
Extract environment variables as a separate help topic
2020-09-15 17:21:32 +02:00
Nate Smith
9f486efbc6
hackday: gh repo garden (#1049)
* add gh repo garden

* move file

* oops

* fixes

* fix clearing

* block windows sadly

* broken wip

* fix api thing

* do not add to client

* move helper as it does not work on windows

* hide command

* macos fix

* Update pkg/cmd/repo/garden/garden.go

Co-authored-by: Lee Reilly <lee@github.com>

* default for key input loop

* get redrawing working

* clean up garden update, it all works

* notes

* fix arrow keys and just do wads/arrows/vi

* this function is only called once now

* support ghes

* add a progress indicator

* cap maxCommits

Co-authored-by: Lee Reilly <lee@github.com>
2020-09-15 09:59:27 -05:00
Nate Smith
6d63e37466
Merge pull request #1704 from cristiand391/cristiand391-patch-1
Go 1.15+ is required to run the test suit
2020-09-15 09:54:47 -05:00
vilmibm
1887fc07c9 working on list tests, need to debug 2020-09-15 09:39:30 -05:00
Nate Smith
0c0e042e72
Merge pull request #1642 from cli/web-flag
support auth login --web
2020-09-15 09:37:41 -05:00
Mislav Marohnić
8b9d4274b7
Merge pull request #1697 from cli/release-download-fix
Fix `release download`
2020-09-15 15:12:59 +02:00
Mislav Marohnić
50291aa6de Add PAGER support to the api command 2020-09-15 11:43:49 +02:00
Cristian Dominguez
3d350e8707
Go 1.15+ is required to run the test suit 2020-09-14 20:31:22 +00:00