Alan Donovan
|
57d9b1a9e1
|
create: decode JSON error heuristically
|
2021-09-27 14:51:52 -04:00 |
|
Mislav Marohnić
|
8807b3a73a
|
Merge pull request #184 from github/args-constraint
Consistently institute constraints for position arguments and improve error message
|
2021-09-24 16:02:36 +02:00 |
|
Mislav Marohnić
|
92d0abd6ab
|
Merge pull request #79 from github/raffo/delete-codespaces
Add code and command to delete unused codespaces
|
2021-09-24 16:02:05 +02:00 |
|
Mislav Marohnić
|
3d017b2824
|
Fix stderr output on delete errors
|
2021-09-24 15:09:41 +02:00 |
|
Jose Garcia
|
4eb15134a4
|
Merge pull request #189 from github/jg/inline-go-liveshare
Inline go-liveshare v0.20.0
|
2021-09-23 13:45:11 -04:00 |
|
Jose Garcia
|
5d6ea5029e
|
Linter fixes
|
2021-09-23 13:36:04 -04:00 |
|
Jose Garcia
|
65dcb0f428
|
Linter fixes
|
2021-09-23 13:22:20 -04:00 |
|
Jose Garcia
|
08bc181d79
|
Linter fixes
|
2021-09-23 13:16:20 -04:00 |
|
Jose Garcia
|
b8f35f950c
|
Linter fixes
|
2021-09-23 13:14:35 -04:00 |
|
Mislav Marohnić
|
75c1dfdf49
|
Fetch codespace by name directly if name argument given
|
2021-09-23 18:57:22 +02:00 |
|
Jose Garcia
|
c4114cc972
|
Linter fixes
|
2021-09-23 11:58:55 -04:00 |
|
Jose Garcia
|
fb53ccb06a
|
Linter fixes
|
2021-09-23 11:56:41 -04:00 |
|
Jose Garcia
|
958990cef8
|
More linter fixes
|
2021-09-23 11:47:52 -04:00 |
|
Jose Garcia
|
d0c65e5490
|
Linter fixes
|
2021-09-23 11:36:27 -04:00 |
|
Jose Garcia
|
f4396e8f1a
|
Inline go-liveshare with history
|
2021-09-23 11:28:04 -04:00 |
|
Jose Garcia
|
9ae7eb5869
|
Merge branch 'go-liveshare-download' into jg/inline-go-liveshare
|
2021-09-23 11:19:46 -04:00 |
|
Jose Garcia
|
6ca35d0e73
|
Moved files to liveshare dir
|
2021-09-23 11:18:49 -04:00 |
|
Mislav Marohnić
|
e8212a80a9
|
Print delete failures as they occur
|
2021-09-23 17:14:25 +02:00 |
|
Mislav Marohnić
|
1232dba684
|
Merge remote-tracking branch 'origin' into raffo/delete-codespaces
|
2021-09-23 16:43:22 +02:00 |
|
Jose Garcia
|
3e26a15342
|
Merge pull request #188 from github/jg/update-liveshare
Update to go-liveshare v0.20.0
|
2021-09-23 10:22:09 -04:00 |
|
Jose Garcia
|
f1c35ba9da
|
Update docs
|
2021-09-23 10:21:01 -04:00 |
|
Jose Garcia
|
fb12f4108f
|
Merge pull request #181 from github/jg/poll-on-async-creation
ghcs create: poll for codespaces that are being retried by the server
|
2021-09-23 10:10:57 -04:00 |
|
Jose Garcia
|
a3c900c3b9
|
Merge pull request #185 from github/jg/buffer-channels
Add buffered to channels to avoid goroutine leak
|
2021-09-23 10:07:56 -04:00 |
|
Jose Garcia
|
9654dc4bd3
|
Update to go-liveshare v0.20.0
|
2021-09-23 10:07:14 -04:00 |
|
Jose Garcia
|
186b90b12e
|
Rename request type
|
2021-09-23 08:29:24 -04:00 |
|
Jose Garcia
|
13d7804a35
|
Remove API test, inline poller
|
2021-09-23 08:26:23 -04:00 |
|
Jose Garcia
|
4e0ac15fe0
|
Add buffer to channels to avoid goroutine leak
|
2021-09-22 15:10:47 -04:00 |
|
Jose Garcia
|
9a558bc58c
|
Early return if polling is not required
- Add context to errors in poller
|
2021-09-22 15:03:12 -04:00 |
|
Mislav Marohnić
|
7a91ba5942
|
Print usage help when args given to "NoArgs" commands
|
2021-09-22 19:51:12 +02:00 |
|
Mislav Marohnić
|
a55f7af92c
|
Correct wrong args constraints
|
2021-09-22 19:36:25 +02:00 |
|
Jose Garcia
|
208f1721b5
|
Rename ProvisionCodespaceParams
|
2021-09-22 13:21:02 -04:00 |
|
Jose Garcia
|
70a2ea2e6a
|
PR Feedback
- Rename ProvisionCodespace -> CreateCodespace
- Rename createCodespace -> startCreate
- Additional docs/comments
- Simplify ProvisionCodespaceParams
|
2021-09-22 13:19:26 -04:00 |
|
Jose Garcia
|
d2d21996bc
|
Move ProvisionCodespace to API client
- Make CreateCodespace private along with its errors
|
2021-09-22 11:49:41 -04:00 |
|
Mislav Marohnić
|
32d3a38465
|
Name of the codespace
|
2021-09-22 16:39:50 +02:00 |
|
Mislav Marohnić
|
cb7b535b91
|
Add tests for delete
|
2021-09-22 16:11:34 +02:00 |
|
Jose Garcia
|
8c5330d9e9
|
Rename error
|
2021-09-22 10:04:18 -04:00 |
|
Jose Garcia
|
2a0ea1617b
|
Handle specific error for GetCodespaceToken
|
2021-09-22 09:40:45 -04:00 |
|
Jose Garcia
|
86717f14a1
|
Implement codespaces.Provision
- Move polling logic into the Provision function
- Document the behavior expected of callers when an ErrCreateAsyncRetry
is returned
|
2021-09-22 09:09:09 -04:00 |
|
Alan Donovan
|
770151313f
|
Merge pull request #22 from github/connect
Merge NewClient and JoinWorkspace into Connect
|
2021-09-22 08:55:26 -04:00 |
|
Jose Garcia
|
48e3473a95
|
PR Feedback
- Bring context.Timeout into the poller
- Accept duration and interval
- Other tidy up
|
2021-09-21 18:18:30 -04:00 |
|
Alan Donovan
|
f8a8713520
|
refactor Options API
|
2021-09-21 15:27:23 -04:00 |
|
Mislav Marohnić
|
d2113e3b59
|
Merge branch 'mislav/delete-codespaces' into raffo/delete-codespaces
|
2021-09-21 21:10:29 +02:00 |
|
Mislav Marohnić
|
678da44c28
|
Simplify delete further
|
2021-09-21 21:09:26 +02:00 |
|
Mislav Marohnić
|
ab86739b6b
|
Merge remote-tracking branch 'origin' into mislav/delete-codespaces
|
2021-09-21 20:35:58 +02:00 |
|
Jose Garcia
|
861811baf0
|
Upgrade pkg name after merge
|
2021-09-21 14:02:05 -04:00 |
|
Jose Garcia
|
d5b03df406
|
Merge branch 'main' of github.com:github/ghcs into jg/poll-on-async-creation
|
2021-09-21 14:01:37 -04:00 |
|
Alan Donovan
|
b3b675d108
|
Merge NewClient and JoinWorkspace into Connect
|
2021-09-21 12:44:30 -04:00 |
|
Jose Garcia
|
323462ca5c
|
Poll codespace on ErrCreateAsyncRetry error
- Introduce tests for the poller
- Attempt to fetch codespace for 2 mins
|
2021-09-21 12:37:11 -04:00 |
|
Mislav Marohnić
|
090e0c81a1
|
Merge pull request #171 from github/cli-migration
Split out "main" package from "ghcs"
|
2021-09-21 18:06:06 +02:00 |
|
Mislav Marohnić
|
683d847dd2
|
Merge remote-tracking branch 'origin' into cli-migration
|
2021-09-21 17:38:41 +02:00 |
|