Commit graph

456 commits

Author SHA1 Message Date
Nate Smith
58a6cbc46e Merge pull request #179 from github/pr-checks-test
Add tests for `pr status` reviews, checks, and blank slate output
2019-12-19 15:33:06 -06:00
Nate Smith
c852db7708 Merge pull request #180 from github/pr-status-green
Print `pr status` numbers in green
2019-12-19 15:31:35 -06:00
Nate Smith
05b92dbb95 Merge pull request #168 from github/goodbye-migration
Remove migration function
2019-12-19 15:19:01 -06:00
Nate Smith
839e4114df Merge pull request #148 from github/msi-action
Automate Windows packaging
2019-12-19 15:08:25 -06:00
vilmibm
06d90d5e46 automatically produce MSI files for releases
This commit:

- Adds config for building Windows installers
- Adds an action for fetching exe files built by goreleaser
- Adds an action for building Windows installers
- Adds an action for adding MSI files to an existing GH release
- Adds MSI signing to our release flow
- Disables homebrew formula bumping for prereleases
- Allows the release asset copying action to copy windows assets
2019-12-19 15:03:03 -06:00
Nate Smith
67c4d5cdc0 Merge pull request #183 from github/draft-code-of-conduct
Add code-of-conduct.md
2019-12-19 14:59:23 -06:00
Lee Reilly
1b6ca046e5 Add first draft of CODE-OF-CONDUCT.md 2019-12-19 12:40:03 -08:00
Mislav Marohnić
f46380550c Merge pull request #171 from github/repo-language
Clarify repo flag language
2019-12-19 18:57:11 +01:00
Mislav Marohnić
f39d57862d Clarify -R format 2019-12-19 18:55:31 +01:00
Mislav Marohnić
3346e7b8dc Print pr status numbers in green
We use green to signify "open" state of issues & PRs in `list` commands
(as opposed to red for "closed" and purple for "merged" state), so let's
be consistent in `status` commands too, where all displayed items are
guaranteed to be open.
2019-12-19 17:50:44 +01:00
Mislav Marohnić
9ddd50ffa9 Add tests for pr status reviews and checks output 2019-12-19 17:37:57 +01:00
Mislav Marohnić
fd1da2f0f0 Add test for pr status blank slate 2019-12-19 16:54:24 +01:00
Amanda Pinsker
de814595f5 Clarify repo flag language 2019-12-17 11:22:41 -05:00
Nate Smith
ea91d0d4b9 Merge pull request #170 from github/git-branch
Simplify reading current branch from git
2019-12-17 09:33:03 -06:00
Nate Smith
9454bd61ee Merge pull request #164 from github/site-docs-fix
Improve `site-docs` make task
2019-12-17 09:27:30 -06:00
Mislav Marohnić
f0801b2deb Simplify reading current branch from git 2019-12-17 14:45:24 +01:00
Mislav Marohnić
2c94616969 Merge pull request #161 from github/stderr-tests
Assert stdout separarely from stderr in command tests
2019-12-17 12:43:09 +01:00
Mislav Marohnić
4ad89829c5 Merge remote-tracking branch 'origin/master' into stderr-tests 2019-12-17 12:42:01 +01:00
Corey Johnson
63f35f6834 goodbye migration 2019-12-16 15:56:45 -08:00
Corey Johnson
1b25aa7369 Merge pull request #156 from github/one-place-for-config-dir
Consolidate references to the config dir
2019-12-16 14:50:37 -08:00
Nate Smith
fcf00bd870 Merge pull request #163 from github/release-date
Simplify date format in gh version information
2019-12-16 10:54:15 -06:00
Nate Smith
00da5c2788 Merge pull request #158 from github/issue-create-web
Add "Opening URL in your browser" notice to `issue create --web`
2019-12-16 10:53:31 -06:00
Nate Smith
82fbbb28e8 Merge pull request #162 from github/gh-help-lines
Avoid long first line of gh help
2019-12-16 10:53:00 -06:00
Nate Smith
3dcadd73bd Merge pull request #159 from github/no-issues-assigned-notice
Fix displaying "There are no issues assigned to you" notice
2019-12-16 10:35:58 -06:00
Nate Smith
5434bf47ab Merge pull request #160 from github/win-test
Fix test on Windows
2019-12-16 09:51:44 -06:00
Mislav Marohnić
a7f59bfb15 Improve site-docs make task
This ensures that upstream changes to the `gh-pages` branches are pulled
before trying to upload new site docs.
2019-12-16 15:59:46 +01:00
Mislav Marohnić
1d9ad0001b Simplify date format in gh version information
Currently, goreleaser injects the date that includes time & timezone
information, but this is visually noisy. This configures it to inject
the simpler `2019-12-16` date format into the build, which also matches
what our Makefile does in development.
2019-12-16 15:56:45 +01:00
Mislav Marohnić
030c997301 Avoid long first line of gh help
This splits help text over paragraphs and lines to make the output of
`gh` easier to read. It takes care not to go over 80 characters in width
and wraps the URL in `<...>` which will help the URL get auto-linked
when these docs are converted to man and HTML formats.
2019-12-16 15:55:21 +01:00
Mislav Marohnić
48aeff1ca7 Assert stdout separarely from stderr in command tests
This stubs stderr separately from stdout in command tests (before those
streams were combined) and improves test assertions around output.

Additionally, no longer use the `cmd.Print*()` family of Cobra functions
because their name sounds like the text will go to stdout, but they
write to stderr instead. Use the more explicit `cmd.ErrOrStderr()` as
output destination instead.
2019-12-16 15:46:42 +01:00
Mislav Marohnić
d7513ef3f6 Fix test assertion when running on Windows 2019-12-16 14:56:44 +01:00
Mislav Marohnić
57c7266328 Fix displaying "There are no issues assigned to you" notice 2019-12-16 14:08:55 +01:00
Mislav Marohnić
5d6b095f1a Add "Opening URL in your browser" notice to issue create --web 2019-12-16 13:39:22 +01:00
Corey Johnson
d1905f5824 update comment 2019-12-13 16:17:28 -08:00
Corey Johnson
9becb5f790 Have one place manage the config dir location 2019-12-13 16:16:46 -08:00
Mislav Marohnić
e93ab66107 Merge pull request #147 from github/pr-to-pull-request
Consistently use "pull request" instead of "PR" in user-facing copy
2019-12-13 17:14:17 +01:00
Mislav Marohnić
caa1c49c6c Merge pull request #151 from github/less-aggressive-checking
Only check for new version once every 24 hours
2019-12-13 17:09:26 +01:00
Mislav Marohnić
b7191e3a6f Simplify case when state.yml is non-existent or corrupt
- non-existent file simply returns an error
- corrupt file (e.g. YAML unmarshal error) also returns an error
- if there were errors, just check for new release normally instead of aborting
2019-12-13 17:04:07 +01:00
Corey Johnson
0bfd8213e2 Merge pull request #144 from github/better-better-better
Better error messages when you don't supply an arg
2019-12-12 11:31:26 -08:00
Corey Johnson
2979c5fc4c Use embeding 2019-12-12 11:27:22 -08:00
Corey Johnson
9b5f7a8148 Use new error.As method 2019-12-12 11:09:50 -08:00
Corey Johnson
10ca1e7646 Whitespace cleanup 2019-12-11 16:53:00 -08:00
Corey Johnson
23fdd730e9 Less 🌭 2019-12-11 16:52:16 -08:00
Corey Johnson
6f339285b5 Whoops 2019-12-11 16:48:48 -08:00
Corey Johnson
9428df4597 Fix tests 2019-12-11 16:48:33 -08:00
Corey Johnson
deac6da2f4 Add state yml 2019-12-11 15:53:46 -08:00
Nate Smith
0f970e6328 Merge pull request #150 from github/vilmibm-patch-1
s/-B/-T
2019-12-11 15:51:55 -06:00
Nate Smith
995093591b s/-B/-T 2019-12-11 15:03:23 -06:00
Corey Johnson
92642f4d53 Create NotFoundError 2019-12-11 10:58:59 -08:00
Corey Johnson
2218e60264 Label as pull request 2019-12-11 10:24:58 -08:00
Corey Johnson
573dda22a1 Simplify flag setting 2019-12-11 10:19:18 -08:00