STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
4604 commits 87 branches 0 tags 160 MiB
Commit graph

64 commits

Author SHA1 Message Date
Mislav Marohnić
f749590e87 Replace old "github/ghcs" import statements 2021-09-28 16:57:56 +02:00
Mislav Marohnić
ca0f89d3bc Introduce an App struct that executes core business logic 
The Cobra commands are now a light wrapper around the App struct.

Co-authored-by: Jose Garcia <josebalius@github.com>
 2021-09-24 17:20:34 +02:00
Mislav Marohnić
8807b3a73a Merge pull request #184 from github/args-constraint 
Consistently institute constraints for position arguments and improve error message
 2021-09-24 16:02:36 +02:00
Jose Garcia
f4396e8f1a Inline go-liveshare with history 2021-09-23 11:28:04 -04:00
Jose Garcia
4e0ac15fe0 Add buffer to channels to avoid goroutine leak 2021-09-22 15:10:47 -04:00
Mislav Marohnić
7a91ba5942 Print usage help when args given to "NoArgs" commands 2021-09-22 19:51:12 +02:00
Mislav Marohnić
a55f7af92c Correct wrong args constraints 2021-09-22 19:36:25 +02:00
Mislav Marohnić
683d847dd2 Merge remote-tracking branch 'origin' into cli-migration 2021-09-21 17:38:41 +02:00
Jose Garcia
e8e914c220 PR Feedback 
- Upgrade to go-liveshare v0.19.0
- Remove export helper method
- Use local implementation
 2021-09-21 10:05:48 -04:00
Jose Garcia
7f682f9c39 Close Live Share sessions 
- New helper method codespaces.CloseSession to be used using defer
- Upgrade to go-liveshare v0.17.0
 2021-09-20 16:56:57 -04:00
Mislav Marohnić
8c0c7a8e19 Make GITHUB_TOKEN configurable through Go member 
Co-authored-by: Jose Garcia <josebalius@github.com>
 2021-09-17 16:29:35 +02:00
Mislav Marohnić
c2f3537a32 Separate "main" package from "ghcs" package 
To make "ghcs" importable, this separates out the `main()` function into
its own package that lives under "cmd/ghcs/main". Typically the main
package would be called "cmd/ghcs", but we wanted to leave the current
ghcs implementation where it is to avoid causing conflicts with current
work in progress.

Co-authored-by: Jose Garcia <josebalius@github.com>
 2021-09-17 16:26:20 +02:00
Mislav Marohnić
dbb4e0c177 Merge remote-tracking branch 'origin' into ruleguard 2021-09-16 11:46:50 +02:00
Alan Donovan
06719866c9 move api to internal/ 2021-09-15 13:13:10 -04:00
Mislav Marohnić
fb5a35568c Ensure original errors are wrapped with "%w" instead of "%v" 2021-09-15 13:58:41 +02:00
Jose Garcia
f5adc9e3a7 remove all deprecation messages and deprecated functionality 2021-09-13 10:58:00 -04:00
Jose Garcia
9b9e533cb9 add comment for special handling 2021-09-10 13:32:30 -04:00
Jose Garcia
fe2d5ebf37 merge upstream + pr feedback 2021-09-09 17:22:07 -04:00
Alan Donovan
cbb8253544 consolidate survey functions 2021-09-09 11:57:37 -04:00
Jose Garcia
230bf640c5 global flag, choose codespace when empty 2021-09-09 11:06:18 -04:00
Jose Garcia
3a4088a31c Merge branch 'main' of github.com:github/ghcs into jg/ports-flags 2021-09-09 10:19:23 -04:00
Alan Donovan
9e81dc7fde fix missing error return 2021-09-03 12:56:47 -04:00
Alan Donovan
2c660fa2e5 avoid ListenTCP helper 2021-09-03 12:55:40 -04:00
Alan Donovan
43198b24aa use errgroup 2021-09-03 12:50:11 -04:00
Jose Garcia
9dbf267e54 codespace flag, deprecate argument 2021-09-03 12:33:47 -04:00
Alan Donovan
a56a84947a Update ghcs for go-liveshare@v0.12.0 2021-09-03 10:11:29 -04:00
Alan Donovan
786a631995 fix local/remote confusion in getPorts (!) 2021-09-02 17:21:24 -04:00
Alan Donovan
981b2545bc sketch of changes for https://github.com/github/go-liveshare/pull/13 2021-09-02 17:08:17 -04:00
Alan Donovan
1162c8adff fix go vet loopclosure finding 2021-09-02 16:02:09 -04:00
Alan Donovan
4e2c20606a Merge branch 'main' into join-session 2021-09-02 15:57:34 -04:00
Alan Donovan
cee761238b update go-liveshare@v0.11.0 2021-09-02 15:54:00 -04:00
Alan Donovan
3485bacc97 fix StartSharing data race 2021-09-02 15:53:56 -04:00
Alan Donovan
8570f4111d sketch after API changes in go-liveshare#11 2021-09-02 12:38:27 -04:00
Alan Donovan
65c19a3317 Merge pull request #107 from github/spelling-again 
use correct correct spelling of codespace
 2021-09-02 11:38:25 -04:00
Alan Donovan
72a2099a50 fix breakage from API changes 2021-09-01 17:50:24 -04:00
Alan Donovan
49ccdd3d21 use correct correct spelling of codespace 2021-09-01 17:26:26 -04:00
Alan Donovan
bbcf2dd321 spell product names (Codespaces, Live Share) correctly 2021-08-31 11:15:26 -04:00
Jose Garcia
634796e8a8 merge main 2021-08-27 18:18:30 -04:00
Jose Garcia
adc1ee5e2d merge main 2021-08-27 17:43:43 -04:00
Alan Donovan
9f082ca887 Merge branch 'main' into main-style 2021-08-27 17:30:34 -04:00
Alan Donovan
a5ae72cb26 revert removal of _ = f() to pacify linter 2021-08-27 15:38:41 -04:00
Alan Donovan
da34d12abb respond to review 2021-08-27 15:26:34 -04:00
Alan Donovan
38ff786a7d cmd/ghcs: style tweaks 2021-08-27 12:03:20 -04:00
Jose Garcia
8e95493872 period 2021-08-27 15:46:40 +00:00
Jose Garcia
5dc923777b update docs, make ports private to be more consistent 2021-08-27 15:32:18 +00:00
Jose Garcia
3dcee5cca7 remove dst port column and add docs 2021-08-27 12:41:36 +00:00
Jose Garcia
55f0dad3db merge upstream 2021-08-19 18:30:10 +00:00
Issy Long
a53eb53ad4 cmd/ghcs/ports: Fix usage docs for the new source:forward syntax 
Co-authored-by: George Brocklehurst <georgebrock@github.com>
 2021-08-19 10:10:30 +01:00
Jose Garcia
8533d08461 rename var 2021-08-17 13:07:40 +00:00
Jose Garcia
b5670252de small update to description 2021-08-17 12:58:46 +00:00