Commit graph

5573 commits

Author SHA1 Message Date
Mislav Marohnić
5cb4e4d862
Merge pull request #5570 from koskeller/submit-as-draft-option-pr-create
pr create: add "Submit as draft" interactive option
2022-05-10 17:17:07 +02:00
Mislav Marohnić
cf92705d4c pr create: default to "Submit as draft" when --draft was used 2022-05-10 17:09:40 +02:00
Josh Spicer
bd1bf523b5
add devcontainer (#5592)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-05-10 14:27:46 +00:00
Mislav Marohnić
f3099828f8
Merge pull request #5588 from heaths/issue5587
status: ignore FORBIDDEN errors due to SAML enforcement
2022-05-10 16:17:39 +02:00
Mislav Marohnić
c8baec74c0 Ensure stable presentation of FORBIDDEN errors 2022-05-10 16:07:57 +02:00
Mislav Marohnić
d103ba251a 💅 optimize fetches 2022-05-10 15:44:55 +02:00
Heath Stewart
fc4cd12cbf Ignore FORBIDDEN errors for gh status
Fixes #5587
2022-05-10 15:44:55 +02:00
Mislav Marohnić
78ae6f85c6
Merge pull request #5583 from ffalor/gh_status
status: exclude results from archived repositories
2022-05-10 11:51:20 +02:00
ffalor
8f199ba730 status: exclude results from archived repositories
This adds `arhived:false` to the underlying search queries.
Additionally, the query approach was rearranged so that the query
strings are passed as GraphQL variables rather than being interpolated
directly into the GraphQL query string.

Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-05-10 11:41:04 +02:00
Ariel Deitcher
c1345296ab
Merge pull request #5514 from mntlty/pr_merge_refactor
refactor merge command
2022-05-09 11:56:36 -07:00
Sam Coe
597eb16a83
Upgrade to go 1.18 (#5542) 2022-05-09 18:46:19 +02:00
Jose Garcia
9666857f39
Merge pull request #5577 from cli/jg/fix-npe
codespaces: handle star in display name
2022-05-05 16:12:51 -04:00
Jose Garcia
cd6386cf64 Update order 2022-05-05 15:07:29 -04:00
Jose Garcia
ea7d9288e3 Handle star in display name 2022-05-05 08:21:12 -04:00
Mislav Marohnić
2c178cedd5 Dis-ambiguate "currentBranch" 2022-05-04 22:38:19 +02:00
Mislav Marohnić
b9026ab862 💅 2022-05-04 22:23:52 +02:00
Jose Garcia
801cd3b282
Merge pull request #5571 from cli/jg/add-display-name
codespaces: add Display Name to the list command
2022-05-04 09:38:27 -04:00
Heath Stewart
46e5fbdc84
Add --json support to label list (#5567) 2022-05-04 13:02:55 +00:00
Caleb Brose
1c9c3bf45f
Merge pull request #5568 from jungaretti/jupyter-return-quick-fix
Clean up Jupyter code
2022-05-03 16:00:32 -05:00
Jose Garcia
7191960694 Add Display Name to the list command 2022-05-03 16:17:53 -04:00
Konstantin Keller
dea446d2a8
"Submit as draft" option for pr create 2022-05-03 22:20:22 +03:00
JP Ungaretti
2dd81671a9
Remove empty return 2022-05-03 09:40:07 -07:00
Mohammed Anas
b352648259
Fix non-working gh issue view usage example (#5563) 2022-05-03 07:55:00 +00:00
Damien Sedgwick
b24e4c09d9
Fix: 5501 - Added examples of negated qualifiers to search commands (#5562) 2022-05-03 07:48:24 +00:00
Heath Stewart
f0027fdfd9
Add label list sorting and delete command (#5503) 2022-05-03 07:31:18 +00:00
ffalor
b57746a878
Add the ability to pass teams to review-requested (#5538) 2022-05-02 19:07:16 +02:00
Mislav Marohnić
87f9aaf1bc
Merge pull request #5559 from cli/version-upgrade-notice
Consistent version format in version upgrade notice
2022-05-02 16:10:23 +02:00
Sam Coe
477d999281
Document linux distribution updating (#5531) 2022-05-02 15:56:45 +02:00
Mislav Marohnić
82ac154d56 Consistent version format in version upgrade notice
We can strip the "v" prefix where it's unambiguous that we're talking
about version numbers.

Before:

    A new release of gh is available: 2.8.0 => v2.9.0

After:

    A new release of gh is available: 2.8.0 => 2.9.0
2022-05-02 13:29:10 +02:00
Mislav Marohnić
5fdeb8b0a2
Merge pull request #5549 from cli/editor-shellquote-fix
issue comment: support quotes and arguments in EDITOR value
2022-05-02 13:09:51 +02:00
chemotaxis
a291b3eed3
Fix grammar in repo create prompt (#5557)
* Use plural linking verb

While it looks like you could use "there's" informally, grammatically, it should be "are" since "commits" is plural.

<https://dictionary.cambridge.org/us/grammar/british-grammar/there-is-there-s-and-there-are>

* Omit "the"

I created a remote called "github" and got this prompt:

> Would you like to push commits from the current branch to the "github"?

Normally, the default name "origin" doesn't sound bad in that prompt,
but using the name "github" made the prompt sound like something wasn't
right to my American English-speaking ears.

Here are a few options.  Yes, I know English grammar sucks, to put it
mildly.  But, hopefully, the following options and explanations make
sense.

Get rid of "the".  This is the option I went with.  "github" acts as a
proper noun, so no determiner is needed.  If you substitute your own
name for "github" in the original prompt above, you get the same effect:

> Would you like to push commits from the current branch to "github"?

Add the implicit word "remote".  "github" now acts as an adjective and
"the" refers to "remote":

> Would you like to push commits from the current branch to the "github" remote?

Or, combine the two.  This last option relies on the fact that
instructions and manuals often omit definite articles because most
articles are definite.  See the [zero-marking][2] article on Wikipedia.
The original prompt already does this by omitting "the" before the word
"commits":

> Would you like to push commits from the current branch to "github" remote?

Reference:

[1]: http://writing.umn.edu/sws/quickhelp/grammar/articlesproper.html

[2]: https://en.wikipedia.org/wiki/Zero-marking_in_English
2022-05-02 10:21:59 +02:00
Mislav Marohnić
5986f88565 issue comment: support quotes and arguments in EDITOR value
The `issue comment` command would perform a `filepath.Base()` on the
value of EDITOR and use the result for launching the editor, which is
undesireable for both functional and display purposes:

- For functional purposes, always shellsplit the value of GH_EDITOR or
  EDITOR before we shell out to that process;
- For display purposes, extract the basename only after shellsplitting.
2022-04-29 18:05:39 +02:00
Caleb Brose
55bce59ab7
Add command to open codespaces in JupyterLab
Add command to open codespaces in JupyterLab
2022-04-28 16:11:14 -05:00
JP Ungaretti
3526d25a1e Remove mention of function 2022-04-28 20:55:43 +00:00
JP Ungaretti
8aa132e6c6 Use named return values 2022-04-28 18:42:05 +00:00
JP Ungaretti
ceba2c896b Use safeClose instead of Close 2022-04-28 18:38:46 +00:00
JP Ungaretti
6ddd3360d8 Update auth error message 2022-04-28 18:10:14 +00:00
Heath Stewart
5ed83e2b2a
Remove Stringer from ghrepo.Interface (#5536) 2022-04-28 08:58:34 +02:00
dependabot[bot]
beba0e1d78
Bump github.com/google/go-cmp from 0.5.7 to 0.5.8 (#5533)
Bumps [github.com/google/go-cmp](https://github.com/google/go-cmp) from 0.5.7 to 0.5.8.
- [Release notes](https://github.com/google/go-cmp/releases)
- [Commits](https://github.com/google/go-cmp/compare/v0.5.7...v0.5.8)

---
updated-dependencies:
- dependency-name: github.com/google/go-cmp
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-27 21:40:26 +02:00
ffalor
7d0a7f98e1
Add progress indicator to gist create (#5526) 2022-04-27 08:17:17 +00:00
Heath Stewart
171baca07d
Clarify label edit --name switch (#5525)
Follow-up from #5519
2022-04-27 09:37:28 +02:00
Mislav Marohnić
32256d38bf
Merge pull request #5522 from cli/dependabot/go_modules/github.com/cpuguy83/go-md2man/v2-2.0.2
Bump github.com/cpuguy83/go-md2man/v2 from 2.0.1 to 2.0.2
2022-04-26 17:07:03 +02:00
dependabot[bot]
c5a5c0ec4d
Bump github.com/cpuguy83/go-md2man/v2 from 2.0.1 to 2.0.2
Bumps [github.com/cpuguy83/go-md2man/v2](https://github.com/cpuguy83/go-md2man) from 2.0.1 to 2.0.2.
- [Release notes](https://github.com/cpuguy83/go-md2man/releases)
- [Commits](https://github.com/cpuguy83/go-md2man/compare/v2.0.1...v2.0.2)

---
updated-dependencies:
- dependency-name: github.com/cpuguy83/go-md2man/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-04-26 14:36:12 +00:00
Roshan Padaki
7a3d02df47
Add autocomplete descriptions for aliases and extensions (#5447) 2022-04-26 13:08:16 +02:00
Håvard Anda Estensen
58cb773e09
Replace ioutil with io and os (#5498) 2022-04-26 13:07:44 +02:00
Heath Stewart
6edb4ecdbb
Add label edit command (#5519) 2022-04-26 09:43:07 +00:00
Sam Coe
db85b1d3cb
Properly handle issue and pr state options when building search queries (#5513) 2022-04-25 20:18:58 +02:00
Heath Stewart
19a852ae9f
Add label clone command (#5452) 2022-04-25 18:13:22 +00:00
Roshan Padaki
13342cb272
Don't error on list commands when no results found (#5479)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-04-25 17:55:52 +00:00
Mislav Marohnić
adc9abd5ee
Merge pull request #5510 from cli/gist-delete-check
Avoid crash when deleting gist with no owner
2022-04-25 18:32:11 +02:00