Commit graph

40 commits

Author SHA1 Message Date
Jeff Hubbard
2b57084bd0 PR feedback 2022-04-20 11:52:32 -07:00
Jeff Hubbard
9fb6cf5423 Fix tests 2022-04-12 10:26:08 -07:00
Jeff Hubbard
de9b5ad8f8
Merge branch 'trunk' into multi-devcontainer 2022-04-08 15:17:33 -07:00
Jake Shorty
6783509d3b
Merge pull request #5410 from cli/codespaces-location-optional
Make location an optional flag when creating codespaces
2022-04-07 10:58:39 -06:00
Jake Shorty
e9ed200c1b
Use proper syntax for location values
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-04-07 10:49:03 -06:00
Jake Shorty
be7a4ed70b Enumerate available codespace locations for now
We'll probably want to have an intermediate geographical abstraction for these eventually, but this gives parity with the github.com UI.
2022-04-06 15:00:42 +00:00
Amanda Lin
5b10b6e986 use stderr instead and add tests 2022-04-06 09:57:36 -05:00
Jake Shorty
4aca945e2e Drop unused locationResult 2022-04-05 20:27:10 +00:00
Jake Shorty
41719f7624 Location is an optional flag when creating codespaces 2022-04-05 20:19:19 +00:00
Amanda Lin
6490f658de handle IdleTimeoutNotice 2022-04-05 10:27:26 -05:00
Jeff Hubbard
a84e43cadf Final copy and behavior update for prompt 2022-04-04 16:32:38 -07:00
Jeff Hubbard
9554e522af Change the way we parse list-devcontainers response 2022-03-28 14:24:57 -07:00
Jeff Hubbard
8abf50be1d Change some copy per product's suggestions 2022-03-18 10:10:57 -07:00
Jeff Hubbard
ce3d0791c3
Merge branch 'trunk' into multi-devcontainer 2022-03-16 12:51:03 -07:00
Mark Phelps
43e4e9514d
Merge pull request #5276 from markphelps/codespaces-accept-perms-wording 2022-03-15 12:55:44 -04:00
Josh Spicer
4d5ce7aa56
Adds internal codespace developer flags (#5287) 2022-03-09 15:59:29 +00:00
Mark Phelps
625f3ac144 Updates wording for codespaces accept permissions flow 2022-03-03 15:36:53 -05:00
Mark Phelps
dd5feda00a Update wording after consulting product 2022-02-25 17:32:08 -05:00
Mark Phelps
71f32376d0 Fix tests 2022-02-22 20:20:52 -05:00
Mark Phelps
707220a9b1 PR updates 2022-02-22 14:16:03 -05:00
Mark Phelps
e7c2f973ae Support opting out of permissions 2022-02-17 15:11:12 -05:00
Mark Phelps
590acaa1d6 WIP 2022-02-15 19:35:53 -05:00
Caleb Brose
eeeb73a3e3
Repo name suggestions for cs create (#5108)
Co-authored-by: Alan Donovan <alan@alandonovan.net>
2022-01-31 10:20:49 +00:00
Jeff Hubbard
5cee9e16f3 Add interactive prompt to choose from list of available devcontainer files 2022-01-21 14:11:52 -08:00
Jeff Hubbard
e7f888ad1d Add devcontainer_path API param as an option 2022-01-21 10:20:15 -08:00
Jeff Hubbard
91dc722170 Remove the default value from idle-timeout as the API takes care of it and this can override user settings 2021-11-18 11:38:26 -08:00
Jeff Hubbard
90313fbf96
Add idle timeout to cs create parameters (#4741)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2021-11-18 11:47:48 +00:00
Amanda Lin
15c8f291e4
Add prebuild availability status to create codespaces (#4737) 2021-11-17 19:41:05 +01:00
Mislav Marohnić
436762dd54 codespace create: make the branch input optional
When blank, the branch name will default to the default branch for the
repository.
2021-10-22 15:43:26 +02:00
Mislav Marohnić
3492109e12 codespace create: avoid unnecessarily fetching user 2021-10-22 14:39:21 +02:00
Jose Garcia
bbea5ac95e
codespace: progress indication, logging (#4555)
* Rework logging, showing progress, and printing from `codespace` commands
* Change rendering of the general progress indicator so that it's visible on both dark and light backgrounds
* The progress indicator now "spins" faster

Co-authored-by: Mislav Marohnić <mislav@github.com>
2021-10-21 18:04:04 +02:00
Mike McDonald
e175d0f0a6 removing unused dependencies 2021-10-15 22:05:54 +00:00
Mike McDonald
5f98c9d2e4 Fixing formatting 2021-10-15 21:58:52 +00:00
Mike McDonald
21ff083b9b Removing "friendly" machine name from prompt
Currently the options end up as `Basic` through to `X`. No other client
provides these types of names, so we should just show machine info.
2021-10-15 21:56:17 +00:00
Jose Garcia
8135fdbd99 Switch GetCodespace to new API endpoint
- Drop GetCodespaceToken as it is no longer necessary
- Introduces new behavior with the API to optionally include connection
  details in the GET request. Ommitting to do so results in a faster
  response
2021-10-06 08:50:42 -04:00
Jose Garcia
616d6c2db1
Merge pull request #4431 from cli/jg/get-skus-public
codespace machine: switch `API.GetCodespacesMachines` to use new API
2021-10-05 12:44:38 -04:00
Jose Garcia
d02876e6ea Rename the cmd pkg to codespace 2021-10-04 14:16:04 -04:00
Jose Garcia
e0db10e4dd Switch API.GetCodespacesMachines to use new API
- The SKU terminology is also dropped in favor of "machine" which
  matches the nomenclature of the rest of the product.
2021-10-04 13:40:18 -04:00
Jose Garcia
0859de0124 Merge branch 'trunk' of github.com:cli/cli into jg/move-ghcs-cmd 2021-09-30 12:38:41 -04:00
Jose Garcia
9e6c11e767 Move cmd/ghcs to pkg/cmd/codespace
- Delete pkg/cmd/codespace/main as it is no longer needed in this
  codebase
2021-09-30 11:20:13 -04:00
Renamed from cmd/ghcs/create.go (Browse further)