STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
9522 commits 87 branches 0 tags 160 MiB
Commit graph

9522 commits

This branch
This branch
All branches
Author SHA1 Message Date
Babak K. Shandiz
5dca16fd41
Update test case for removing all reviewers 
Signed-off-by: Babak K. Shandiz <babakks@github.com>
 2025-05-13 10:13:45 +01:00
Babak K. Shandiz
ce710aa249
Add test to verify removing all reviewers 
Signed-off-by: Babak K. Shandiz <babakks@github.com>
 2025-05-12 15:15:43 +01:00
Babak K. Shandiz
4985d0ff44
fix bug when removing all PR reviwers 
Signed-off-by: Babak K. Shandiz <babakks@github.com>
 2025-05-12 15:06:11 +01:00
Andy Feller
7ceca4534d
Merge pull request #10937 from cli/kw/accessible-prompter-prints-readable-defaults-in-prompt 
Accessible prompter always displays defaults in speech synthesis readable format
 2025-05-09 08:48:10 -04:00
Babak K. Shandiz
90532e8377
Improve assertion for disabled echo mode (#10927) 
* Improve assertion for disabled echo

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Use `expect.RegExpPattern`

Signed-off-by: Babak K. Shandiz <babakks@github.com>

---------

Signed-off-by: Babak K. Shandiz <babakks@github.com>
 2025-05-08 21:26:02 +01:00
William Martin
e5f7a453df
Merge pull request #10942 from cli/wm/projectsv1-deprecation-pr-edit 
Feature detect v1 projects on pr edit
 2025-05-08 15:53:21 +02:00
Kynan Ware
9b89a0ac0e fix(a11y prompter): remove invalid defaults 2025-05-08 07:41:36 -06:00
William Martin
202a4f3c5a
Merge pull request #10947 from cli/gitulisca/handling-download-of-unpublished-release 
Handle missing archive URLs on release download
 2025-05-08 15:03:06 +02:00
Art Leo
89bed45c55 Release download handles missing archive URLs 
Co-authored-by: William Martin <williammartin@github.com>
 2025-05-08 12:41:12 +02:00
Art Leo
d78980c668 Fix release download test http stubbing 
Co-authored-by: William Martin <williammartin@github.com>
 2025-05-08 12:15:28 +02:00
William Martin
55cd3c34cd Feature detect v1 projects on pr edit 2025-05-07 16:17:15 +02:00
Azeem Sajid
ee281fd9ba
Add closedByPullRequestsReferences JSON field to issue view (#10941) 
* [gh issue view] Expose `closedByPullRequestsReferences` JSON fields

* Incorporate GitHub Copilot review suggestions

* Incorporate review changes
 2025-05-07 13:59:22 +01:00
Kynan Ware
3594f6357b fix(a11y prompter): confirm prompt default is readable 2025-05-06 15:50:57 -06:00
Kynan Ware
04aaaea142 fix(a11y prompter): multi select defaults are readable 2025-05-06 15:43:26 -06:00
Kynan Ware
957667efe6 doc(prompter): remove TODO about default value panic 2025-05-06 15:33:51 -06:00
Kynan Ware
cab906151f fix(a11y prompter): select prompt default value is readable 2025-05-06 15:33:15 -06:00
Kynan Ware
ab4cfb84d2 refactor(a11yprompter): shared method for prompt defaults 2025-05-06 15:33:15 -06:00
Kynan Ware
2ee68411a7 fix(a11y prompter): Select prompt respects defaults 2025-05-06 15:33:15 -06:00
Kynan Ware
9bc2c388da fix(a11y prompter): input prompt default value is readable 2025-05-06 14:34:05 -06:00
Meredith Lancaster
315876852a
Merge pull request #10670 from malancas/move-predicate-type-filtering 
Move predicate type filtering in `gh attestation verify`
 2025-05-06 11:08:34 -06:00
William Martin
a2fcb9b2df
Merge pull request #10915 from cli/wm/projectsv1-deprecation-pr-create-rest 
Feature detect v1 projects on interactive `pr create`
 2025-05-06 15:24:04 +02:00
William Martin
4967a5edd5
Merge pull request #10911 from cli/wm/projectsv1-deprecation-pr-web 
Feature detect v1 projects on web mode pr create
 2025-05-06 14:19:15 +02:00
Meredith Lancaster
e4ef9bcedd
Merge branch 'trunk' into move-predicate-type-filtering 2025-05-05 14:34:00 -06:00
Kynan Ware
d6d8275809
Merge pull request #10918 from cli/kw/fix-accessible-prompter-flaky-test 
Fix flakey test for accessible prompter
 2025-05-02 14:59:39 -06:00
Kynan Ware
cc673cfaba test(prompter): add timeout before password input 2025-05-02 14:48:07 -06:00
Kynan Ware
7b86830ade
Merge pull request #10729 from nopcoder/trunk 
Fix panic on `gh pr view 0`
 2025-05-02 09:47:48 -06:00
William Martin
1a5b7ca60c Feature detect v1 projects for preview URL 
As far as I can see, when there is project metadata, the preview option
will never be shown in the interactive multiselect, so I don't believe
this change has any functional difference. However, I did use the
opportunity to drive out tests for generateCompareURL
 2025-05-02 17:42:23 +02:00
William Martin
5a3aee056a Feature detect v1 projects on interactive pr create 2025-05-02 17:42:23 +02:00
William Martin
5ee70748fa
Merge pull request #10909 from cli/wm-kw/projectsv1-deprecation-pr-create 
Feature detect v1 projects on non-interactive pr create
 2025-05-02 15:23:11 +02:00
William Martin
9822bb5d07 Feature detect v1 projects on web mode pr create 2025-05-02 15:11:04 +02:00
William Martin
e995a873cb Feature detect v1 projects on non-interactive pr create 2025-05-02 15:08:34 +02:00
William Martin
c5d8e6f8f5
Merge pull request #10821 from cli/wm/projectsv1-deprecation-pr-view 
Feature detect v1 projects on pr view
 2025-05-02 15:07:40 +02:00
William Martin
64370ce73e Cleanup run command stubbed finders in tests 2025-05-02 14:48:52 +02:00
Babak K. Shandiz
284880c21e
Fix StatusJSONResponse usage (#10810) 
* Fix `StatusJSONResponse` usage

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Replace `assert` with `require`

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Improve assertion against errors

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Add `JSONErrorResponse` helper func

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Use `httpmock.JSONErrorResponse`

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Replace `StatusJSONResponse` to `JSONErrorResponse` for better readibility

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Fix improper use of `StatsJSONResponse`

Signed-off-by: Babak K. Shandiz <babakks@github.com>

---------

Signed-off-by: Babak K. Shandiz <babakks@github.com>
 2025-05-01 20:22:43 +01:00
Barak Amar
232c024987
Merge branch 'trunk' into trunk 2025-05-01 22:16:55 +03:00
William Martin
3bcf9758ad Feature detect v1 projects on pr view 2025-05-01 15:31:36 +02:00
Sinan Sonmez (Chaush)
0a1e7a1fdc
Add --delete-last option to pr comment and issue comment (#10596) 
* deletion for issues with confirmation flag

* add handling for interaction case

* finish implementation for issues

* finish the implementation for issues

* finalize the implementation for PR

* fix missing --yes flag for PR

* address PR comments related to feedbacks

* improve CommentablePreRun for pre checks

* improve confirmation prompt and truncate long comment body

* address PR comments on tests

* Truncate comment for confirmation prompt

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Improve test case descriptions

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Fix mock comment body

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Remove irrelevant prompt stub

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Use `opts.Interactive` as TTY indicator

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Fix expected `Interactive` value

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Polish `TestNewCmdComment`

Signed-off-by: Babak K. Shandiz <babakks@github.com>

---------

Signed-off-by: Babak K. Shandiz <babakks@github.com>
Co-authored-by: Babak K. Shandiz <babakks@github.com>
 2025-05-01 14:12:55 +01:00
Andy Feller
913d13539d
Merge pull request #10869 from cli/dependabot/go_modules/github.com/cpuguy83/go-md2man/v2-2.0.7 
chore(deps): bump github.com/cpuguy83/go-md2man/v2 from 2.0.6 to 2.0.7
 2025-05-01 08:20:27 -04:00
Andy Feller
3abc43b770
Merge pull request #10886 from cli/dependabot/github_actions/actions/attest-build-provenance-2.3.0 
chore(deps): bump actions/attest-build-provenance from 2.2.2 to 2.3.0
 2025-05-01 08:07:07 -04:00
Meredith Lancaster
050c68c13b
Merge branch 'trunk' into move-predicate-type-filtering 2025-04-30 14:14:42 -06:00
Andy Feller
c20a4a2ae9
Merge pull request #10890 from cli/andyfeller/gh-accessibility-help-topic 
Introduce `gh accessibility` help topic highlighting GitHub CLI accessibility experiences
 2025-04-30 15:40:27 -04:00
Andy Feller
830335d920 PR feedback 2025-04-30 15:05:07 -04:00
Andy Feller
c20138d844
Update pkg/cmd/accessibility/accessibility.go 2025-04-30 14:35:35 -04:00
Andy Feller
2fd1a45a81
Update pkg/cmd/accessibility/accessibility.go 2025-04-30 14:21:02 -04:00
Andy Feller
096106a3d7
Apply suggestions from code review 
Co-authored-by: Melissa Xie <mxie@users.noreply.github.com>
 2025-04-30 14:20:16 -04:00
Andy Feller
f6dd699703
Merge pull request #10906 from cli/kw/typo-in-prompter 
Small typo in code comment.
 2025-04-30 10:14:56 -04:00
Kynan Ware
00c930d509
doc(prompter): small typo 2025-04-30 08:04:16 -06:00
Andy Feller
8130126ce5
Merge pull request #10901 from cli/kw/fix-accessible-multi-select-prompter-respects-defaults 
Fix: Accessible multiselect prompt respects default selections
 2025-04-30 09:46:56 -04:00
Kynan Ware
d8512a9066 fix(prompter): respect default MultiSelect a11y prompter 2025-04-29 16:35:04 -06:00
Barak Amar
a491578751
Merge branch 'trunk' into trunk 2025-04-29 14:33:21 +03:00