Commit graph

407 commits

Author SHA1 Message Date
Meredith Lancaster
050c68c13b
Merge branch 'trunk' into move-predicate-type-filtering 2025-04-30 14:14:42 -06:00
Meredith Lancaster
139e82c68c Revert "temporarily skip non-failing tests"
This reverts commit de8778797f.
2025-04-09 07:23:17 -06:00
Meredith Lancaster
de8778797f temporarily skip non-failing tests
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-08 19:09:52 -06:00
Meredith Lancaster
29080dc70a reorganize func
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-08 16:40:52 -06:00
Meredith Lancaster
d63e2830e0 clean up unneeded sigstore verifier fields
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-08 16:35:17 -06:00
Meredith Lancaster
a535cfdbfc flip verifier choice logic
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-08 16:28:56 -06:00
Meredith Lancaster
366485155e initiate custom verifiers when the sgistore verifier is created
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-08 16:23:37 -06:00
Meredith Lancaster
323ea74733 add public good and github verifiers as fields for repeated use instead of creating a new one for every attestation
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-08 15:40:55 -06:00
Meredith Lancaster
35ec7f251c replace sigstore-go test bundle func
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-08 15:20:51 -06:00
Meredith Lancaster
261cea2075 update error message
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-08 14:41:18 -06:00
Meredith Lancaster
69507282d2 restore deleted file
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-03 11:07:06 -06:00
Meredith Lancaster
164a56cb66 move filterAttestations function
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-03 11:02:45 -06:00
Meredith Lancaster
56d924d25b getAttestations unit tests
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-01 12:58:37 -06:00
Meredith Lancaster
13dafefcb5 add missing nil struct checks and udpate error messages
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-01 11:23:25 -06:00
Meredith Lancaster
cdfb1b7279 Merge branch 'move-predicate-type-filtering' of github.com:malancas/cli into move-predicate-type-filtering 2025-04-01 11:16:05 -06:00
Meredith Lancaster
05d9156a99 add check for nil api client
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-01 11:16:00 -06:00
Meredith Lancaster
a04be55092
Merge branch 'trunk' into move-predicate-type-filtering 2025-04-01 10:48:13 -06:00
Phill MV
0427f26884
Update pkg/cmd/attestation/verify/verify.go
Co-authored-by: Meredith Lancaster <malancas@users.noreply.github.com>
2025-03-31 11:05:23 -04:00
Phill MV
f099a54243 updated test 2025-03-27 09:57:00 -04:00
Phill MV
9c9b158d12 added minor caveat 2025-03-27 09:55:14 -04:00
Phill MV
33ab0b8f3b Tweaked language a bit, improved error message. 2025-03-27 09:47:11 -04:00
Phill MV
321e5687a6 Rewrote the gh at verify --help text to a) clarify and b) document the verificationResult object. 2025-03-26 17:40:35 -04:00
Meredith Lancaster
166e211e2b clean up test fixtures
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-03-25 08:28:33 -06:00
Meredith Lancaster
e3fbe9008f reduce test duplication
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-03-25 08:25:00 -06:00
Meredith Lancaster
d1c4bf7dd9 comment
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-03-25 08:24:52 -06:00
Meredith Lancaster
baeaf66011 restructure api client methods
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-03-24 19:13:27 -06:00
Meredith Lancaster
0d0654738b simplify client methods
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-03-24 18:58:35 -06:00
Meredith Lancaster
a856a796f0 remove duplicate predicate filtering code
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-03-24 18:34:54 -06:00
Meredith Lancaster
a9cc7b481e create single fetch by digest client method
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-03-24 18:28:27 -06:00
Meredith Lancaster
5a895b9d72 dedpulicate if else logic
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-03-24 18:12:41 -06:00
Meredith Lancaster
95a61974bf pass params object to api client methods
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-03-24 18:01:57 -06:00
Meredith Lancaster
ad20ef35d9 move local and oci registry attestation filtering
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-03-24 17:35:52 -06:00
Meredith Lancaster
faef81f4bc reorganize getAttestations func to check for remote gh api fetching first
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-03-24 17:28:50 -06:00
Meredith Lancaster
a78c06970a pass predicate type to get attestation api methods
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-03-24 17:28:00 -06:00
Meredith Lancaster
917a00ddc1
Update pkg/cmd/attestation/verification/attestation.go
Co-authored-by: Fredrik Skogman <kommendorkapten@github.com>
2025-03-05 07:31:35 -07:00
Meredith Lancaster
ddc36c8a8e
Update pkg/cmd/attestation/verification/attestation.go
Co-authored-by: Fredrik Skogman <kommendorkapten@github.com>
2025-03-05 07:31:28 -07:00
Meredith Lancaster
671c4c23a9 Merge branch 'trunk' into refactor-get-attestations-funcs 2025-03-04 09:33:00 -07:00
Andy Feller
f9d50d86ac
Merge pull request #10508 from iamazeem/10449-inconsistent-examples-format
Inconsistent format of examples in help text
2025-02-27 09:15:14 -05:00
Azeem Sajid
33c30d5bd1 Inconsistent format of examples in help text 2025-02-27 16:26:25 +05:00
Azeem Sajid
69fff52026
Inconsistent format of description of flags (starting with lowercase letter) (#10507) 2025-02-27 11:40:21 +01:00
Meredith Lancaster
33d863f98d
Merge pull request #10308 from malancas/attestation-verify-ref-commit-policy-opts
Add signer-digest, source-ref, and source-digest options for `gh attestation verify`
2025-02-26 14:27:31 -07:00
Meredith Lancaster
ba5cf8e1ce
Merge branch 'trunk' into attestation-verify-ref-commit-policy-opts 2025-02-24 10:59:58 -07:00
Meredith Lancaster
343d9babeb fix expected test output
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-02-24 10:51:34 -07:00
Meredith Lancaster
37a91ebfdb undo regex changes
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-02-24 10:47:39 -07:00
Meredith Lancaster
ce87c746b2 remove signer-ref option
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-02-24 10:44:29 -07:00
beforetech
563c2f9e18 refactor: use a more straightforward return value
Signed-off-by: beforetech <mail@before.tech>
2025-02-23 22:59:33 +08:00
William Martin
db823c18b8 Allow injection of TUFMetadataDir in tests
This avoids multiple tests using the same dir for metadata, which was causing flakes
2025-02-20 17:04:30 +01:00
William Martin
9c90e3aac9 Use subtests in attestation verification integration tests 2025-02-18 16:44:48 +01:00
Cody Soyland
ad2cfe074f
Add mutex to fix race in attestation test client
Signed-off-by: Cody Soyland <codysoyland@github.com>
2025-02-13 10:18:30 -05:00
Meredith Lancaster
4daf489c75 Merge branch 'trunk' into refactor-get-attestations-funcs 2025-02-11 11:11:30 -07:00