STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
8679 commits 87 branches 0 tags 160 MiB
Commit graph

8679 commits

This branch
This branch
All branches
Author SHA1 Message Date
Meredith Lancaster
611eb86e68 method update 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-13 12:47:25 -07:00
Meredith Lancaster
b7f6af03b5 update no attestations found err 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-13 12:42:10 -07:00
Meredith Lancaster
fc0d0210c0 remove old tests 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-13 12:21:27 -07:00
Meredith Lancaster
5462582401 drop unneeded methods 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-13 11:05:17 -07:00
Meredith Lancaster
40e7353b52 deduplicate get attestation code 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-13 11:02:33 -07:00
Meredith Lancaster
4d99ae920c fix tests 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-13 10:34:06 -07:00
Meredith Lancaster
d60f6c24d0 Merge branch 'trunk' into attestation-bundle-fetch-improvements 2025-01-13 08:34:43 -07:00
Meredith Lancaster
c7d04c980b update testing 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-13 08:34:15 -07:00
Meredith Lancaster
112552fec1
Merge pull request #10185 from malancas/fetch-artifact-attestation-bundles-with-sas-url 2025-01-13 08:20:33 -07:00
Andy Feller
41e99b9eab
Merge pull request #9934 from cli/andyfeller/cli-cli-8183-timeout-pt2 
Ensure extension update notices only notify once within 24 hours, provide ability to disable all extension update notices
 2025-01-13 09:12:32 -05:00
Andy Feller
3ada5af872 Enhance help docs on ext upgrade notices 
- update `gh help environment` to include that upgrade notices only happen when gh or extensions are executed
- update `gh ext --help` to include reference to upgrade notices and points to `gh help environment` for info on disabling
 2025-01-13 08:41:10 -05:00
Andy Feller
8a2be52be0
Merge pull request #10225 from zhuhaicity/fix_func_name 
chore: fix some function names in comment
 2025-01-13 08:08:18 -05:00
zhuhaicity
13211af256 chore: fix some function names in comment 
Signed-off-by: zhuhaicity <zhuhai@52it.net>
 2025-01-12 15:07:04 +08:00
Andy Feller
0a1c9be656 Expand docs on cleaning extension update dir 
This summarizes a conversation within cli/cli#9934 PR regarding how the new extension update directory metadata would affect gh if not cleaned up.
 2025-01-10 14:57:10 -05:00
Andy Feller
97eb8a194e Simplifying cleanExtensionUpdateDir logic 
This function was doing some unnecessary heavy lifting detecting if the directory being deleted actually existed when `os.RemoveAll()` would handle directories that exist or not.
 2025-01-10 14:29:55 -05:00
Andy Feller
20062233c8 Separate logic for checking updates 
During discussion in cli/cli#9934, we can to the conclusion that the logic around checking for core GitHub CLI updates would diverge from GitHub CLI
extension updates over time.  To that end, this commit splits that logic into a separate function with a new environment variable.
 2025-01-10 14:16:46 -05:00
Andy Feller
1c32c986ec Capture greater detail on updaterEnabled 
This commit expands the in-line docs around updaterEnabled package variable used to affect release checking.

Along with clarifying specific details discovered when talking with @williammartin, I'm also removing a useless local variable.
 2025-01-10 13:55:16 -05:00
Andy Feller
a6ea8fe4ed
Merge pull request #10216 from nobe4/improve-padded-display 
fix: padded display
 2025-01-10 13:45:51 -05:00
Kynan Ware
c0d41102a5
Merge pull request #10215 from cli/dependabot/go_modules/github.com/mattn/go-colorable-0.1.14 
Bump github.com/mattn/go-colorable from 0.1.13 to 0.1.14
 2025-01-10 11:17:21 -07:00
nobe4
69b17272d6
fix: add back colon that I removed 2025-01-10 17:17:14 +01:00
nobe4
69ab0c9c85
fix: actually read how MaxFunc work and simplify the code 2025-01-10 16:31:13 +01:00
nobe4
1899b83509
fix: padded display 
Apply code suggestion from @andyfeller from:
- https://github.com/cli/cli/pull/10194#discussion_r1909761552
- https://github.com/cli/cli/pull/10194#discussion_r1909764278
 2025-01-10 16:28:50 +01:00
William Martin
889c4c75f3 Collapse dryrun checks in ext bin upgrade 2025-01-10 16:06:01 +01:00
dependabot[bot]
567624b550
Bump github.com/mattn/go-colorable from 0.1.13 to 0.1.14 
Bumps [github.com/mattn/go-colorable](https://github.com/mattn/go-colorable) from 0.1.13 to 0.1.14.
- [Commits](https://github.com/mattn/go-colorable/compare/v0.1.13...v0.1.14)

---
updated-dependencies:
- dependency-name: github.com/mattn/go-colorable
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2025-01-10 14:39:26 +00:00
Tyler McGoffin
4c8d124d37
Merge pull request #10194 from nobe4/fancier-extention-upgrade 
feat: make the extension upgrade fancier
 2025-01-09 14:59:52 -08:00
Andy Feller
21a1f8e8a9
Merge pull request #10208 from cli/andyfeller/10202-correct-issue-create-template-help 
Correct help documentation around template use in `gh issue create`
 2025-01-09 13:22:26 -05:00
Andy Feller
954d4d5dbc
Correct help documentation around template use in gh issue create 
Relates #10202 

While we figure out how to handle consistent experience using templates for creating issues and PRs, let's correct the help usage for issue template flag use as this is the issue template name, not filename.
 2025-01-09 11:08:18 -05:00
Andy Feller
6bbd70353b Comment exported functions 2025-01-09 09:09:42 -05:00
Meredith Lancaster
8ad877b188 add check for invalid attestation 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-08 08:38:43 -07:00
Tyler McGoffin
713346c736
Merge pull request #10196 from cli/jtmcg/update-FR-docs 
Update triage.md to reflect FR experiment outcome
 2025-01-07 16:10:49 -08:00
Tyler McGoffin
47c391b246 PR review edits 2025-01-07 15:42:17 -08:00
Meredith Lancaster
33d0002d21 update tests to use new function name 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-07 15:22:02 -07:00
Meredith Lancaster
8d89dd97fd
Update pkg/cmd/attestation/api/client.go 
Co-authored-by: Phill MV <phillmv@github.com>
 2025-01-07 15:14:53 -07:00
Meredith Lancaster
51a74aed1d
Update pkg/cmd/attestation/api/client.go 
Co-authored-by: Phill MV <phillmv@github.com>
 2025-01-07 15:14:23 -07:00
Meredith Lancaster
42cb2547cd remove old comment 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-07 14:13:50 -07:00
Meredith Lancaster
d4f3fbce9b
Merge branch 'trunk' into fetch-artifact-attestation-bundles-with-sas-url 2025-01-07 12:04:12 -07:00
Meredith Lancaster
f46cccbab4 comment 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-07 12:03:49 -07:00
Meredith Lancaster
258c69cd26 undo more name chanages 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-07 11:56:05 -07:00
Meredith Lancaster
0a602fae07 undo other name change 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-07 11:54:02 -07:00
Meredith Lancaster
37e0969f20 remove spaces 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-07 11:51:51 -07:00
Meredith Lancaster
3c0280c4d7 undo name change for now 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-07 11:51:23 -07:00
Meredith Lancaster
7838e912b6 more mock http client cleanup 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-07 11:37:02 -07:00
Tyler McGoffin
58ca3c69bb Update triage.md to reflect FR experiment outcome 2025-01-07 10:36:15 -08:00
Meredith Lancaster
9d88ca8cf8 simplify mock http client 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-07 11:32:49 -07:00
Meredith Lancaster
ecf55c6c16 use mock to assert number of http calls 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-07 10:54:17 -07:00
Meredith Lancaster
e34e188ee2 add http client test constructors 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-07 10:43:24 -07:00
Meredith Lancaster
9ecd90c26c setup testing struct for test cases 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-07 10:24:42 -07:00
nobe4
442be87acb
Merge branch 'trunk' into fancier-extention-upgrade 2025-01-07 12:04:35 +01:00
nobe4
3b69ea6fbc
feat: make the extension upgrade fancier 
This left-pad the extension names during upgrade so they all align
nicely. It makes easier to see what is happening.
 2025-01-07 12:01:02 +01:00
Andy Feller
40984d1eb6
Merge pull request #10186 from cli/wm/clear-up-fine-grained-pats-auth-login 
Clear up --with-token fine grained PAT usage
 2025-01-06 15:24:37 -05:00