STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
3730 commits 87 branches 0 tags 160 MiB
Commit graph

1171 commits

Author SHA1 Message Date
Nate Smith
640a089e55
Merge pull request #3850 from chemotaxis/fix-actions-help 
Print help even if logged out
 2021-06-22 14:24:06 -07:00
Nate Smith
654336fe64
Merge pull request #3871 from jonlorusso/trunk 
Update documentation for gist create command with default of secret
 2021-06-22 14:20:02 -07:00
Sam Coe
1302b71fa7
linter 2021-06-22 11:41:22 -07:00
Sam Coe
e0468dbb29
whitespace 2021-06-22 11:39:47 -07:00
Sam Coe
665f552def
Small reordering 2021-06-22 11:37:56 -07:00
Jon Lorusso
22235c2f97
Update documentation for gist create command to reflect default of secret. 2021-06-21 11:25:49 -04:00
autopp
0179651dc3
Add shell completion for the --state flag 2021-06-20 20:03:21 +09:00
chemotaxis
b0f58d0cf0 Disable authentication check, but keep runnable 
In this branch, we originally avoided the authentication check by
getting rid of the run method attached to the command.  Instead of that,
this commit makes the `gh actions` command runnable again, but the
authentication is disabled with `cmdutil.DisableAuthCheck`; this mirrors
what's done for `gh version`.

`gh actions` and `gh actions [-h | --help]` all work while being logged
out.

In addition, this commit restores some original behavior.  Before this
commit, the help footer (usage, inherited flags, etc.) is appended
whether you use `gh actions` or `gh actions --help`.  This commit
restores the original behavior where `gh actions` prints just the text
for the actions explanation, but `gh actions --help` appends the help
footer.
 2021-06-18 23:43:42 -04:00
chemotaxis
1c103e20ac Always try to render bold font 
It looks like a similar check is done in ColorScheme.Bold() where it
checks whether the scheme is enabled or not.
 2021-06-18 23:07:31 -04:00
Mislav Marohnić
052d6588ea Revert "Whitespace" 
Trailing whitespace is significant in Markdown.

This reverts commit 682c15d52c.
 2021-06-18 15:16:48 +02:00
chemotaxis
89ce78e48b Restore help footer 
At the moment, the "help footer" doesn't add any new information, but if
additional flags are added later, they should appear in the footer. This
change restores this help footer:

```shell
USAGE
  gh actions [flags]

INHERITED FLAGS
  --help   Show help for command

LEARN MORE
  Use 'gh <command> <subcommand> --help' for more information about a command.
  Read the manual at https://cli.github.com/manual
```
 2021-06-17 13:30:26 -04:00
chemotaxis
682c15d52c Whitespace 2021-06-17 12:58:37 -04:00
Mislav Marohnić
4b2cded1f8 Ensure that tests for command factory never read from user's config 
If these tests are going to exerise `factory.New()`, the config getter
should always be overriden since the default config getter reads from
`~/.config/gh` and thus makes tests dependent on the user's environment.
 2021-06-17 17:59:34 +02:00
Mislav Marohnić
8ff42bf28c Fix repo override 2021-06-17 17:58:46 +02:00
Mislav Marohnić
8dd1e12f64 Merge remote-tracking branch 'origin' into fix-actions-help 2021-06-17 16:13:34 +02:00
Mislav Marohnić
94c1646209 Simplify gh actions implemenation 
The command is now non-runnable, meaning it's exempt from auth check.
 2021-06-17 16:02:00 +02:00
Mislav Marohnić
883943946a Add a global pre-run hook to handle auth check and repo override 
With auth check being done via Cobra hooks, it is automatically skipped
for non-runnable commands and `-h/--help` flag usage.
 2021-06-17 16:01:57 +02:00
Sam
d299b74a37
Merge pull request #3841 from cli/factory-cleanup 
Factory cleanup
 2021-06-15 12:10:36 -04:00
Mislav Marohnić
543a17df7f
Merge pull request #3787 from cli/editor-tests 
Allow explicitly empty body in issue/pr create
 2021-06-15 16:16:59 +02:00
Sam Coe
edfac42384
Set up iostreams in factory default 2021-06-15 09:20:00 -04:00
Sam Coe
53fac59ef9
Cleanup factory/default and add tests 2021-06-15 09:19:16 -04:00
Sam
e380d68ed2
Merge pull request #3789 from cristiand391/increase-gh-pager-precedence 
Increase `GH_PAGER` precedence
 2021-06-15 09:18:57 -04:00
Mislav Marohnić
5984cf2a82
Merge pull request #3832 from cli/env-set-fix 
Fix setting environment secrets
 2021-06-14 16:17:24 +02:00
Cristian Dominguez
d8ce615252 Remove unused method from httpmock package 2021-06-14 09:39:14 -03:00
Mislav Marohnić
3a7ce3a440 Fix setting environment secrets 
This uses the correct public key when setting environment secrets.
https://docs.github.com/en/rest/reference/actions#get-an-environment-public-key
 2021-06-14 11:51:20 +02:00
Mislav Marohnić
1f4bd80c56 Fix test flaky due to race in showing/hiding cursor 
https://github.com/cli/cli/pull/3787/checks?check_run_id=2793254411
 2021-06-14 10:58:53 +02:00
Nate Smith
aecfc01e69
Merge pull request #3809 from cli/fork-test-cleanup 
fork tests cleanup
 2021-06-11 11:31:33 -05:00
Mislav Marohnić
4debbb17cd Further separate out test cases 2021-06-11 14:32:08 +02:00
Nate Smith
b0998772ae more cleanup 2021-06-10 21:46:02 +00:00
Nate Smith
f31a31e2ed stop stubbing out a Since function 2021-06-10 21:46:02 +00:00
vilmibm
4a7ec7f4f6 cleaning up fork tests 2021-06-10 21:45:54 +00:00
vilmibm
14de70a011 add defaultRemoteName 2021-06-10 21:44:49 +00:00
Mislav Marohnić
e1b5f78df3 💅 grammar in comment 2021-06-10 14:09:43 +02:00
vilmibm
395355d075 make prompt.Confirm stubbable 2021-06-08 15:49:37 -05:00
Mislav Marohnić
3a55c26000 Update "Accept" header for github.com requests 
The `antiope-preview` has graduated in github.com and no longer needs
activating. However, we still need it for GHES requests.
 2021-06-08 19:25:40 +02:00
Mislav Marohnić
8a221bb766 Add tests for our default HTTP client 2021-06-08 19:21:48 +02:00
Cristian Dominguez
b3c2318e09 Increase GH_PAGER precedence 
If `GH_PAGER` is exists, set it as the pager even if one is
already set in config.

This allows a user to change/disable the pager per single invocation.
 2021-06-04 23:22:37 -03:00
Mislav Marohnić
606deaf134 Allow setting empty body via editor in issue/pr create 2021-06-04 21:50:51 +02:00
Mislav Marohnić
f570deb118 Add tests for opening the editor program 2021-06-04 21:24:17 +02:00
Mislav Marohnić
bcfe176594 Fix flaky editor test 
There was a race condition wherein the test didn't wait enough time for
the prompt to get rendered before testing the terminal output.
 2021-06-04 20:06:21 +02:00
Bruno Alla
051520afe1 Add a long command description for secrets remove 2021-06-04 16:44:44 +01:00
Bruno Alla
4d46447eb3 Fix description for gh secret set --env option 2021-06-04 15:29:01 +01:00
Mislav Marohnić
ffebd23ba7
Merge pull request #3761 from cli/command-extensions 
Experimental command extensions support
 2021-06-03 19:13:38 +02:00
Mislav Marohnić
4bdddd72d3 Allow installing local extensions via symlinks 
This also quits searching for local extensions in PATH.
 2021-06-03 19:06:28 +02:00
Mislav Marohnić
c2c691f444 Add test for our survey editor extension 2021-06-03 18:05:43 +02:00
chemotaxis
d974dbd338 Return default text if skipping the text editor when prompted 
If we are allowed to skip the editor _and_ we want to append the default
text to the editor if we'd opened it, we just return the default text.

Co-Authored-By: Mislav Marohnić <mislav@github.com>
 2021-06-03 14:50:13 +02:00
Bruno Alla
4b79edf603 Add support for removing environment secrets 2021-06-03 08:51:39 +01:00
Nate Smith
a1cedfcd5c
Merge pull request #3741 from jack1142/patch-1 
Include issue number alongside the title in `gh issue/pr view`
 2021-06-02 13:53:48 -05:00
Nate Smith
4d90005817
Merge pull request #3772 from astroparam/escape-metacharacters 
escape metacharacters in job name
 2021-06-02 13:50:58 -05:00
Nate Smith
71547f4560
Merge pull request #3769 from browniebroke/feat/set-env-secrets 
Add support for setting environments secrets
 2021-06-02 13:35:08 -05:00