Commit graph

3723 commits

Author SHA1 Message Date
Mislav Marohnić
b5366c6ebf
Merge pull request #2794 from cristiand391/use-testify-assertion
Use Testify assertions in tests
2021-01-19 14:08:25 +01:00
Mislav Marohnić
75ebb863e3 Use testify assertions for error matching 2021-01-19 13:59:37 +01:00
Cristian Dominguez
45f4a1f087 Equal: flip arguments position 2021-01-18 21:00:59 -03:00
Mislav Marohnić
fc77cbc964 Deprecate test.ExpectLines
For asserting command output, exact string matches are preferred in most cases. In cases when a pattern match is needed, the test can use regexp ad hoc.
2021-01-18 23:25:45 +01:00
Mislav Marohnić
c308f1cd91 Prevent further use of SetPrepareCmd and InitCmdStubber 2021-01-18 22:44:53 +01:00
Mislav Marohnić
5531498f27 Migrate to new cmd stubber in repo fork tests 2021-01-18 22:42:27 +01:00
Mislav Marohnić
584b33e79c Migrate to new cmd stubber in repo clone tests 2021-01-18 22:42:13 +01:00
Mislav Marohnić
c63acf6728 Migrate to new cmd stubber in misc. tests 2021-01-18 22:42:01 +01:00
Mislav Marohnić
bf4bc1511f Migrate to new cmd stubber in merge tests 2021-01-18 20:15:40 +01:00
Mislav Marohnić
683ebee6ef Consistently use green success icon
For operations such as closing an issue or merging a PR, we would
display the success icon (a checkmark) in red and magenta colors,
respectively, to reflect the latest state of the record operated on
(red: closed; magenta: merged).

This was always confusing to me, seeing it both in code and in the UI,
because I'm instinctively thinking that it's a bug and have to remind
myself that it's by design.
2021-01-18 19:57:38 +01:00
Mislav Marohnić
6e5a90821c pr merge: handle case when a cross-repo PR was already merged
In this case, do not ever offer to delete the branch.
2021-01-18 19:49:20 +01:00
Mislav Marohnić
66546e2245 When pr merge --delete-branch flag is supplied, avoid prompting for it 2021-01-18 18:10:20 +01:00
Nilesh Singh
f3fcaf6c9c Fix error message text & add test case 2021-01-17 14:42:49 +05:30
Cristian Dominguez
3afb1d0b1a Use Testify assertions in test 2021-01-16 19:19:30 -03:00
Devon Romanko
df31fae9c6 remove prompt for deleting branches on pr merge in interactive mode when -d flag is passed 2021-01-15 17:34:00 -05:00
Devon Romanko
2c35eb04ff address pr comments 2021-01-15 16:54:46 -05:00
Devon Romanko
85e0e44920 Add prompt to delete local branch when attempting to merge a PR that is already merged 2021-01-15 07:25:24 -05:00
Nilesh Singh
2f5ffbd60a Add fail message for non-existent hostname 2021-01-15 13:28:57 +05:30
Sam
b0ae09e627
Merge pull request #2535 from cli/create-comments
Create issue comments
2021-01-12 11:24:09 -08:00
Cristian Dominguez
ce151420f3 Migrate legacy tests 2021-01-11 21:07:19 -03:00
Sam Coe
723e9e31ba
Address PR comments 2021-01-11 13:56:17 -08:00
Sam Coe
155507d31d
Make comment command easier to test 2021-01-05 15:14:25 -08:00
xhqr
8b5c5896f2
[repo/create] Create local repo dir with non tty. (#2671)
This addresses issue #2587.
2021-01-05 14:40:52 -08:00
Sam Coe
1fc8b66b26
Address PR comments 2021-01-05 10:36:03 -08:00
Sam Coe
f862123071
Modify issue commenting to adhere to designs and add tests 2021-01-05 10:35:09 -08:00
Yuki Osaki
338bf1d112
fix linter issue 2021-01-05 10:35:09 -08:00
Yuki Osaki
8ef2bb4d14
Comment on issues from editor 2021-01-05 10:35:09 -08:00
Camelid
8ff4cc40e6 view: Add missing newline
Add a newline at the end of the 'View this {issue, pull request} on
GitHub' message. `gh repo view` already had a newline at the end, so
this only changes `issue view` and `pr view`.
2020-12-27 11:37:59 -08:00
Cristian Dominguez
55c717d3d3 Print friendly error when 'gh gist <command>' is missing required argument 2020-12-21 10:01:30 -03:00
Nate Smith
230441e1a5
Merge pull request #2222 from Crunch09/issue-2115
add `gist clone` command
2020-12-18 13:07:44 -08:00
Mislav Marohnić
782932bfae
Merge pull request #2636 from cli/docs-completion
Improve `completion` docs for bash, zsh, fish
2020-12-17 18:21:19 +01:00
Mislav Marohnić
18b19e074d Fix link in version output
It now correctly links to the tagged release instead of to the latest
release.
2020-12-17 12:37:22 +01:00
Mislav Marohnić
9d50221669 Improve completion docs for bash, zsh, fish 2020-12-16 16:57:28 +01:00
Nate Smith
3b1e526a27
Merge pull request #2529 from cli/441-secrets
gh secret {set,list,remove}
2020-12-15 11:16:53 -06:00
Mislav Marohnić
65e5ba9da1
Merge pull request #2493 from gunadhya/repo-clone-wiki
Initial fix for gh-repo-clone wiki
2020-12-15 18:01:55 +01:00
Mislav Marohnić
39a0a8c57c Improve clone wiki test 2020-12-15 17:45:13 +01:00
gunadhya
fd57835bb9 Fix repo clone wiki 2020-12-15 17:45:03 +01:00
Mislav Marohnić
a77f3ddb49
Merge pull request #2575 from cli/pr-view-comments
Add ability to view comments with `pr view`
2020-12-15 16:31:03 +01:00
Mislav Marohnić
1e4fa60478
Merge pull request #2462 from cli/view-comments
Add issue comment viewing
2020-12-15 16:22:32 +01:00
Mislav Marohnić
b1f93426eb
Merge pull request #2449 from cli/git-credentials
Set up git authentication when logging in to gh
2020-12-15 16:14:07 +01:00
vilmibm
352cde0563 do not process filename arguments 2020-12-14 10:44:26 -08:00
vilmibm
a5a043c5a5 automatically set vis when just -r passed 2020-12-10 15:24:09 -08:00
vilmibm
3306351162 use type for Visibility 2020-12-10 15:11:08 -08:00
vilmibm
e1e838c281 more explicit success message 2020-12-10 15:04:56 -08:00
vilmibm
2e6639fe78 show number of selected repositories in secret list 2020-12-10 14:59:37 -08:00
vilmibm
408d5c6d96 no space in usage placeholder 2020-12-10 13:23:35 -08:00
vilmibm
4e8a680575 remove implied org functionality from secret set 2020-12-10 13:22:11 -08:00
vilmibm
1675bd9249 remove implied org functionality from secret remove
also fill in missing test cases >_>
2020-12-10 12:45:38 -08:00
vilmibm
c036e6699c remove implied org functionality from secret list 2020-12-10 12:36:57 -08:00
vilmibm
2248565839 print success messages 2020-12-09 17:37:13 -08:00