Mislav Marohnić
6d0da077b6
Merge pull request #1631 from cli/color-env
...
Add support for CLICOLOR standard
2020-09-16 18:20:13 +02:00
Mislav Marohnić
cd32ef8389
Merge pull request #1708 from cli/wsl-detection
...
Fallback browser when `xdg-open` does not exist
2020-09-16 18:16:27 +02:00
Mislav Marohnić
b2de27c624
Fix Survey's presentation of default values
...
For default values for e.g. `Input` prompts, Survey uses the literal "white" color, which makes no sense on dark terminals and is literally invisible on light backgrounds.
This overrides Survey to output a gray color for 256-color terminals and "default" for basic terminals.
2020-09-16 17:57:13 +02:00
Mislav Marohnić
88aacc14f0
Fix gray color presentation across terminals
...
We used to send the ANSI sequence for "bright black" when we wanted gray, but this color turns out to not be visible in some popular color schemes.
Instead, when we detect a 256-color terminal, switch to displaying a color sequence for gray that is consistent and does not depend on terminal color scheme.
2020-09-16 17:57:13 +02:00
Sam Coe
9058feebec
Fix up structure for better testing
2020-09-16 17:19:11 +02:00
Sam Coe
fd1d09dfc2
Clean up linux logic to have better default logic
2020-09-16 16:56:47 +02:00
Mislav Marohnić
086d8ed29a
Merge remote-tracking branch 'origin' into color-env
2020-09-16 16:51:38 +02:00
Mislav Marohnić
3049db646f
Merge pull request #1630 from cli/pager-for-everyone
...
Extend PAGER support to all commands producing significant output
2020-09-16 16:22:58 +02:00
Mislav Marohnić
fa2513dea6
Document PAGER environment variable
2020-09-16 16:15:57 +02:00
Mislav Marohnić
f6dd1bcd0a
Add the pager config option
2020-09-16 16:15:37 +02:00
Mislav Marohnić
c643778701
Have only one test assert default config rendering
2020-09-16 16:10:53 +02:00
Sam Coe
7551139caf
Address PR comments
2020-09-16 16:04:58 +02:00
Mislav Marohnić
00ac966c65
Merge remote-tracking branch 'origin' into pager-for-everyone
2020-09-16 15:58:54 +02:00
Mislav Marohnić
5a2c7e7957
Merge pull request #1707 from cli/fix-zsh-autocomplete
...
Remove square brackets from persistent flag description to fix zsh autocomplete
2020-09-16 15:53:41 +02:00
Sam Coe
dd1c24a20a
Use LookPath to determine if xdg-open exists
2020-09-16 15:52:34 +02:00
Sam Coe
6d111b2458
Use WSL2 detection to pick browser
2020-09-16 14:45:06 +02:00
Sam Coe
3f3c781ab6
Remove square brackets from persistent flag description to fix zsh autocomplete
2020-09-16 11:47:15 +02:00
Nate Smith
2071c72a05
Merge pull request #1705 from cli/feedback-tmpl
...
add issue template for general feedback
2020-09-15 13:01:04 -05:00
Nate Smith
50211eade3
add issue template for general feedback
...
is this a good idea?
2020-09-15 12:00:07 -05:00
Sam
4933fd9415
Merge pull request #1696 from cli/env-help-topic
...
Extract environment variables as a separate help topic
2020-09-15 17:21:32 +02:00
Nate Smith
9f486efbc6
hackday: gh repo garden ( #1049 )
...
* add gh repo garden
* move file
* oops
* fixes
* fix clearing
* block windows sadly
* broken wip
* fix api thing
* do not add to client
* move helper as it does not work on windows
* hide command
* macos fix
* Update pkg/cmd/repo/garden/garden.go
Co-authored-by: Lee Reilly <lee@github.com>
* default for key input loop
* get redrawing working
* clean up garden update, it all works
* notes
* fix arrow keys and just do wads/arrows/vi
* this function is only called once now
* support ghes
* add a progress indicator
* cap maxCommits
Co-authored-by: Lee Reilly <lee@github.com>
2020-09-15 09:59:27 -05:00
Nate Smith
6d63e37466
Merge pull request #1704 from cristiand391/cristiand391-patch-1
...
Go 1.15+ is required to run the test suit
2020-09-15 09:54:47 -05:00
Nate Smith
0c0e042e72
Merge pull request #1642 from cli/web-flag
...
support auth login --web
2020-09-15 09:37:41 -05:00
Mislav Marohnić
8b9d4274b7
Merge pull request #1697 from cli/release-download-fix
...
Fix `release download`
2020-09-15 15:12:59 +02:00
Mislav Marohnić
50291aa6de
Add PAGER support to the api command
2020-09-15 11:43:49 +02:00
Cristian Dominguez
3d350e8707
Go 1.15+ is required to run the test suit
2020-09-14 20:31:22 +00:00
Sam Coe
7ecb6a413f
Add tests for help topics
2020-09-14 22:27:17 +02:00
Amanda Pinsker
a50b0dbc11
Merge pull request #1700 from cli/fix-config
...
Tweak config help docs
2020-09-14 14:09:00 -04:00
Amanda Pinsker
db77f2dc66
Add examples
2020-09-14 12:42:13 -04:00
Amanda Pinsker
c3863e35b4
Add prompt to gh config help
2020-09-14 12:40:56 -04:00
Sam Coe
21449213e5
Expand help topic functionality
2020-09-14 17:50:50 +02:00
vilmibm
68a019cc3c
review feedback
2020-09-14 10:16:50 -05:00
Mislav Marohnić
76181156ba
Prevent endless recursive pager
...
Unset PAGER environment variable when executing the command referenced
in PAGER in case that command also has support for PAGER and would end
up executing itself indefinitely.
2020-09-14 16:49:30 +02:00
Mislav Marohnić
3c32507a13
Consistent use of quotes to delineate commands to be run
2020-09-14 16:26:23 +02:00
Mislav Marohnić
aa72463114
Extract environment as a separate help topic
...
Co-authored-by: Sam Coe <samcoe@github.com>
2020-09-14 16:25:30 +02:00
Mislav Marohnić
662f83fcb9
Fix release download
...
Only ever try to set an `Authorization` request header to hosts that we
have OAuth credentials for; skip the header otherwise.
2020-09-14 15:31:31 +02:00
Mislav Marohnić
6ad6784c46
Ignore EPIPE when forwarding pr diff output to pager
2020-09-14 15:30:10 +02:00
Mislav Marohnić
b2e7f0c1e2
Merge remote-tracking branch 'origin' into pager-for-everyone
2020-09-14 14:18:42 +02:00
Sam
b34fe8123a
Merge pull request #1677 from cli/fix-issue-list-emoji-bug
...
Fix issue listing misalignment
2020-09-12 19:07:56 +02:00
vilmibm
2345f49ccb
support auth login --web
2020-09-11 13:07:39 -05:00
Nate Smith
5a8df475b9
Merge pull request #1639 from cli/disable-prompts
...
Support "prompt" config setting
2020-09-11 12:07:44 -05:00
vilmibm
a811e72c9d
do not assume public when creating repo non-interactively
2020-09-11 11:57:40 -05:00
vilmibm
3a492b892a
Merge branch 'disable-prompts' of github.com:cli/cli into disable-prompts
2020-09-11 11:42:20 -05:00
vilmibm
2e95e279e3
reuse cfg reference
2020-09-11 11:38:26 -05:00
vilmibm
1073c97409
review feedback
2020-09-11 11:36:24 -05:00
Sam Coe
e5466c0411
Improve string display width calculation
2020-09-11 11:56:54 +02:00
Tony Rosler
4ef8a75ae2
Handle runtime error on bad user input ( #1652 )
2020-09-11 11:23:24 +02:00
Sam
d544f7f8da
Merge pull request #1657 from cli/fix-repo-view-bug
...
Do not html escape repo view output
2020-09-11 07:47:58 +02:00
vilmibm
4d3e26e927
prompts disabled test for auth refresh
...
the behavior for nontty vs. prompts disabled is pretty different so i
opted for a new test, here
2020-09-10 13:19:43 -05:00
vilmibm
c0fc31f7d5
use CanPrompt in commands
2020-09-10 12:13:48 -05:00