STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
3003 commits 87 branches 0 tags 160 MiB
Commit graph

586 commits

Author SHA1 Message Date
Sam Coe
71a66cc8d6
Fix merge 2021-01-21 12:53:04 -08:00
Sam Coe
a9123966e3
Merge branch 'trunk' into 1190-limit-merge-methods 2021-01-21 12:45:10 -08:00
vilmibm
48c89076f6 add positive case test 2021-01-21 12:04:19 -08:00
vilmibm
a27a94f8b5 Merge remote-tracking branch 'origin/trunk' into repo-fork-gitflags 2021-01-21 11:58:20 -08:00
Sam
938f6f4bdd
Merge pull request #2809 from cli/deadcode 
delete unused parameter
 2021-01-21 09:56:15 -08:00
Mislav Marohnić
a70b69e359
Bring the "Press Enter" UI closer to the authentication experience 
- "Press Enter" is both bold
- "Enter" is capitalized
- The prompt ends with "..."
 2021-01-21 09:47:38 -08:00
Sam Coe
a26fba7800
Comment on pull requests 2021-01-21 09:47:38 -08:00
Mislav Marohnić
10b1314dc1 Hide ssh-key command until it's ready for prime-time 2021-01-21 17:55:44 +01:00
Mislav Marohnić
ad62d6a471
Merge pull request #2798 from cli/pr-merge-crossrepo 
Handle case when a cross-repo PR was already merged
 2021-01-21 17:36:00 +01:00
Mislav Marohnić
4158209d50
Merge pull request #2811 from cli/utils-spinner-buh-bye 
Retire utils.Spinner in favor of IOStreams.StartProgressIndicator
 2021-01-21 17:34:39 +01:00
vilmibm
509e5dd0c9 fix tests 2021-01-20 16:10:56 -08:00
vilmibm
99c312e8ce accept a remote name instead of doing magic remote naming in repo fork 2021-01-20 15:32:19 -08:00
vilmibm
03f99a0140 Merge remote-tracking branch 'origin/trunk' into remote-renaming-847 2021-01-20 15:10:20 -08:00
Nate Smith
5430728a0a
Merge pull request #2813 from cli/token-from-env-err 
More descriptive error when aborting auth due to environment variables
 2021-01-20 15:06:52 -08:00
Björn Heinrichs
c9f79271b1
Add --maintainer-edit flag (#2250) 
* Add --maintainer-edit flag

Closes #2213 while retaining backwards compatibility.

* Fix linting

* Adjust documentation and validation

* Negate logic and fix build errors

* rename to no-maintainer-edit

* test

* use a positive option instead of negative

Co-authored-by: vilmibm <vilmibm@github.com>
 2021-01-20 14:51:27 -08:00
Sam Coe
b9b1079493
Display reviews when viewing pull requests 2021-01-20 12:15:25 -08:00
Mislav Marohnić
dcf5a27f53
Merge pull request #1862 from edualb/trunk 
[#1755] SSH key management (gh ssh-key list)
 2021-01-20 20:47:21 +01:00
Mislav Marohnić
4a2cc8d2a4 Simplify ssh-key list 
Do not require nor request `read:public_key` scope by default.
 2021-01-20 20:23:57 +01:00
edualb
e26a1b98a1 add ssh-key command 2021-01-20 20:23:38 +01:00
Cristian Dominguez
2086d135f3
Respect system/user timezone in API requests (#2630) 
* Respect system/user timezone in API requests

* Fall back to a known timezone if TZ is not set

Co-authored-by: Cristian Dominguez <cristiand391@users.noreply.github.com>
 2021-01-20 10:44:46 -08:00
Mislav Marohnić
c9407b2629 More descriptive error when aborting auth due to environment variables 
Old message:

    read-only token in GH_TOKEN cannot be modified

This message was vague and some users did not understand that this
refers to the value that is read from environment variables.

New message:

    $ GH_TOKEN=123 ghd auth login -h github.com
    The value of the GH_TOKEN environment variable is being used for authentication.
    To have GitHub CLI store credentials instead, first clear the value from the environment.
 2021-01-20 18:27:35 +01:00
Mislav Marohnić
a2bee1fad3 🔥 utils.Spinner 2021-01-20 14:48:14 +01:00
Mislav Marohnić
aa0de5f636 Stop using utils.Spinner in repo fork 2021-01-20 14:46:45 +01:00
vilmibm
3797aa72ff delete unused parameter 2021-01-19 19:08:49 -08:00
Mislav Marohnić
b5366c6ebf
Merge pull request #2794 from cristiand391/use-testify-assertion 
Use Testify assertions in tests
 2021-01-19 14:08:25 +01:00
Mislav Marohnić
75ebb863e3 Use testify assertions for error matching 2021-01-19 13:59:37 +01:00
Cristian Dominguez
45f4a1f087 Equal: flip arguments position 2021-01-18 21:00:59 -03:00
Mislav Marohnić
6e5a90821c pr merge: handle case when a cross-repo PR was already merged 
In this case, do not ever offer to delete the branch.
 2021-01-18 19:49:20 +01:00
Mislav Marohnić
66546e2245 When pr merge --delete-branch flag is supplied, avoid prompting for it 2021-01-18 18:10:20 +01:00
Cristian Dominguez
3afb1d0b1a Use Testify assertions in test 2021-01-16 19:19:30 -03:00
Devon Romanko
df31fae9c6 remove prompt for deleting branches on pr merge in interactive mode when -d flag is passed 2021-01-15 17:34:00 -05:00
Devon Romanko
2c35eb04ff address pr comments 2021-01-15 16:54:46 -05:00
Devon Romanko
85e0e44920 Add prompt to delete local branch when attempting to merge a PR that is already merged 2021-01-15 07:25:24 -05:00
Sam
b0ae09e627
Merge pull request #2535 from cli/create-comments 
Create issue comments
 2021-01-12 11:24:09 -08:00
Cristian Dominguez
ce151420f3 Migrate legacy tests 2021-01-11 21:07:19 -03:00
Sam Coe
723e9e31ba
Address PR comments 2021-01-11 13:56:17 -08:00
Sam Coe
155507d31d
Make comment command easier to test 2021-01-05 15:14:25 -08:00
xhqr
8b5c5896f2
[repo/create] Create local repo dir with non tty. (#2671) 
This addresses issue #2587.
 2021-01-05 14:40:52 -08:00
Sam Coe
1fc8b66b26
Address PR comments 2021-01-05 10:36:03 -08:00
Sam Coe
f862123071
Modify issue commenting to adhere to designs and add tests 2021-01-05 10:35:09 -08:00
Yuki Osaki
338bf1d112
fix linter issue 2021-01-05 10:35:09 -08:00
Yuki Osaki
8ef2bb4d14
Comment on issues from editor 2021-01-05 10:35:09 -08:00
Camelid
8ff4cc40e6 view: Add missing newline 
Add a newline at the end of the 'View this {issue, pull request} on
GitHub' message. `gh repo view` already had a newline at the end, so
this only changes `issue view` and `pr view`.
 2020-12-27 11:37:59 -08:00
Nate Smith
230441e1a5
Merge pull request #2222 from Crunch09/issue-2115 
add `gist clone` command
 2020-12-18 13:07:44 -08:00
Mislav Marohnić
782932bfae
Merge pull request #2636 from cli/docs-completion 
Improve `completion` docs for bash, zsh, fish
 2020-12-17 18:21:19 +01:00
Mislav Marohnić
18b19e074d Fix link in version output 
It now correctly links to the tagged release instead of to the latest
release.
 2020-12-17 12:37:22 +01:00
Mislav Marohnić
9d50221669 Improve completion docs for bash, zsh, fish 2020-12-16 16:57:28 +01:00
Nate Smith
3b1e526a27
Merge pull request #2529 from cli/441-secrets 
gh secret {set,list,remove}
 2020-12-15 11:16:53 -06:00
Mislav Marohnić
65e5ba9da1
Merge pull request #2493 from gunadhya/repo-clone-wiki 
Initial fix for gh-repo-clone wiki
 2020-12-15 18:01:55 +01:00
Mislav Marohnić
39a0a8c57c Improve clone wiki test 2020-12-15 17:45:13 +01:00